diff options
| author | Claude <noreply@anthropic.com> | 2026-09-21 09:20:39 +0000 |
|---|---|---|
| committer | Claude <noreply@anthropic.com> | 2026-09-21 09:20:39 +0000 |
| commit | 21be685b941024269aca56a688620940f36deeef (patch) | |
| tree | 84e1099bc01ca589dfeb484e1033b7a79fcb0527 /config | |
| parent | 537b729b6837f48483e38d1a5fbe64f487a79a38 (diff) | |
UI, wiring, and an end-to-end test against a real feed
Library, subscription and queue screens over the finished data layer, plus a
share receiver that actually resolves rather than toasting a placeholder.
Two things the screens deliberately surface: a subscription whose last refresh
failed shows the reason inline, because a feed that has quietly stopped
working is otherwise indistinguishable from one with nothing new; and a failed
subscribe reports the actual error rather than "could not subscribe", since a
share sheet gets exactly one chance to tell the user anything.
The share receiver had a real bug on the way in -- finishing the activity to
dismiss the "Resolving..." toast cancelled lifecycleScope and took the network
call with it. It now stays alive until the subscribe completes.
Screens.kt was split into one file per screen rather than relaxing detekt's
function-count rule a fourth time. Four exemptions in one session starts
sanding the gate down instead of using it.
QueueRepository is tested for the invariant that matters: every operation
leaves queue positions contiguous from zero, since a gap or duplicate renders
wrongly and reorders unpredictably.
The end-to-end instrumented test is the part the JVM suite cannot do: it runs
against real Room rather than fake DAOs, so the schema, converters and
constraints are actually executed. Against a live feed it stored 2753 episodes
and a second refresh returned Unchanged, exercising conditional GET and the
matcher's identity rules on real data instead of fixtures.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018AwnALZL6bD4VBtATDVv3B
Diffstat (limited to 'config')
| -rw-r--r-- | config/detekt/detekt.yml | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/config/detekt/detekt.yml b/config/detekt/detekt.yml index 6d7c04f..3d282f5 100644 --- a/config/detekt/detekt.yml +++ b/config/detekt/detekt.yml @@ -19,6 +19,9 @@ complexity: thresholdInInterfaces: 20 # Room DAOs are broad by nature -- each query is a method, and # splitting one table's access across several interfaces to satisfy a count would make the # data layer harder to follow, not easier. + thresholdInClasses: 20 # same for the view model: it is a flat list of one-line user actions + # (enqueue, download, mark played), and splitting it by count rather than by meaning would + # scatter related behaviour across types for no gain. naming: FunctionNaming: |