diff options
| author | Peter Stone <thepeterstone@gmail.com> | 2026-08-24 07:54:01 +0000 |
|---|---|---|
| committer | Peter Stone <thepeterstone@gmail.com> | 2026-08-24 07:54:01 +0000 |
| commit | da942624a4abd82797f563cf8c57f1124c5de435 (patch) | |
| tree | f7e4325a4783a77544e6ed1f0ac44ea844757fe8 /app/src/main/res | |
| parent | b299d57d6cc240381aed51f91e5a26f1e633d78d (diff) | |
Add TDD quality gate: detekt, coverage tracking, pre-commit hook; fix theme crash risk
CLAUDE.md now documents mandatory red-green-refactor TDD, a per-commit
quality gate (build, tests, lint, detekt, coverage-non-decrease,
WebView-JS justification, manifest permission diff, secret scan), and
why each check exists (tracing back to real bugs this audit found).
Wires up detekt (static analysis) and a standalone Jacoco setup
(scoped to data/readability/opml/work/stash -- ui/ Compose screens
are impractical to unit-test for coverage) via app/build.gradle.kts.
Bumped Kotlin/KSP to 2.0.21/2.0.21-1.0.28 to match detekt 1.23.8's
compatibility requirement.
Also fixes the themes.xml bug the lint gate immediately caught:
Theme.FeedReader's parent required API 29 while minSdk is 26 -- a
real crash risk on Android 8.0-9.0 devices. Swapped to the plain
(non-DayNight) DeviceDefault parent, since Compose already owns all
real theming via a hardcoded darkColorScheme() regardless of system
day/night state.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017GMEkHeqKz6FLkmizowBTK
Diffstat (limited to 'app/src/main/res')
| -rw-r--r-- | app/src/main/res/values/themes.xml | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/app/src/main/res/values/themes.xml b/app/src/main/res/values/themes.xml index 9c5f0ff..b1eb502 100644 --- a/app/src/main/res/values/themes.xml +++ b/app/src/main/res/values/themes.xml @@ -1,6 +1,10 @@ <?xml version="1.0" encoding="utf-8"?> <resources> - <style name="Theme.FeedReader" parent="android:Theme.DeviceDefault.DayNight"> + <!-- DayNight requires API 29 (minSdk here is 26) and buys nothing anyway: Compose owns all + real theming via darkColorScheme() regardless of system day/night state (see + MainActivity.kt), so this base window theme only ever needs to supply window chrome + (no title/action bar), not day/night-aware colors. --> + <style name="Theme.FeedReader" parent="android:Theme.DeviceDefault"> <item name="android:windowActionBar">false</item> <item name="android:windowNoTitle">true</item> </style> |