diff options
| author | Peter Stone <thepeterstone@gmail.com> | 2026-10-22 21:06:44 +0000 |
|---|---|---|
| committer | Peter Stone <thepeterstone@gmail.com> | 2026-10-22 21:06:44 +0000 |
| commit | 9bf135585885b043a05f3e74197314bdb4633c67 (patch) | |
| tree | 02b76001144b26d8711a6c3f47c4a01bfbcc97cb /app/src/main/java/org/terst/feedreader/readability/ConsentNotice.kt | |
| parent | 4fa99073761bbedcdc2bce45a666399bf4b425aa (diff) | |
Hardware-accelerate the video dialog's own window
Peter, on the referrer build: the player "plays and shows controls,
with a white screen instead of video. The scrubber thumbnails pop up,
but the main playback is blank white." His screenshot shows YouTube's
title, gear, play button, timecode and progress bar all drawn
correctly over a blank area.
That narrows it a long way. Everything the page renders -- chrome,
gradients, the storyboard images behind the scrubber -- composites
fine, so the renderer is healthy and the embed is right. The one thing
missing is the only thing that does not come from the page: video is
composited from a separate surface, and that needs the window it sits
in to be hardware accelerated.
The player is a Dialog, which is its own Window. The activity declares
android:hardwareAccelerated, but that does not carry to a Window a
dialog creates for itself, so the flag is now set on it explicitly.
No new logic, so nothing new to unit-test: the URL and referrer this
loads are unchanged and still covered by YouTubeLinksTest. It is a
property of the window the existing WebView lives in.
Unverified here, and this emulator cannot settle it: it has no working
video path at all in a WebView. It hard-crashed the AVD twice on a
plain <video>, and with software decoding forced it survives but
renders a broken-media placeholder rather than a picture. Everything
up to display is confirmed on-device; display is not.
If the picture is still missing, this rules the window out and the
remaining suspect is the surface itself, which means taking the player
out of a floating window entirely.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018AwnALZL6bD4VBtATDVv3B
Diffstat (limited to 'app/src/main/java/org/terst/feedreader/readability/ConsentNotice.kt')
0 files changed, 0 insertions, 0 deletions
