diff options
| author | Peter Stone <thepeterstone@gmail.com> | 2026-08-24 08:00:51 +0000 |
|---|---|---|
| committer | Peter Stone <thepeterstone@gmail.com> | 2026-08-24 08:00:51 +0000 |
| commit | a0708d3785b93421273e09e0097a43db053937b2 (patch) | |
| tree | 77e9ed031f0c41e3c2d3fc2703830692e6cd8068 | |
| parent | 49a557e4c7118b6457c251ea2cb642ded709999c (diff) | |
Remove 3 confirmed-dead DAO methods
ArticleDao.delete(article) -- superseded by deleteUnsavedByFeed.
ArticleDao.markAllReadForFeed -- no "mark all read for this feed" UI
action exists; superseded by the id-list-based markReadBatchChunked.
FilterRuleDao.getAll() -- every caller uses the Flow-returning
observeAll() instead. Re-verified all three have zero callers beyond
their own declaration before removing.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017GMEkHeqKz6FLkmizowBTK
| -rw-r--r-- | app/src/main/java/org/terst/feedreader/data/Daos.kt | 10 |
1 files changed, 0 insertions, 10 deletions
diff --git a/app/src/main/java/org/terst/feedreader/data/Daos.kt b/app/src/main/java/org/terst/feedreader/data/Daos.kt index 20632f8..d55b7b7 100644 --- a/app/src/main/java/org/terst/feedreader/data/Daos.kt +++ b/app/src/main/java/org/terst/feedreader/data/Daos.kt @@ -1,7 +1,6 @@ package org.terst.feedreader.data import androidx.room.Dao -import androidx.room.Delete import androidx.room.Insert import androidx.room.OnConflictStrategy import androidx.room.Query @@ -178,9 +177,6 @@ interface ArticleDao { @Query("UPDATE articles SET isRead = 1, readAt = :readAt WHERE id IN (:ids)") suspend fun markReadBatch(ids: List<String>, readAt: Long) - @Query("UPDATE articles SET isRead = 1, readAt = :readAt WHERE feedId = :feedId") - suspend fun markAllReadForFeed(feedId: String, readAt: Long) - // Run when unsubscribing from a feed. Saved articles are deliberately kept // regardless (isSaved is a separate, durable "keep forever" concept, // independent of subscription) -- everything else is deleted so it doesn't @@ -199,9 +195,6 @@ interface ArticleDao { @Query("UPDATE articles SET stashArtifactId = :artifactId WHERE id = :id") suspend fun setStashArtifactId(id: String, artifactId: String) - - @Delete - suspend fun delete(article: ArticleEntity) } // A single markReadBatch(ids) call builds one query with one bound parameter per id -- @@ -218,9 +211,6 @@ interface FilterRuleDao { @Query("SELECT * FROM filter_rules ORDER BY createdAt DESC") fun observeAll(): Flow<List<FilterRuleEntity>> - @Query("SELECT * FROM filter_rules") - suspend fun getAll(): List<FilterRuleEntity> - @Insert suspend fun insert(rule: FilterRuleEntity): Long |