summaryrefslogtreecommitdiff
path: root/internal/handlers/buckets_test.go
blob: 822083b5b0e9951f3c09eea223d1d13ba2bb3f53 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
package handlers

import (
	"encoding/json"
	"net/http"
	"net/http/httptest"
	"strings"
	"testing"
	"time"

	"task-dashboard/internal/models"
)

func TestHandleWidgetBucketsCreate_CreatesBucket(t *testing.T) {
	db, cleanup := setupTestDB(t)
	defer cleanup()
	h := &Handler{store: db}

	body := `{"name":"Gutters","cycle_days":30,"pick_n":2}`
	req := httptest.NewRequest("POST", "/api/widget/buckets", strings.NewReader(body))
	w := httptest.NewRecorder()
	h.HandleWidgetBucketsCreate(w, req)

	if w.Code != http.StatusOK {
		t.Fatalf("status = %d, want 200, body=%s", w.Code, w.Body.String())
	}
	var bucket models.MaintenanceBucket
	if err := json.NewDecoder(w.Body).Decode(&bucket); err != nil {
		t.Fatal(err)
	}
	if bucket.Name != "Gutters" || bucket.CycleDays != 30 || bucket.PickN != 2 {
		t.Errorf("bucket = %+v", bucket)
	}
}

func TestHandleWidgetBucketsCreate_InvalidPickN_Returns400(t *testing.T) {
	db, cleanup := setupTestDB(t)
	defer cleanup()
	h := &Handler{store: db}

	body := `{"name":"Gutters","cycle_days":30,"pick_n":0}`
	req := httptest.NewRequest("POST", "/api/widget/buckets", strings.NewReader(body))
	w := httptest.NewRecorder()
	h.HandleWidgetBucketsCreate(w, req)

	if w.Code != http.StatusBadRequest {
		t.Fatalf("status = %d, want 400", w.Code)
	}
}

func TestHandleWidgetBucketsGet_ReturnsBuckets(t *testing.T) {
	db, cleanup := setupTestDB(t)
	defer cleanup()
	h := &Handler{store: db}
	if _, err := h.store.CreateBucket("Gutters", 30, 2); err != nil {
		t.Fatal(err)
	}

	req := httptest.NewRequest("GET", "/api/widget/buckets", nil)
	w := httptest.NewRecorder()
	h.HandleWidgetBucketsGet(w, req)

	if w.Code != http.StatusOK {
		t.Fatalf("status = %d, want 200", w.Code)
	}
	var buckets []models.MaintenanceBucket
	if err := json.NewDecoder(w.Body).Decode(&buckets); err != nil {
		t.Fatal(err)
	}
	if len(buckets) != 1 || buckets[0].Name != "Gutters" {
		t.Errorf("buckets = %+v", buckets)
	}
}

func TestHandleWidgetBucketItemsAdd_AssignsTask(t *testing.T) {
	db, cleanup := setupTestDB(t)
	defer cleanup()
	h := &Handler{store: db}
	bucket, err := h.store.CreateBucket("Gutters", 30, 2)
	if err != nil {
		t.Fatal(err)
	}
	task := models.Task{ID: "task-1", Content: "Clean gutters", Priority: 1}
	if err := h.store.CreateNativeTask(task); err != nil {
		t.Fatal(err)
	}

	body := `{"task_id":"task-1"}`
	req := withURLParam(httptest.NewRequest("POST", "/api/widget/buckets/"+bucket.ID+"/items", strings.NewReader(body)), "id", bucket.ID)
	w := httptest.NewRecorder()
	h.HandleWidgetBucketItemsAdd(w, req)

	if w.Code != http.StatusOK {
		t.Fatalf("status = %d, want 200, body=%s", w.Code, w.Body.String())
	}
	updated, err := h.store.GetNativeTaskByID("task-1")
	if err != nil {
		t.Fatal(err)
	}
	if updated.BucketID != bucket.ID || updated.BucketState != "dormant" {
		t.Errorf("task = %+v", updated)
	}
}

func TestHandleWidgetBucketItemsAdd_UnknownTask_Returns404(t *testing.T) {
	db, cleanup := setupTestDB(t)
	defer cleanup()
	h := &Handler{store: db}
	bucket, err := h.store.CreateBucket("Gutters", 30, 2)
	if err != nil {
		t.Fatal(err)
	}

	body := `{"task_id":"nope"}`
	req := withURLParam(httptest.NewRequest("POST", "/api/widget/buckets/"+bucket.ID+"/items", strings.NewReader(body)), "id", bucket.ID)
	w := httptest.NewRecorder()
	h.HandleWidgetBucketItemsAdd(w, req)

	if w.Code != http.StatusNotFound {
		t.Fatalf("status = %d, want 404", w.Code)
	}
}

func TestHandleWidgetTaskDefer_ReturnsToDormant(t *testing.T) {
	db, cleanup := setupTestDB(t)
	defer cleanup()
	h := &Handler{store: db}
	// pick_n=1 with a spare reserve item in the pool: activate one, then
	// defer it -- the reserve is what backfill should pick, so the
	// just-deferred item (now the pool's only dormant item at the moment
	// selectBucketCycle would otherwise look) isn't immediately re-picked.
	bucket, err := h.store.CreateBucket("Gutters", 30, 1)
	if err != nil {
		t.Fatal(err)
	}
	if err := h.store.CreateNativeTask(models.Task{ID: "task-1", Content: "task-1", Priority: 1}); err != nil {
		t.Fatal(err)
	}
	if err := h.store.AddBucketItem(bucket.ID, "task-1"); err != nil {
		t.Fatal(err)
	}
	// Activate task-1 via a real cycle run so it's a legit active bucket item.
	if _, err := h.store.RunBucketCycles(time.Now()); err != nil {
		t.Fatal(err)
	}
	// Add the reserve item AFTER the cycle runs, so it's still dormant when task-1 is deferred.
	if err := h.store.CreateNativeTask(models.Task{ID: "reserve", Content: "reserve", Priority: 1}); err != nil {
		t.Fatal(err)
	}
	if err := h.store.AddBucketItem(bucket.ID, "reserve"); err != nil {
		t.Fatal(err)
	}

	body := `{"id":"task-1"}`
	req := httptest.NewRequest("POST", "/api/widget/task/defer", strings.NewReader(body))
	w := httptest.NewRecorder()
	h.HandleWidgetTaskDefer(w, req)

	if w.Code != http.StatusOK {
		t.Fatalf("status = %d, want 200, body=%s", w.Code, w.Body.String())
	}
	updated, err := h.store.GetNativeTaskByID("task-1")
	if err != nil {
		t.Fatal(err)
	}
	if updated.BucketState != "dormant" {
		t.Errorf("BucketState = %q, want dormant", updated.BucketState)
	}
}

func TestHandleWidgetTaskDefer_NotABucketItem_Returns404(t *testing.T) {
	db, cleanup := setupTestDB(t)
	defer cleanup()
	h := &Handler{store: db}
	task := models.Task{ID: "task-1", Content: "Plain task", Priority: 1}
	if err := h.store.CreateNativeTask(task); err != nil {
		t.Fatal(err)
	}

	body := `{"id":"task-1"}`
	req := httptest.NewRequest("POST", "/api/widget/task/defer", strings.NewReader(body))
	w := httptest.NewRecorder()
	h.HandleWidgetTaskDefer(w, req)

	if w.Code != http.StatusNotFound {
		t.Fatalf("status = %d, want 404", w.Code)
	}
}