summaryrefslogtreecommitdiff
path: root/internal/store/native_tasks_test.go
diff options
context:
space:
mode:
authorPeter Stone <thepeterstone@gmail.com>2026-09-03 02:34:25 +0000
committerPeter Stone <thepeterstone@gmail.com>2026-09-03 02:34:25 +0000
commit1477ee531045388de9e7e797200e5cd14e4a6d0e (patch)
treeb5369768ed0da759d492fda7957ab25833759d78 /internal/store/native_tasks_test.go
parent699e31989e2c36513e02861f49672f8984ffe336 (diff)
Make the day's list a pull of committed work, not a push of everything unblocked
due_date had been carrying two incompatible meanings: "this has a real deadline" (Bills, meds, a signup cutoff) and "this is when I intend to work on it." Chains leaned entirely on the second -- every step was stamped due_date = now the moment it unlocked -- so a five-minute call and a six-month certification both arrived looking overdue, and the only way to quiet them was to hand-reschedule. The list therefore always contained work that could not be finished that day, which made ending a day at zero impossible by construction rather than by effort. Splits the two apart: - due_date keeps only its real meaning: an externally-imposed deadline. - committed_date (new, migration 031) means "I chose this for today." Chain steps no longer get a due date on unlock (CreateChain, advanceChain, and the delete-promotion path), and are excluded from the undated list so they don't simply fall through to it instead. They reach the day only by being committed, via a "+ today" control on the chain card. Bucket-active items get the same control. BuildTimeline pulls in committed tasks, deduped against tasks already present for a different reason (committed and due-today are two reasons for one row, not two rows). Migration 031 also clears the auto-stamped due dates from open chain steps; completed steps keep theirs as historical record. Two supporting changes made while in here: - Extracted the native_tasks SELECT list into nativeTaskColumns. It had been copy-pasted into nine queries that must each agree exactly with scanNativeTasks' field order; adding committed_date meant editing all nine correctly or silently breaking whichever was missed. - Extracted templateFuncMap() and added TestTemplates_AllParse. New() only logs a warning when template parsing fails, so a malformed template shipped silently and surfaced as a broken page at runtime. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018AwnALZL6bD4VBtATDVv3B
Diffstat (limited to 'internal/store/native_tasks_test.go')
-rw-r--r--internal/store/native_tasks_test.go47
1 files changed, 46 insertions, 1 deletions
diff --git a/internal/store/native_tasks_test.go b/internal/store/native_tasks_test.go
index 9453c86..70b775e 100644
--- a/internal/store/native_tasks_test.go
+++ b/internal/store/native_tasks_test.go
@@ -50,7 +50,8 @@ func newNativeTasksTestStore(t *testing.T) *Store {
bucket_id TEXT DEFAULT '',
bucket_state TEXT DEFAULT '',
bucket_last_active_at DATETIME,
- abandoned BOOLEAN DEFAULT 0
+ abandoned BOOLEAN DEFAULT 0,
+ committed_date DATE
)
`); err != nil {
t.Fatal(err)
@@ -798,3 +799,47 @@ func TestCompleteNativeTask_DoesNotAbandonAnything(t *testing.T) {
t.Errorf("abandoned = %d, want 0 -- a completed occurrence was done, not skipped", abandoned)
}
}
+
+func TestSetTaskCommitted_RoundTrips(t *testing.T) {
+ s := newNativeTasksTestStore(t)
+
+ today := config.Now()
+ if err := s.SetTaskCommitted("real-1", today); err != nil {
+ t.Fatalf("SetTaskCommitted: %v", err)
+ }
+
+ committed, err := s.GetCommittedTasks(today)
+ if err != nil {
+ t.Fatalf("GetCommittedTasks: %v", err)
+ }
+ if len(committed) != 1 || committed[0].ID != "real-1" {
+ t.Fatalf("GetCommittedTasks = %v, want exactly real-1", committed)
+ }
+
+ // A different day must not pick it up.
+ other, err := s.GetCommittedTasks(today.AddDate(0, 0, 1))
+ if err != nil {
+ t.Fatal(err)
+ }
+ if len(other) != 0 {
+ t.Errorf("tomorrow's committed list = %d task(s), want 0", len(other))
+ }
+
+ if err := s.ClearTaskCommitted("real-1"); err != nil {
+ t.Fatalf("ClearTaskCommitted: %v", err)
+ }
+ after, err := s.GetCommittedTasks(today)
+ if err != nil {
+ t.Fatal(err)
+ }
+ if len(after) != 0 {
+ t.Errorf("after clearing, committed list = %d task(s), want 0", len(after))
+ }
+}
+
+func TestSetTaskCommitted_UnknownID_ReturnsErrNotFound(t *testing.T) {
+ s := newNativeTasksTestStore(t)
+ if err := s.SetTaskCommitted("nope", config.Now()); !errors.Is(err, ErrNativeTaskNotFound) {
+ t.Fatalf("err = %v, want ErrNativeTaskNotFound", err)
+ }
+}