diff options
| author | Peter Stone <thepeterstone@gmail.com> | 2026-07-25 20:09:42 +0000 |
|---|---|---|
| committer | Peter Stone <thepeterstone@gmail.com> | 2026-07-25 20:09:42 +0000 |
| commit | 7f8cd6bfb894385b9ae310fd000cb921fef71cea (patch) | |
| tree | 08542eabe0463eb96b6878875699c92b1eeb9d80 /internal/handlers/timeline_logic_test.go | |
| parent | 231f6f81ef60888de7309f589b6ebd2634159524 (diff) | |
fix: undated tasks were landing in the widget's scheduled-events grid
ComputeDaySection unconditionally recomputed IsAllDay from a
midnight-time heuristic, clobbering the IsAllDay:true flag callers set
to mark floating (no-due-date) tasks -- since undated tasks use Time =
now, this silently reset IsAllDay to false and gave them a real Start,
so the widget could render them via EventBlock/HourRow instead of
TaskRow. Their click handler always opens the calendar/source URL, so
tapping a no-due-date task (e.g. a Google Task) opened Google Calendar
instead of the task detail sheet.
ComputeDaySection now only ever sets IsAllDay true, never clears an
already-true value. Also flag IsAllDay for undated Google Tasks, which
never got it set at all (only native undated doot tasks did).
Diffstat (limited to 'internal/handlers/timeline_logic_test.go')
| -rw-r--r-- | internal/handlers/timeline_logic_test.go | 42 |
1 files changed, 42 insertions, 0 deletions
diff --git a/internal/handlers/timeline_logic_test.go b/internal/handlers/timeline_logic_test.go index 7b5c47e..1a6ea6c 100644 --- a/internal/handlers/timeline_logic_test.go +++ b/internal/handlers/timeline_logic_test.go @@ -169,6 +169,48 @@ func TestBuildTimeline(t *testing.T) { } } +// TestBuildTimeline_UndatedGoogleTaskIsAllDay guards against a regression +// where a Google Task with no due date got Time set to "now" but IsAllDay +// left false (unlike nativeUndated doot tasks, which set IsAllDay: true). +// TimelineItemToWidgetItem then treated the near-"now" Time as a real +// scheduled Start, so the task could land among scheduledEvents and render +// via the widget's EventBlock/HourRow -- rows whose click handler always +// opens the source URL / Google Calendar instead of the task detail sheet. +func TestBuildTimeline_UndatedGoogleTaskIsAllDay(t *testing.T) { + s := setupTestStore(t) + + if err := s.SaveGoogleTasks([]models.GoogleTask{ + {ID: "g1", Title: "Hardware store", Status: "needsAction", ListID: "l1"}, + }); err != nil { + t.Fatalf("SaveGoogleTasks failed: %v", err) + } + + start := time.Now().Add(-24 * time.Hour) + end := time.Now().Add(24 * time.Hour) + items, err := BuildTimeline(context.Background(), s, start, end) + if err != nil { + t.Fatalf("BuildTimeline failed: %v", err) + } + + var found *models.TimelineItem + for i := range items { + if items[i].ID == "g1" { + found = &items[i] + } + } + if found == nil { + t.Fatal("expected undated google task g1 to appear in timeline") + } + if !found.IsAllDay { + t.Error("expected undated google task to be flagged IsAllDay so it stays a floating task on the widget, not a scheduled event") + } + + wi := TimelineItemToWidgetItem(*found) + if wi.Start != nil { + t.Error("expected undated google task to have nil Start so the widget renders it via TaskRow, not EventBlock") + } +} + func TestCalcCalendarBounds(t *testing.T) { tests := []struct { name string |
