summaryrefslogtreecommitdiff
path: root/internal/handlers/buckets_web_test.go
diff options
context:
space:
mode:
authorPeter Stone <thepeterstone@gmail.com>2026-07-18 09:38:26 +0000
committerPeter Stone <thepeterstone@gmail.com>2026-07-18 09:38:26 +0000
commit92909ebed5df68908f32c899de1e480f8d7fb01f (patch)
tree15fe3e0d69c2967d0b449101ff2384187b239c4e /internal/handlers/buckets_web_test.go
parentf08f06bef47aac2c9effb4cec650d99c2deb2dd7 (diff)
Add bucket CRUD and read-only Projects/Labels to Settings page
New "Maintenance Buckets" section: create a bucket, add a pool item by title (creates the task and assigns it in one step), remove an item, delete a bucket (unbuckets its tasks rather than deleting them). New read-only Projects and Labels sections (name + color swatch) -- both are simple enough that read-only is the right call on web, per user direction, rather than duplicating the Android popup's editing UX. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EZ7ikw2ukGJFTHE3bJS7zL
Diffstat (limited to 'internal/handlers/buckets_web_test.go')
-rw-r--r--internal/handlers/buckets_web_test.go193
1 files changed, 193 insertions, 0 deletions
diff --git a/internal/handlers/buckets_web_test.go b/internal/handlers/buckets_web_test.go
new file mode 100644
index 0000000..9e09ca0
--- /dev/null
+++ b/internal/handlers/buckets_web_test.go
@@ -0,0 +1,193 @@
+package handlers
+
+import (
+ "net/http"
+ "net/http/httptest"
+ "strings"
+ "testing"
+
+ "task-dashboard/internal/models"
+ "task-dashboard/internal/store"
+)
+
+func TestHandleBucketsCreate_Web_CreatesBucket(t *testing.T) {
+ h, cleanup := setupTestHandler(t)
+ defer cleanup()
+
+ req := httptest.NewRequest("POST", "/settings/buckets", strings.NewReader("name=Gutters&cycle_days=30&pick_n=2"))
+ req.Header.Set("Content-Type", "application/x-www-form-urlencoded")
+ w := httptest.NewRecorder()
+ h.HandleBucketsCreate(w, req)
+
+ if w.Code != http.StatusOK {
+ t.Fatalf("status = %d, want 200, body=%s", w.Code, w.Body.String())
+ }
+ buckets, err := h.store.GetBuckets()
+ if err != nil {
+ t.Fatal(err)
+ }
+ if len(buckets) != 1 || buckets[0].Name != "Gutters" {
+ t.Errorf("buckets = %+v", buckets)
+ }
+}
+
+func TestHandleBucketsCreate_Web_InvalidPickN_Returns400(t *testing.T) {
+ h, cleanup := setupTestHandler(t)
+ defer cleanup()
+
+ req := httptest.NewRequest("POST", "/settings/buckets", strings.NewReader("name=Gutters&cycle_days=30&pick_n=0"))
+ req.Header.Set("Content-Type", "application/x-www-form-urlencoded")
+ w := httptest.NewRecorder()
+ h.HandleBucketsCreate(w, req)
+
+ if w.Code != http.StatusBadRequest {
+ t.Fatalf("status = %d, want 400", w.Code)
+ }
+}
+
+func TestHandleBucketItemAdd_Web_CreatesAndAssignsTask(t *testing.T) {
+ h, cleanup := setupTestHandler(t)
+ defer cleanup()
+ bucket, err := h.store.CreateBucket("Gutters", 30, 2)
+ if err != nil {
+ t.Fatal(err)
+ }
+
+ req := withURLParam(httptest.NewRequest("POST", "/settings/buckets/"+bucket.ID+"/items", strings.NewReader("title=Clean+gutters")), "id", bucket.ID)
+ req.Header.Set("Content-Type", "application/x-www-form-urlencoded")
+ w := httptest.NewRecorder()
+ h.HandleBucketItemAdd(w, req)
+
+ if w.Code != http.StatusOK {
+ t.Fatalf("status = %d, want 200, body=%s", w.Code, w.Body.String())
+ }
+ items, err := h.store.GetBucketItems(bucket.ID)
+ if err != nil {
+ t.Fatal(err)
+ }
+ if len(items) != 1 || items[0].Content != "Clean gutters" || items[0].BucketState != "dormant" {
+ t.Errorf("items = %+v", items)
+ }
+}
+
+func TestHandleBucketItemAdd_Web_EmptyTitle_Returns400(t *testing.T) {
+ h, cleanup := setupTestHandler(t)
+ defer cleanup()
+ bucket, err := h.store.CreateBucket("Gutters", 30, 2)
+ if err != nil {
+ t.Fatal(err)
+ }
+
+ req := withURLParam(httptest.NewRequest("POST", "/settings/buckets/"+bucket.ID+"/items", strings.NewReader("title=")), "id", bucket.ID)
+ req.Header.Set("Content-Type", "application/x-www-form-urlencoded")
+ w := httptest.NewRecorder()
+ h.HandleBucketItemAdd(w, req)
+
+ if w.Code != http.StatusBadRequest {
+ t.Fatalf("status = %d, want 400", w.Code)
+ }
+}
+
+func TestHandleBucketItemRemove_Web_RemovesMembership(t *testing.T) {
+ h, cleanup := setupTestHandler(t)
+ defer cleanup()
+ bucket, err := h.store.CreateBucket("Gutters", 30, 2)
+ if err != nil {
+ t.Fatal(err)
+ }
+ if err := h.store.CreateNativeTask(models.Task{ID: "task-1", Content: "Clean gutters", Priority: 1}); err != nil {
+ t.Fatal(err)
+ }
+ if err := h.store.AddBucketItem(bucket.ID, "task-1"); err != nil {
+ t.Fatal(err)
+ }
+
+ req := httptest.NewRequest("POST", "/settings/buckets/items/remove", strings.NewReader("task_id=task-1"))
+ req.Header.Set("Content-Type", "application/x-www-form-urlencoded")
+ w := httptest.NewRecorder()
+ h.HandleBucketItemRemove(w, req)
+
+ if w.Code != http.StatusOK {
+ t.Fatalf("status = %d, want 200, body=%s", w.Code, w.Body.String())
+ }
+ task, err := h.store.GetNativeTaskByID("task-1")
+ if err != nil {
+ t.Fatal(err)
+ }
+ if task.BucketID != "" {
+ t.Errorf("task.BucketID = %q, want empty", task.BucketID)
+ }
+}
+
+func TestHandleBucketDelete_Web_RemovesBucket(t *testing.T) {
+ h, cleanup := setupTestHandler(t)
+ defer cleanup()
+ bucket, err := h.store.CreateBucket("Gutters", 30, 2)
+ if err != nil {
+ t.Fatal(err)
+ }
+
+ req := withURLParam(httptest.NewRequest("DELETE", "/settings/buckets/"+bucket.ID, nil), "id", bucket.ID)
+ w := httptest.NewRecorder()
+ h.HandleBucketDelete(w, req)
+
+ if w.Code != http.StatusOK {
+ t.Fatalf("status = %d, want 200, body=%s", w.Code, w.Body.String())
+ }
+ buckets, err := h.store.GetBuckets()
+ if err != nil {
+ t.Fatal(err)
+ }
+ if len(buckets) != 0 {
+ t.Errorf("buckets = %+v, want none", buckets)
+ }
+}
+
+func TestHandleSettingsPage_IncludesBucketsProjectsLabels(t *testing.T) {
+ h, cleanup := setupTestHandler(t)
+ defer cleanup()
+ if _, err := h.store.CreateBucket("Gutters", 30, 1); err != nil {
+ t.Fatal(err)
+ }
+ if _, err := h.store.CreateProject("Home", "#3B82F6"); err != nil {
+ t.Fatal(err)
+ }
+ if err := h.store.SetLabelColor("chore", "#F59E0B"); err != nil {
+ t.Fatal(err)
+ }
+
+ req := httptest.NewRequest("GET", "/settings", nil)
+ w := httptest.NewRecorder()
+ h.HandleSettingsPage(w, req)
+
+ if w.Code != http.StatusOK {
+ t.Fatalf("status = %d, want 200, body=%s", w.Code, w.Body.String())
+ }
+
+ mock := h.renderer.(*MockRenderer)
+ lastCall := mock.Calls[len(mock.Calls)-1]
+ data, ok := lastCall.Data.(struct {
+ Configs map[string][]models.SourceConfig
+ Sources []string
+ Toggles []models.FeatureToggle
+ SyncLog []store.SyncLogEntry
+ Agents []models.Agent
+ Buckets []models.BucketSummary
+ Projects []models.Project
+ Labels []models.LabelColor
+ CSRFToken string
+ WebAuthnEnabled bool
+ })
+ if !ok {
+ t.Fatalf("unexpected data type %T", lastCall.Data)
+ }
+ if len(data.Buckets) != 1 || data.Buckets[0].Bucket.Name != "Gutters" {
+ t.Errorf("Buckets = %+v", data.Buckets)
+ }
+ if len(data.Projects) != 1 || data.Projects[0].Name != "Home" {
+ t.Errorf("Projects = %+v", data.Projects)
+ }
+ if len(data.Labels) != 1 || data.Labels[0].Name != "chore" {
+ t.Errorf("Labels = %+v", data.Labels)
+ }
+}