summaryrefslogtreecommitdiff
path: root/internal/api/stories_test.go
blob: b346af56d5fde0f43ffc5cbddd39a974bc9b03bf (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
package api

import (
	"bytes"
	"encoding/json"
	"net/http"
	"net/http/httptest"
	"testing"
	"time"

	"github.com/thepeterstone/claudomator/internal/story"
	"github.com/thepeterstone/claudomator/internal/task"
)

func TestServer_CreateStory_AndGetStory(t *testing.T) {
	srv, _ := testServer(t)

	body, _ := json.Marshal(map[string]any{
		"name":                "Add login page",
		"status":              "DISCOVERY",
		"epic_id":             "epic-1",
		"acceptance_criteria": []string{"User can log in"},
	})
	req := httptest.NewRequest("POST", "/api/stories", bytes.NewReader(body))
	w := httptest.NewRecorder()
	srv.Handler().ServeHTTP(w, req)
	if w.Code != http.StatusCreated {
		t.Fatalf("create: expected 201, got %d: %s", w.Code, w.Body.String())
	}
	var created story.Story
	if err := json.Unmarshal(w.Body.Bytes(), &created); err != nil {
		t.Fatalf("decode create response: %v", err)
	}
	if created.ID == "" {
		t.Fatal("expected server-assigned ID")
	}

	req = httptest.NewRequest("GET", "/api/stories/"+created.ID, nil)
	w = httptest.NewRecorder()
	srv.Handler().ServeHTTP(w, req)
	if w.Code != http.StatusOK {
		t.Fatalf("get: expected 200, got %d: %s", w.Code, w.Body.String())
	}
	var got story.Story
	if err := json.Unmarshal(w.Body.Bytes(), &got); err != nil {
		t.Fatalf("decode get response: %v", err)
	}
	if got.Name != "Add login page" {
		t.Errorf("Name: want %q, got %q", "Add login page", got.Name)
	}
	if got.EpicID != "epic-1" {
		t.Errorf("EpicID: want epic-1, got %q", got.EpicID)
	}
	if len(got.AcceptanceCriteria) != 1 || got.AcceptanceCriteria[0] != "User can log in" {
		t.Errorf("AcceptanceCriteria: want [User can log in], got %+v", got.AcceptanceCriteria)
	}
}

func TestServer_CreateStory_MissingName_Returns400(t *testing.T) {
	srv, _ := testServer(t)
	req := httptest.NewRequest("POST", "/api/stories", bytes.NewReader([]byte(`{}`)))
	w := httptest.NewRecorder()
	srv.Handler().ServeHTTP(w, req)
	if w.Code != http.StatusBadRequest {
		t.Fatalf("expected 400, got %d: %s", w.Code, w.Body.String())
	}
}

func TestServer_GetStory_NotFound(t *testing.T) {
	srv, _ := testServer(t)
	req := httptest.NewRequest("GET", "/api/stories/does-not-exist", nil)
	w := httptest.NewRecorder()
	srv.Handler().ServeHTTP(w, req)
	if w.Code != http.StatusNotFound {
		t.Fatalf("expected 404, got %d: %s", w.Code, w.Body.String())
	}
}

func TestServer_ListStories_FiltersByStatusAndEpic(t *testing.T) {
	srv, store := testServer(t)
	for _, st := range []*story.Story{
		{ID: "s1", EpicID: "epic-a", Name: "one", Status: "DISCOVERY"},
		{ID: "s2", EpicID: "epic-a", Name: "two", Status: "IN_PROGRESS"},
		{ID: "s3", EpicID: "epic-b", Name: "three", Status: "DISCOVERY"},
	} {
		if err := store.CreateStory(st); err != nil {
			t.Fatal(err)
		}
	}

	req := httptest.NewRequest("GET", "/api/stories?epic_id=epic-a&status=DISCOVERY", nil)
	w := httptest.NewRecorder()
	srv.Handler().ServeHTTP(w, req)
	if w.Code != http.StatusOK {
		t.Fatalf("expected 200, got %d: %s", w.Code, w.Body.String())
	}
	var got []story.Story
	if err := json.Unmarshal(w.Body.Bytes(), &got); err != nil {
		t.Fatalf("decode: %v", err)
	}
	if len(got) != 1 || got[0].ID != "s1" {
		t.Fatalf("want exactly [s1], got %+v", got)
	}
}

func TestServer_UpdateStory_UnvalidatedStatusPassthrough(t *testing.T) {
	srv, store := testServer(t)
	if err := store.CreateStory(&story.Story{ID: "s1", Name: "original", Status: "DISCOVERY"}); err != nil {
		t.Fatal(err)
	}

	// A nonsensical status jump must still be accepted — this phase performs
	// no status-machine validation on stories.
	body, _ := json.Marshal(map[string]any{
		"name":         "updated",
		"status":       "DONE",
		"root_task_id": "task-x",
	})
	req := httptest.NewRequest("PUT", "/api/stories/s1", bytes.NewReader(body))
	w := httptest.NewRecorder()
	srv.Handler().ServeHTTP(w, req)
	if w.Code != http.StatusOK {
		t.Fatalf("expected 200, got %d: %s", w.Code, w.Body.String())
	}
	var got story.Story
	if err := json.Unmarshal(w.Body.Bytes(), &got); err != nil {
		t.Fatalf("decode: %v", err)
	}
	if got.Status != "DONE" {
		t.Errorf("Status: want DONE (unvalidated passthrough), got %q", got.Status)
	}
	if got.RootTaskID != "task-x" {
		t.Errorf("RootTaskID: want task-x, got %q", got.RootTaskID)
	}
	if got.ID != "s1" {
		t.Errorf("ID must not change via body: got %q", got.ID)
	}
}

func TestServer_UpdateStory_NotFound(t *testing.T) {
	srv, _ := testServer(t)
	req := httptest.NewRequest("PUT", "/api/stories/does-not-exist", bytes.NewReader([]byte(`{"name":"x"}`)))
	w := httptest.NewRecorder()
	srv.Handler().ServeHTTP(w, req)
	if w.Code != http.StatusNotFound {
		t.Fatalf("expected 404, got %d: %s", w.Code, w.Body.String())
	}
}

func makeTreeTestTask(id, parentID string, dependsOn []string) *task.Task {
	now := time.Now().UTC()
	if dependsOn == nil {
		dependsOn = []string{}
	}
	return &task.Task{
		ID:           id,
		Name:         "Task " + id,
		Agent:        task.AgentConfig{Type: "claude", Instructions: "x"},
		Priority:     task.PriorityNormal,
		Retry:        task.RetryConfig{MaxAttempts: 1, Backoff: "linear"},
		Tags:         []string{},
		DependsOn:    dependsOn,
		ParentTaskID: parentID,
		State:        task.StatePending,
		CreatedAt:    now,
		UpdatedAt:    now,
	}
}

// TestServer_StoryTaskTree_WalksParentAndDependsOnEdges constructs a small
// task tree by hand: a root task, a parent_task_id child of the root, and a
// separate task (not a parent_task_id child of anything) whose
// depends_on_json points at the root. Confirms the task-tree endpoint
// discovers all three via the combination of ListSubtasks (parent_task_id)
// and ListDependents (depends_on_json) traversal.
func TestServer_StoryTaskTree_WalksParentAndDependsOnEdges(t *testing.T) {
	srv, store := testServer(t)

	root := makeTreeTestTask("tt-root", "", nil)
	child := makeTreeTestTask("tt-child", "tt-root", nil)
	sibling := makeTreeTestTask("tt-sibling", "", []string{"tt-root"})
	for _, tk := range []*task.Task{root, child, sibling} {
		if err := store.CreateTask(tk); err != nil {
			t.Fatalf("CreateTask(%s): %v", tk.ID, err)
		}
	}

	if err := store.CreateStory(&story.Story{ID: "story-1", Name: "story", Status: "IN_PROGRESS", RootTaskID: "tt-root"}); err != nil {
		t.Fatal(err)
	}

	req := httptest.NewRequest("GET", "/api/stories/story-1/task-tree", nil)
	w := httptest.NewRecorder()
	srv.Handler().ServeHTTP(w, req)
	if w.Code != http.StatusOK {
		t.Fatalf("expected 200, got %d: %s", w.Code, w.Body.String())
	}

	var got taskTreeResponse
	if err := json.Unmarshal(w.Body.Bytes(), &got); err != nil {
		t.Fatalf("decode: %v", err)
	}
	if got.StoryID != "story-1" {
		t.Errorf("StoryID: want story-1, got %q", got.StoryID)
	}
	if got.RootTaskID != "tt-root" {
		t.Errorf("RootTaskID: want tt-root, got %q", got.RootTaskID)
	}
	if len(got.Nodes) != 3 {
		t.Fatalf("want 3 nodes, got %d: %+v", len(got.Nodes), got.Nodes)
	}

	byID := map[string]taskTreeNode{}
	for _, n := range got.Nodes {
		byID[n.ID] = n
	}
	if _, ok := byID["tt-root"]; !ok {
		t.Error("missing tt-root node")
	}
	childNode, ok := byID["tt-child"]
	if !ok {
		t.Fatal("missing tt-child node")
	}
	if childNode.ParentTaskID != "tt-root" {
		t.Errorf("tt-child.ParentTaskID: want tt-root, got %q", childNode.ParentTaskID)
	}
	siblingNode, ok := byID["tt-sibling"]
	if !ok {
		t.Fatal("missing tt-sibling node")
	}
	if len(siblingNode.DependsOn) != 1 || siblingNode.DependsOn[0] != "tt-root" {
		t.Errorf("tt-sibling.DependsOn: want [tt-root], got %+v", siblingNode.DependsOn)
	}
	for _, n := range got.Nodes {
		if n.State == "" {
			t.Errorf("node %s: expected non-empty state", n.ID)
		}
		if n.AgentType != "claude" {
			t.Errorf("node %s: AgentType = %q, want claude", n.ID, n.AgentType)
		}
	}
}

// TestServer_StoryTaskTree_EmptyWhenNoRootTask confirms an unset
// root_task_id returns an empty node list, not an error.
func TestServer_StoryTaskTree_EmptyWhenNoRootTask(t *testing.T) {
	srv, store := testServer(t)
	if err := store.CreateStory(&story.Story{ID: "story-empty", Name: "story", Status: "DISCOVERY"}); err != nil {
		t.Fatal(err)
	}

	req := httptest.NewRequest("GET", "/api/stories/story-empty/task-tree", nil)
	w := httptest.NewRecorder()
	srv.Handler().ServeHTTP(w, req)
	if w.Code != http.StatusOK {
		t.Fatalf("expected 200, got %d: %s", w.Code, w.Body.String())
	}
	var got taskTreeResponse
	if err := json.Unmarshal(w.Body.Bytes(), &got); err != nil {
		t.Fatalf("decode: %v", err)
	}
	if got.RootTaskID != "" {
		t.Errorf("RootTaskID: want empty, got %q", got.RootTaskID)
	}
	if len(got.Nodes) != 0 {
		t.Fatalf("want empty node list, got %+v", got.Nodes)
	}
}

func TestServer_StoryTaskTree_UnknownStory_Returns404(t *testing.T) {
	srv, _ := testServer(t)
	req := httptest.NewRequest("GET", "/api/stories/does-not-exist/task-tree", nil)
	w := httptest.NewRecorder()
	srv.Handler().ServeHTTP(w, req)
	if w.Code != http.StatusNotFound {
		t.Fatalf("expected 404, got %d: %s", w.Code, w.Body.String())
	}
}