summaryrefslogtreecommitdiff
path: root/internal/api/server_test.go
blob: 2325b0bdf7d0a6e209357cda2ca43b5f90a1de10 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
package api

import (
	"bytes"
	"encoding/json"
	"fmt"
	"log/slog"
	"net/http"
	"net/http/httptest"
	"os"
	"path/filepath"
	"testing"

	"context"

	"github.com/thepeterstone/claudomator/internal/executor"
	"github.com/thepeterstone/claudomator/internal/storage"
	"github.com/thepeterstone/claudomator/internal/task"
)

func testServer(t *testing.T) (*Server, *storage.DB) {
	t.Helper()
	dbPath := filepath.Join(t.TempDir(), "test.db")
	store, err := storage.Open(dbPath)
	if err != nil {
		t.Fatal(err)
	}
	t.Cleanup(func() { store.Close() })

	logger := slog.New(slog.NewTextHandler(os.Stderr, &slog.HandlerOptions{Level: slog.LevelError}))
	runner := &mockRunner{}
	pool := executor.NewPool(2, runner, store, logger)
	srv := NewServer(store, pool, logger, "claude")
	return srv, store
}

type mockRunner struct{}

func (m *mockRunner) Run(_ context.Context, _ *task.Task, _ *storage.Execution) error {
	return nil
}

func TestHealthEndpoint(t *testing.T) {
	srv, _ := testServer(t)
	req := httptest.NewRequest("GET", "/api/health", nil)
	w := httptest.NewRecorder()

	srv.Handler().ServeHTTP(w, req)

	if w.Code != http.StatusOK {
		t.Errorf("status: want 200, got %d", w.Code)
	}
	var body map[string]string
	json.NewDecoder(w.Body).Decode(&body)
	if body["status"] != "ok" {
		t.Errorf("want status=ok, got %v", body)
	}
}

func TestCreateTask_Success(t *testing.T) {
	srv, _ := testServer(t)

	payload := `{
		"name": "API Task",
		"description": "Created via API",
		"claude": {
			"instructions": "do the thing",
			"model": "sonnet"
		},
		"timeout": "5m",
		"tags": ["api"]
	}`
	req := httptest.NewRequest("POST", "/api/tasks", bytes.NewBufferString(payload))
	req.Header.Set("Content-Type", "application/json")
	w := httptest.NewRecorder()

	srv.Handler().ServeHTTP(w, req)

	if w.Code != http.StatusCreated {
		t.Fatalf("status: want 201, got %d; body: %s", w.Code, w.Body.String())
	}

	var created task.Task
	json.NewDecoder(w.Body).Decode(&created)
	if created.Name != "API Task" {
		t.Errorf("name: want 'API Task', got %q", created.Name)
	}
	if created.ID == "" {
		t.Error("expected auto-generated ID")
	}
}

func TestCreateTask_InvalidJSON(t *testing.T) {
	srv, _ := testServer(t)

	req := httptest.NewRequest("POST", "/api/tasks", bytes.NewBufferString("{bad json"))
	w := httptest.NewRecorder()
	srv.Handler().ServeHTTP(w, req)

	if w.Code != http.StatusBadRequest {
		t.Errorf("status: want 400, got %d", w.Code)
	}
}

func TestCreateTask_ValidationFailure(t *testing.T) {
	srv, _ := testServer(t)

	payload := `{"name": "", "claude": {"instructions": ""}}`
	req := httptest.NewRequest("POST", "/api/tasks", bytes.NewBufferString(payload))
	w := httptest.NewRecorder()
	srv.Handler().ServeHTTP(w, req)

	if w.Code != http.StatusBadRequest {
		t.Errorf("status: want 400, got %d", w.Code)
	}
}

func TestListTasks_Empty(t *testing.T) {
	srv, _ := testServer(t)

	req := httptest.NewRequest("GET", "/api/tasks", nil)
	w := httptest.NewRecorder()
	srv.Handler().ServeHTTP(w, req)

	if w.Code != http.StatusOK {
		t.Errorf("status: want 200, got %d", w.Code)
	}

	var tasks []task.Task
	json.NewDecoder(w.Body).Decode(&tasks)
	if len(tasks) != 0 {
		t.Errorf("want 0 tasks, got %d", len(tasks))
	}
}

func TestGetTask_NotFound(t *testing.T) {
	srv, _ := testServer(t)

	req := httptest.NewRequest("GET", "/api/tasks/nonexistent", nil)
	w := httptest.NewRecorder()
	srv.Handler().ServeHTTP(w, req)

	if w.Code != http.StatusNotFound {
		t.Errorf("status: want 404, got %d", w.Code)
	}
}

func TestListTasks_WithTasks(t *testing.T) {
	srv, store := testServer(t)

	// Create tasks directly in store.
	for i := 0; i < 3; i++ {
		tk := &task.Task{
			ID: fmt.Sprintf("lt-%d", i), Name: fmt.Sprintf("T%d", i),
			Claude: task.ClaudeConfig{Instructions: "x"}, Priority: task.PriorityNormal,
			Retry: task.RetryConfig{MaxAttempts: 1, Backoff: "linear"},
			Tags: []string{}, DependsOn: []string{}, State: task.StatePending,
		}
		store.CreateTask(tk)
	}

	req := httptest.NewRequest("GET", "/api/tasks", nil)
	w := httptest.NewRecorder()
	srv.Handler().ServeHTTP(w, req)

	var tasks []task.Task
	json.NewDecoder(w.Body).Decode(&tasks)
	if len(tasks) != 3 {
		t.Errorf("want 3 tasks, got %d", len(tasks))
	}
}

func createTaskWithState(t *testing.T, store *storage.DB, id string, state task.State) *task.Task {
	t.Helper()
	tk := &task.Task{
		ID:    id,
		Name:  "test-task-" + id,
		Claude: task.ClaudeConfig{Instructions: "do something"},
		Priority: task.PriorityNormal,
		Retry: task.RetryConfig{MaxAttempts: 1, Backoff: "linear"},
		Tags: []string{}, DependsOn: []string{}, State: task.StatePending,
	}
	if err := store.CreateTask(tk); err != nil {
		t.Fatalf("createTaskWithState: CreateTask: %v", err)
	}
	if state != task.StatePending {
		if err := store.UpdateTaskState(id, state); err != nil {
			t.Fatalf("createTaskWithState: UpdateTaskState(%s): %v", state, err)
		}
	}
	tk.State = state
	return tk
}

func TestRunTask_PendingTask_Returns202(t *testing.T) {
	srv, store := testServer(t)
	createTaskWithState(t, store, "run-pending", task.StatePending)

	req := httptest.NewRequest("POST", "/api/tasks/run-pending/run", nil)
	w := httptest.NewRecorder()
	srv.Handler().ServeHTTP(w, req)

	if w.Code != http.StatusAccepted {
		t.Errorf("status: want 202, got %d; body: %s", w.Code, w.Body.String())
	}
}

func TestRunTask_FailedTask_Returns202(t *testing.T) {
	srv, store := testServer(t)
	createTaskWithState(t, store, "run-failed", task.StateFailed)

	req := httptest.NewRequest("POST", "/api/tasks/run-failed/run", nil)
	w := httptest.NewRecorder()
	srv.Handler().ServeHTTP(w, req)

	if w.Code != http.StatusAccepted {
		t.Errorf("status: want 202, got %d; body: %s", w.Code, w.Body.String())
	}
}

func TestRunTask_TimedOutTask_Returns202(t *testing.T) {
	srv, store := testServer(t)
	// TIMED_OUT → QUEUED is a valid transition (retry path).
	// We need to get the task into TIMED_OUT state; storage allows direct state writes.
	createTaskWithState(t, store, "run-timedout", task.StateTimedOut)

	req := httptest.NewRequest("POST", "/api/tasks/run-timedout/run", nil)
	w := httptest.NewRecorder()
	srv.Handler().ServeHTTP(w, req)

	if w.Code != http.StatusAccepted {
		t.Errorf("status: want 202, got %d; body: %s", w.Code, w.Body.String())
	}
}

func TestRunTask_CompletedTask_Returns409(t *testing.T) {
	srv, store := testServer(t)
	createTaskWithState(t, store, "run-completed", task.StateCompleted)

	req := httptest.NewRequest("POST", "/api/tasks/run-completed/run", nil)
	w := httptest.NewRecorder()
	srv.Handler().ServeHTTP(w, req)

	if w.Code != http.StatusConflict {
		t.Errorf("status: want 409, got %d; body: %s", w.Code, w.Body.String())
	}
	var body map[string]string
	json.NewDecoder(w.Body).Decode(&body)
	wantMsg := "task cannot be queued from state COMPLETED"
	if body["error"] != wantMsg {
		t.Errorf("error body: want %q, got %q", wantMsg, body["error"])
	}
}

func TestAcceptTask_ReadyTask_Returns200(t *testing.T) {
	srv, store := testServer(t)
	createTaskWithState(t, store, "accept-ready", task.StateReady)

	req := httptest.NewRequest("POST", "/api/tasks/accept-ready/accept", nil)
	w := httptest.NewRecorder()
	srv.Handler().ServeHTTP(w, req)

	if w.Code != http.StatusOK {
		t.Errorf("status: want 200, got %d; body: %s", w.Code, w.Body.String())
	}

	got, _ := store.GetTask("accept-ready")
	if got.State != task.StateCompleted {
		t.Errorf("task state: want COMPLETED, got %v", got.State)
	}
}

func TestAcceptTask_NonReadyTask_Returns409(t *testing.T) {
	srv, store := testServer(t)
	createTaskWithState(t, store, "accept-pending", task.StatePending)

	req := httptest.NewRequest("POST", "/api/tasks/accept-pending/accept", nil)
	w := httptest.NewRecorder()
	srv.Handler().ServeHTTP(w, req)

	if w.Code != http.StatusConflict {
		t.Errorf("status: want 409, got %d; body: %s", w.Code, w.Body.String())
	}
}

func TestRejectTask_ReadyTask_Returns200(t *testing.T) {
	srv, store := testServer(t)
	createTaskWithState(t, store, "reject-ready", task.StateReady)

	body := bytes.NewBufferString(`{"comment": "needs more detail"}`)
	req := httptest.NewRequest("POST", "/api/tasks/reject-ready/reject", body)
	req.Header.Set("Content-Type", "application/json")
	w := httptest.NewRecorder()
	srv.Handler().ServeHTTP(w, req)

	if w.Code != http.StatusOK {
		t.Errorf("status: want 200, got %d; body: %s", w.Code, w.Body.String())
	}

	got, _ := store.GetTask("reject-ready")
	if got.State != task.StatePending {
		t.Errorf("task state: want PENDING, got %v", got.State)
	}
	if got.RejectionComment != "needs more detail" {
		t.Errorf("rejection_comment: want 'needs more detail', got %q", got.RejectionComment)
	}
}

func TestRejectTask_NonReadyTask_Returns409(t *testing.T) {
	srv, store := testServer(t)
	createTaskWithState(t, store, "reject-pending", task.StatePending)

	body := bytes.NewBufferString(`{"comment": "comment"}`)
	req := httptest.NewRequest("POST", "/api/tasks/reject-pending/reject", body)
	req.Header.Set("Content-Type", "application/json")
	w := httptest.NewRecorder()
	srv.Handler().ServeHTTP(w, req)

	if w.Code != http.StatusConflict {
		t.Errorf("status: want 409, got %d; body: %s", w.Code, w.Body.String())
	}
}

func TestCORS_Headers(t *testing.T) {
	srv, _ := testServer(t)

	req := httptest.NewRequest("OPTIONS", "/api/tasks", nil)
	w := httptest.NewRecorder()
	srv.Handler().ServeHTTP(w, req)

	if w.Header().Get("Access-Control-Allow-Origin") != "*" {
		t.Error("missing CORS origin header")
	}
	if w.Code != http.StatusOK {
		t.Errorf("OPTIONS status: want 200, got %d", w.Code)
	}
}

func TestAnswerQuestion_NoTask_Returns404(t *testing.T) {
	srv, _ := testServer(t)

	req := httptest.NewRequest("POST", "/api/tasks/nonexistent/answer", bytes.NewBufferString(`{"answer":"blue"}`))
	req.Header.Set("Content-Type", "application/json")
	w := httptest.NewRecorder()

	srv.Handler().ServeHTTP(w, req)

	if w.Code != http.StatusNotFound {
		t.Errorf("status: want 404, got %d; body: %s", w.Code, w.Body.String())
	}
}

func TestAnswerQuestion_TaskNotBlocked_Returns409(t *testing.T) {
	srv, store := testServer(t)
	createTaskWithState(t, store, "answer-task-1", task.StatePending)

	req := httptest.NewRequest("POST", "/api/tasks/answer-task-1/answer", bytes.NewBufferString(`{"answer":"blue"}`))
	req.Header.Set("Content-Type", "application/json")
	w := httptest.NewRecorder()

	srv.Handler().ServeHTTP(w, req)

	if w.Code != http.StatusConflict {
		t.Errorf("status: want 409, got %d; body: %s", w.Code, w.Body.String())
	}
}

func TestAnswerQuestion_MissingAnswer_Returns400(t *testing.T) {
	srv, store := testServer(t)
	createTaskWithState(t, store, "answer-task-2", task.StateBlocked)

	req := httptest.NewRequest("POST", "/api/tasks/answer-task-2/answer", bytes.NewBufferString(`{}`))
	req.Header.Set("Content-Type", "application/json")
	w := httptest.NewRecorder()

	srv.Handler().ServeHTTP(w, req)

	if w.Code != http.StatusBadRequest {
		t.Errorf("status: want 400, got %d; body: %s", w.Code, w.Body.String())
	}
}

func TestAnswerQuestion_BlockedTask_QueuesResume(t *testing.T) {
	srv, store := testServer(t)
	createTaskWithState(t, store, "answer-task-3", task.StateBlocked)

	// Create an execution with a session ID, as the runner would have.
	exec := &storage.Execution{
		ID:        "exec-blocked-1",
		TaskID:    "answer-task-3",
		SessionID: "550e8400-e29b-41d4-a716-446655440001",
		Status:    "BLOCKED",
	}
	if err := store.CreateExecution(exec); err != nil {
		t.Fatalf("create execution: %v", err)
	}

	req := httptest.NewRequest("POST", "/api/tasks/answer-task-3/answer", bytes.NewBufferString(`{"answer":"main"}`))
	req.Header.Set("Content-Type", "application/json")
	w := httptest.NewRecorder()

	srv.Handler().ServeHTTP(w, req)

	if w.Code != http.StatusOK {
		t.Errorf("status: want 200, got %d; body: %s", w.Code, w.Body.String())
	}

	// Task should now be QUEUED (or RUNNING since the mock runner is instant).
	got, _ := store.GetTask("answer-task-3")
	if got.State != task.StateQueued && got.State != task.StateRunning && got.State != task.StateReady {
		t.Errorf("task state: want QUEUED/RUNNING/READY after answer, got %v", got.State)
	}
}

func TestHandleStartNextTask_Success(t *testing.T) {
	dir := t.TempDir()
	script := filepath.Join(dir, "start-next-task")
	if err := os.WriteFile(script, []byte("#!/bin/sh\necho 'claudomator start abc-123'\n"), 0755); err != nil {
		t.Fatal(err)
	}

	srv, _ := testServer(t)
	srv.startNextTaskScript = script

	req := httptest.NewRequest("POST", "/api/scripts/start-next-task", nil)
	w := httptest.NewRecorder()
	srv.Handler().ServeHTTP(w, req)

	if w.Code != http.StatusOK {
		t.Fatalf("want 200, got %d; body: %s", w.Code, w.Body.String())
	}
	var body map[string]interface{}
	json.NewDecoder(w.Body).Decode(&body)
	if body["output"] != "claudomator start abc-123\n" {
		t.Errorf("unexpected output: %v", body["output"])
	}
	if body["exit_code"] != float64(0) {
		t.Errorf("unexpected exit_code: %v", body["exit_code"])
	}
}

func TestHandleStartNextTask_NoTask(t *testing.T) {
	dir := t.TempDir()
	script := filepath.Join(dir, "start-next-task")
	if err := os.WriteFile(script, []byte("#!/bin/sh\necho 'No task to start.'\n"), 0755); err != nil {
		t.Fatal(err)
	}

	srv, _ := testServer(t)
	srv.startNextTaskScript = script

	req := httptest.NewRequest("POST", "/api/scripts/start-next-task", nil)
	w := httptest.NewRecorder()
	srv.Handler().ServeHTTP(w, req)

	if w.Code != http.StatusOK {
		t.Fatalf("want 200, got %d; body: %s", w.Code, w.Body.String())
	}
	var body map[string]interface{}
	json.NewDecoder(w.Body).Decode(&body)
	if body["output"] != "No task to start.\n" {
		t.Errorf("unexpected output: %v", body["output"])
	}
}

func TestHandleStartNextTask_ScriptNotFound(t *testing.T) {
	srv, _ := testServer(t)
	srv.startNextTaskScript = "/nonexistent/start-next-task"

	req := httptest.NewRequest("POST", "/api/scripts/start-next-task", nil)
	w := httptest.NewRecorder()
	srv.Handler().ServeHTTP(w, req)

	if w.Code != http.StatusInternalServerError {
		t.Errorf("want 500, got %d; body: %s", w.Code, w.Body.String())
	}
}