1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
|
package api
import (
"bytes"
"encoding/json"
"fmt"
"net/http"
"net/http/httptest"
"os"
"path/filepath"
"strings"
"testing"
)
// createFakeClaude writes a shell script to a temp dir that prints output and exits with the
// given code. Returns the script path. Used to mock the claude binary in elaborate tests.
func createFakeClaude(t *testing.T, output string, exitCode int) string {
t.Helper()
dir := t.TempDir()
outputFile := filepath.Join(dir, "output.json")
if err := os.WriteFile(outputFile, []byte(output), 0600); err != nil {
t.Fatal(err)
}
script := filepath.Join(dir, "claude")
content := fmt.Sprintf("#!/bin/sh\ncat %q\nexit %d\n", outputFile, exitCode)
if err := os.WriteFile(script, []byte(content), 0755); err != nil {
t.Fatal(err)
}
return script
}
func TestElaboratePrompt_ContainsWorkDir(t *testing.T) {
prompt := buildElaboratePrompt("/some/custom/path")
if !strings.Contains(prompt, "/some/custom/path") {
t.Error("prompt should contain the provided workDir")
}
if strings.Contains(prompt, "/root/workspace/claudomator") {
t.Error("prompt should not hardcode /root/workspace/claudomator")
}
}
func TestElaboratePrompt_EmptyWorkDir(t *testing.T) {
prompt := buildElaboratePrompt("")
if strings.Contains(prompt, "/root") {
t.Error("prompt should not reference /root when workDir is empty")
}
}
func TestElaborateTask_Success(t *testing.T) {
srv, _ := testServer(t)
// Build fake Claude output: {"result": "<task-json>"}
task := elaboratedTask{
Name: "Run Go tests with race detector",
Description: "Runs the Go test suite with -race flag and checks coverage.",
Agent: elaboratedAgent{
Type: "claude",
Model: "sonnet",
Instructions: "Run go test -race ./... and report results.",
ProjectDir: "",
MaxBudgetUSD: 0.5,
AllowedTools: []string{"Bash"},
},
Timeout: "15m",
Priority: "normal",
Tags: []string{"testing", "ci"},
}
taskJSON, err := json.Marshal(task)
if err != nil {
t.Fatal(err)
}
wrapper := map[string]string{"result": string(taskJSON)}
wrapperJSON, err := json.Marshal(wrapper)
if err != nil {
t.Fatal(err)
}
srv.elaborateCmdPath = createFakeClaude(t, string(wrapperJSON), 0)
body := `{"prompt":"run the Go test suite with race detector and fail if coverage < 80%"}`
req := httptest.NewRequest("POST", "/api/tasks/elaborate", bytes.NewBufferString(body))
req.Header.Set("Content-Type", "application/json")
w := httptest.NewRecorder()
srv.Handler().ServeHTTP(w, req)
if w.Code != http.StatusOK {
t.Fatalf("status: want 200, got %d; body: %s", w.Code, w.Body.String())
}
var result elaboratedTask
if err := json.NewDecoder(w.Body).Decode(&result); err != nil {
t.Fatalf("failed to decode response: %v", err)
}
if result.Name == "" {
t.Error("expected non-empty name")
}
if result.Agent.Instructions == "" {
t.Error("expected non-empty instructions")
}
}
func TestElaborateTask_EmptyPrompt(t *testing.T) {
srv, _ := testServer(t)
body := `{"prompt":""}`
req := httptest.NewRequest("POST", "/api/tasks/elaborate", bytes.NewBufferString(body))
req.Header.Set("Content-Type", "application/json")
w := httptest.NewRecorder()
srv.Handler().ServeHTTP(w, req)
if w.Code != http.StatusBadRequest {
t.Fatalf("status: want 400, got %d; body: %s", w.Code, w.Body.String())
}
var resp map[string]string
json.NewDecoder(w.Body).Decode(&resp)
if resp["error"] == "" {
t.Error("expected error message in response")
}
}
func TestElaborateTask_MarkdownFencedJSON(t *testing.T) {
srv, _ := testServer(t)
// Build a valid task JSON but wrap it in markdown fences as haiku sometimes does.
task := elaboratedTask{
Name: "Test task",
Description: "Does something.",
Agent: elaboratedAgent{
Type: "claude",
Model: "sonnet",
Instructions: "Do the thing.",
MaxBudgetUSD: 0.5,
AllowedTools: []string{"Bash"},
},
Timeout: "15m",
Priority: "normal",
Tags: []string{"test"},
}
taskJSON, _ := json.Marshal(task)
fenced := "```json\n" + string(taskJSON) + "\n```"
wrapper := map[string]string{"result": fenced}
wrapperJSON, _ := json.Marshal(wrapper)
srv.elaborateCmdPath = createFakeClaude(t, string(wrapperJSON), 0)
body := `{"prompt":"do something"}`
req := httptest.NewRequest("POST", "/api/tasks/elaborate", bytes.NewBufferString(body))
req.Header.Set("Content-Type", "application/json")
w := httptest.NewRecorder()
srv.Handler().ServeHTTP(w, req)
if w.Code != http.StatusOK {
t.Fatalf("status: want 200, got %d; body: %s", w.Code, w.Body.String())
}
var result elaboratedTask
if err := json.NewDecoder(w.Body).Decode(&result); err != nil {
t.Fatalf("failed to decode response: %v", err)
}
if result.Name != task.Name {
t.Errorf("name: want %q, got %q", task.Name, result.Name)
}
}
func TestElaborateTask_InvalidJSONFromClaude(t *testing.T) {
srv, _ := testServer(t)
// Fake Claude returns something that is not valid JSON.
srv.elaborateCmdPath = createFakeClaude(t, "not valid json at all", 0)
body := `{"prompt":"do something"}`
req := httptest.NewRequest("POST", "/api/tasks/elaborate", bytes.NewBufferString(body))
req.Header.Set("Content-Type", "application/json")
w := httptest.NewRecorder()
srv.Handler().ServeHTTP(w, req)
if w.Code != http.StatusBadGateway {
t.Fatalf("status: want 502, got %d; body: %s", w.Code, w.Body.String())
}
var resp map[string]string
json.NewDecoder(w.Body).Decode(&resp)
if resp["error"] == "" {
t.Error("expected error message in response")
}
}
func createFakeClaudeCapturingArgs(t *testing.T, output string, exitCode int, argsFile string) string {
t.Helper()
dir := t.TempDir()
outputFile := filepath.Join(dir, "output.json")
if err := os.WriteFile(outputFile, []byte(output), 0600); err != nil {
t.Fatal(err)
}
script := filepath.Join(dir, "claude")
// Use printf to handle arguments safely
content := fmt.Sprintf("#!/bin/sh\nprintf \"%%s\\n\" \"$@\" > %q\ncat %q\nexit %d\n", argsFile, outputFile, exitCode)
if err := os.WriteFile(script, []byte(content), 0755); err != nil {
t.Fatal(err)
}
return script
}
func TestElaborateTask_WithProjectContext(t *testing.T) {
srv, _ := testServer(t)
// Create a temporary workspace with CLAUDE.md and SESSION_STATE.md
workDir := t.TempDir()
claudeContent := "Claude context info"
sessionContent := "Session state info"
if err := os.WriteFile(filepath.Join(workDir, "CLAUDE.md"), []byte(claudeContent), 0600); err != nil {
t.Fatal(err)
}
if err := os.WriteFile(filepath.Join(workDir, "SESSION_STATE.md"), []byte(sessionContent), 0600); err != nil {
t.Fatal(err)
}
// Capture arguments passed to claude
argsFile := filepath.Join(t.TempDir(), "args.txt")
task := elaboratedTask{
Name: "Task with context",
Agent: elaboratedAgent{
Instructions: "Instructions",
},
}
taskJSON, _ := json.Marshal(task)
wrapper := map[string]string{"result": string(taskJSON)}
wrapperJSON, _ := json.Marshal(wrapper)
// Modified createFakeClaude to capture arguments
srv.elaborateCmdPath = createFakeClaudeCapturingArgs(t, string(wrapperJSON), 0, argsFile)
body := fmt.Sprintf(`{"prompt":"do something", "project_dir":"%s"}`, workDir)
req := httptest.NewRequest("POST", "/api/tasks/elaborate", bytes.NewBufferString(body))
req.Header.Set("Content-Type", "application/json")
w := httptest.NewRecorder()
srv.Handler().ServeHTTP(w, req)
if w.Code != http.StatusOK {
t.Fatalf("status: want 200, got %d; body: %s", w.Code, w.Body.String())
}
// Check if captured arguments contain the context
capturedArgs, err := os.ReadFile(argsFile)
if err != nil {
t.Fatal(err)
}
argsStr := string(capturedArgs)
if !strings.Contains(argsStr, claudeContent) {
t.Errorf("expected arguments to contain CLAUDE.md content, got %s", argsStr)
}
if !strings.Contains(argsStr, sessionContent) {
t.Errorf("expected arguments to contain SESSION_STATE.md content, got %s", argsStr)
}
}
|
