summaryrefslogtreecommitdiff
path: root/internal/api/elaborate.go
blob: 5df772e0c737db2b8c8210b47aaf8916cdf0a581 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
package api

import (
	"bytes"
	"context"
	"encoding/json"
	"fmt"
	"net/http"
	"os"
	"os/exec"
	"path/filepath"
	"sort"
	"strings"
	"time"
)

const elaborateTimeout = 30 * time.Second

func buildElaboratePrompt(workDir string) string {
	workDirLine := `    "project_dir":     string  — leave empty unless you have a specific reason to set it,`
	if workDir != "" {
		workDirLine = fmt.Sprintf(`    "project_dir":     string  — use %q for tasks that operate on this codebase, empty string otherwise,`, workDir)
	}
	return `You are a task configuration assistant for Claudomator, an AI task runner that executes tasks by running Claude or Gemini as a subprocess.

Your ONLY job is to convert any user request into a Claudomator task JSON object. You MUST always output valid JSON. Never ask clarifying questions. Never explain. Never refuse. Make reasonable assumptions and produce the JSON.

Output ONLY a valid JSON object matching this schema (no markdown fences, no prose, no explanation):

{
  "name":        string   — short imperative title (≤60 chars),
  "description": string   — 1-2 sentence summary,
  "agent": {
    "type":            "claude" | "gemini",
    "model":           string  — "sonnet" for claude, "gemini-2.5-flash-lite" for gemini,
    "instructions":    string  — detailed, step-by-step instructions for the agent. Must end with a "## Acceptance Criteria" section listing measurable conditions that define success. For coding tasks, include TDD requirements (write failing tests first, then implement),
` + workDirLine + `
    "max_budget_usd":  number  — conservative estimate (0.25–5.00),
    "allowed_tools":   array   — every tool the task genuinely needs. Include "Write" if creating files, "Edit" if modifying files, "Read" if reading files, "Bash" for shell/git/test commands, "Grep"/"Glob" for searching.
  },
  "timeout":  string  — e.g. "15m",
  "priority": string  — "normal" | "high" | "low",
  "tags":     array   — relevant lowercase tags
}`
}

// elaboratedTask mirrors the task creation schema for elaboration responses.
type elaboratedTask struct {
	Name        string          `json:"name"`
	Description string          `json:"description"`
	Agent       elaboratedAgent `json:"agent"`
	Timeout     string          `json:"timeout"`
	Priority    string          `json:"priority"`
	Tags        []string        `json:"tags"`
}

type elaboratedAgent struct {
	Type         string   `json:"type"`
	Model        string   `json:"model"`
	Instructions string   `json:"instructions"`
	ProjectDir   string   `json:"project_dir"`
	MaxBudgetUSD float64  `json:"max_budget_usd"`
	AllowedTools []string `json:"allowed_tools"`
}

// sanitizeElaboratedTask enforces tool completeness and dev practice compliance.
// It modifies t in place, inferring missing tools from instruction keywords and
// appending required sections when they are absent.
func sanitizeElaboratedTask(t *elaboratedTask) {
	lower := strings.ToLower(t.Agent.Instructions)

	// Build current tool set.
	toolSet := make(map[string]bool, len(t.Agent.AllowedTools))
	for _, tool := range t.Agent.AllowedTools {
		toolSet[tool] = true
	}

	// Infer missing tools from instruction keywords.
	type rule struct {
		tool     string
		keywords []string
	}
	rules := []rule{
		{"Write", []string{"create file", "write file", "new file", "write to", "save to", "output to", "generate file", "creates a file", "create a new file"}},
		{"Edit", []string{"edit", "modify", "refactor", "replace", "patch"}},
		{"Read", []string{"read", "inspect", "examine", "look at the file"}},
		{"Bash", []string{"run", "execute", "bash", "shell", "command", "build", "compile", "git", "install", "make"}},
		{"Grep", []string{"search for", "grep", "find in", "locate in"}},
		{"Glob", []string{"find file", "list file", "search file"}},
	}
	for _, r := range rules {
		if toolSet[r.tool] {
			continue
		}
		for _, kw := range r.keywords {
			if strings.Contains(lower, kw) {
				toolSet[r.tool] = true
				break
			}
		}
	}
	// Edit without Read is almost always wrong.
	if toolSet["Edit"] && !toolSet["Read"] {
		toolSet["Read"] = true
	}
	// Rebuild the list only when tools were added.
	if len(toolSet) > len(t.Agent.AllowedTools) {
		tools := make([]string, 0, len(toolSet))
		for tool := range toolSet {
			tools = append(tools, tool)
		}
		sort.Strings(tools)
		t.Agent.AllowedTools = tools
	}

	// Append an acceptance criteria section when none is present.
	if !strings.Contains(lower, "acceptance") &&
		!strings.Contains(lower, "done when") &&
		!strings.Contains(lower, "success criteria") {
		t.Agent.Instructions += "\n\n## Acceptance Criteria\nBefore finishing, verify all stated goals are met, tests pass (if applicable), and no unintended side effects were introduced."
	}

	// Append a TDD reminder for coding tasks that do not already mention tests.
	if (toolSet["Edit"] || toolSet["Write"]) && !strings.Contains(lower, "test") {
		t.Agent.Instructions += "\n\n## Dev Practices\nFollow TDD: write a failing test first, then implement the minimum code to make it pass. Commit all changes before finishing."
	}
}

// claudeJSONResult is the top-level object returned by `claude --output-format json`.
type claudeJSONResult struct {
	Result string `json:"result"`
}

// extractJSON returns the first top-level JSON object found in s, stripping
// surrounding prose or markdown code fences the model may have added.
func extractJSON(s string) string {
	start := strings.Index(s, "{")
	end := strings.LastIndex(s, "}")
	if start == -1 || end == -1 || end < start {
		return s
	}
	return s[start : end+1]
}

func (s *Server) claudeBinaryPath() string {
	if s.elaborateCmdPath != "" {
		return s.elaborateCmdPath
	}
	if s.claudeBinPath != "" {
		return s.claudeBinPath
	}
	return "claude"
}

func readProjectContext(workDir string) string {
	if workDir == "" {
		return ""
	}
	var sb strings.Builder
	for _, filename := range []string{"CLAUDE.md", "SESSION_STATE.md"} {
		path := filepath.Join(workDir, filename)
		if data, err := os.ReadFile(path); err == nil {
			if sb.Len() > 0 {
				sb.WriteString("\n\n")
			}
			sb.WriteString(fmt.Sprintf("--- %s ---\n%s", filename, string(data)))
		}
	}
	return sb.String()
}

func (s *Server) appendRawNarrative(workDir, prompt string) {
	if workDir == "" {
		return
	}
	docsDir := filepath.Join(workDir, "docs")
	if err := os.MkdirAll(docsDir, 0755); err != nil {
		s.logger.Error("elaborate: failed to create docs directory", "error", err, "path", docsDir)
		return
	}
	path := filepath.Join(docsDir, "RAW_NARRATIVE.md")
	f, err := os.OpenFile(path, os.O_APPEND|os.O_CREATE|os.O_WRONLY, 0644)
	if err != nil {
		s.logger.Error("elaborate: failed to open RAW_NARRATIVE.md", "error", err, "path", path)
		return
	}
	defer f.Close()

	entry := fmt.Sprintf("\n--- %s ---\n%s\n", time.Now().Format(time.RFC3339), prompt)
	if _, err := f.WriteString(entry); err != nil {
		s.logger.Error("elaborate: failed to write to RAW_NARRATIVE.md", "error", err, "path", path)
	}
}

func (s *Server) handleElaborateTask(w http.ResponseWriter, r *http.Request) {
	if s.elaborateLimiter != nil && !s.elaborateLimiter.allow(realIP(r)) {
		writeJSON(w, http.StatusTooManyRequests, map[string]string{"error": "rate limit exceeded"})
		return
	}

	var input struct {
		Prompt     string `json:"prompt"`
		ProjectDir string `json:"project_dir"`
	}
	if err := json.NewDecoder(r.Body).Decode(&input); err != nil {
		writeJSON(w, http.StatusBadRequest, map[string]string{"error": "invalid JSON: " + err.Error()})
		return
	}
	if input.Prompt == "" {
		writeJSON(w, http.StatusBadRequest, map[string]string{"error": "prompt is required"})
		return
	}

	workDir := s.workDir
	if input.ProjectDir != "" {
		workDir = input.ProjectDir
	}

	// Append verbatim user input to RAW_NARRATIVE.md only when the user explicitly
	// provided a project_dir — the narrative is per-project human input, not a
	// server-level log.
	if input.ProjectDir != "" {
		go s.appendRawNarrative(workDir, input.Prompt)
	}

	projectContext := readProjectContext(workDir)
	fullPrompt := input.Prompt
	if projectContext != "" {
		fullPrompt = fmt.Sprintf("Project context from %s:\n%s\n\nUser request: %s", workDir, projectContext, input.Prompt)
	}

	ctx, cancel := context.WithTimeout(r.Context(), elaborateTimeout)
	defer cancel()

	cmd := exec.CommandContext(ctx, s.claudeBinaryPath(),
		"-p", fullPrompt,
		"--system-prompt", buildElaboratePrompt(workDir),
		"--output-format", "json",
		"--model", "haiku",
	)


	var stdout, stderr bytes.Buffer
	cmd.Stdout = &stdout
	cmd.Stderr = &stderr

	if err := cmd.Run(); err != nil {
		s.logger.Error("elaborate: claude subprocess failed", "error", err, "stderr", stderr.String())
		writeJSON(w, http.StatusBadGateway, map[string]string{
			"error": fmt.Sprintf("elaboration failed: %v", err),
		})
		return
	}

	// claude --output-format json wraps the text result in {"result": "...", ...}
	var wrapper claudeJSONResult
	if err := json.Unmarshal(stdout.Bytes(), &wrapper); err != nil {
		s.logger.Error("elaborate: failed to parse claude JSON wrapper", "error", err, "stdout", stdout.String())
		writeJSON(w, http.StatusBadGateway, map[string]string{
			"error": "elaboration failed: invalid JSON from claude",
		})
		return
	}

	var result elaboratedTask
	if err := json.Unmarshal([]byte(extractJSON(wrapper.Result)), &result); err != nil {
		s.logger.Error("elaborate: failed to parse elaborated task JSON", "error", err, "result", wrapper.Result)
		writeJSON(w, http.StatusBadGateway, map[string]string{
			"error": "elaboration failed: claude returned invalid task JSON",
		})
		return
	}

	if result.Name == "" || result.Agent.Instructions == "" {
		writeJSON(w, http.StatusBadGateway, map[string]string{
			"error": "elaboration failed: missing required fields in response",
		})
		return
	}

	if result.Agent.Type == "" {
		result.Agent.Type = "claude"
	}

	sanitizeElaboratedTask(&result)

	writeJSON(w, http.StatusOK, result)
}