1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
|
package api
import (
"context"
"encoding/json"
"net/http"
"net/http/httptest"
"testing"
"github.com/modelcontextprotocol/go-sdk/mcp"
"github.com/thepeterstone/claudomator/internal/storage"
"github.com/thepeterstone/claudomator/internal/task"
)
// chatbotClient starts the api server with the given token and returns a
// connected MCP client session pointed at /chatbot/mcp.
func chatbotClient(t *testing.T, srv *Server, token string) *mcp.ClientSession {
t.Helper()
ts := httptest.NewServer(srv.Handler())
t.Cleanup(ts.Close)
client := mcp.NewClient(&mcp.Implementation{Name: "test", Version: "1"}, nil)
cs, err := client.Connect(context.Background(), &mcp.StreamableClientTransport{
Endpoint: ts.URL + "/chatbot/mcp",
HTTPClient: &http.Client{Transport: tokenRT{token: token, base: http.DefaultTransport}},
}, nil)
if err != nil {
t.Fatalf("connect to /chatbot/mcp: %v", err)
}
t.Cleanup(func() { cs.Close() })
return cs
}
func callText(t *testing.T, cs *mcp.ClientSession, name string, args map[string]any) string {
t.Helper()
res, err := cs.CallTool(context.Background(), &mcp.CallToolParams{Name: name, Arguments: args})
if err != nil {
t.Fatalf("CallTool %s transport error: %v", name, err)
}
if res.IsError {
t.Fatalf("CallTool %s returned tool error: %s", name, toolText(res))
}
return toolText(res)
}
func toolText(res *mcp.CallToolResult) string {
if len(res.Content) == 0 {
return ""
}
if tc, ok := res.Content[0].(*mcp.TextContent); ok {
return tc.Text
}
return ""
}
func TestChatbotMCP_RequiresToken(t *testing.T) {
srv, _ := testServer(t)
srv.SetAPIToken("s3cret")
ts := httptest.NewServer(srv.Handler())
defer ts.Close()
client := mcp.NewClient(&mcp.Implementation{Name: "test", Version: "1"}, nil)
_, err := client.Connect(context.Background(), &mcp.StreamableClientTransport{
Endpoint: ts.URL + "/chatbot/mcp",
HTTPClient: &http.Client{Transport: tokenRT{token: "wrong", base: http.DefaultTransport}},
}, nil)
if err == nil {
t.Fatal("expected connect with wrong token to be rejected")
}
}
func TestChatbotMCP_SubmitTask_CreatesAndQueues(t *testing.T) {
srv, store := testServer(t)
srv.SetAPIToken("s3cret")
cs := chatbotClient(t, srv, "s3cret")
out := callText(t, cs, "submit_task", map[string]any{
"instructions": "fix the flaky test in package foo",
"repository_url": "https://github.com/user/repo",
})
var ct compactTask
if err := json.Unmarshal([]byte(out), &ct); err != nil {
t.Fatalf("unmarshal submit_task result %q: %v", out, err)
}
if ct.ID == "" {
t.Fatal("submit_task returned empty task ID")
}
if ct.Name != "fix the flaky test in package foo" {
t.Errorf("name defaulted wrong: %q", ct.Name)
}
if _, err := store.GetTask(ct.ID); err != nil {
t.Fatalf("submitted task not persisted: %v", err)
}
}
func TestChatbotMCP_SubmitTask_RequiresRepo(t *testing.T) {
srv, _ := testServer(t)
srv.SetAPIToken("s3cret")
cs := chatbotClient(t, srv, "s3cret")
res, err := cs.CallTool(context.Background(), &mcp.CallToolParams{
Name: "submit_task",
Arguments: map[string]any{"instructions": "do a thing"},
})
if err != nil {
t.Fatalf("transport error: %v", err)
}
if !res.IsError {
t.Fatal("expected submit_task without repository_url to be a tool error")
}
}
func TestChatbotMCP_GetAndListTasks(t *testing.T) {
srv, store := testServer(t)
srv.SetAPIToken("s3cret")
createTaskWithState(t, store, "ct-ready", task.StateReady)
cs := chatbotClient(t, srv, "s3cret")
got := callText(t, cs, "get_task", map[string]any{"task_id": "ct-ready"})
var view map[string]any
if err := json.Unmarshal([]byte(got), &view); err != nil {
t.Fatalf("unmarshal get_task: %v", err)
}
if view["id"] != "ct-ready" {
t.Errorf("get_task id: got %v", view["id"])
}
listed := callText(t, cs, "list_tasks", map[string]any{"state": "READY"})
var tasks []compactTask
if err := json.Unmarshal([]byte(listed), &tasks); err != nil {
t.Fatalf("unmarshal list_tasks: %v", err)
}
if len(tasks) != 1 || tasks[0].ID != "ct-ready" {
t.Errorf("list_tasks returned %+v", tasks)
}
}
func TestChatbotMCP_GetTask_NotFound(t *testing.T) {
srv, _ := testServer(t)
srv.SetAPIToken("s3cret")
cs := chatbotClient(t, srv, "s3cret")
res, err := cs.CallTool(context.Background(), &mcp.CallToolParams{
Name: "get_task",
Arguments: map[string]any{"task_id": "nope"},
})
if err != nil {
t.Fatalf("transport error: %v", err)
}
if !res.IsError {
t.Fatal("expected get_task on missing task to be a tool error")
}
}
func TestChatbotMCP_GetEvents(t *testing.T) {
srv, store := testServer(t)
srv.SetAPIToken("s3cret")
createTaskWithState(t, store, "ct-events", task.StateReady)
cs := chatbotClient(t, srv, "s3cret")
out := callText(t, cs, "get_events", map[string]any{"task_id": "ct-events"})
var events []map[string]any
if err := json.Unmarshal([]byte(out), &events); err != nil {
t.Fatalf("unmarshal get_events %q: %v", out, err)
}
// State walk to READY emits state_change events.
if len(events) == 0 {
t.Error("expected at least one event for a task that walked to READY")
}
}
func TestChatbotMCP_AcceptTask(t *testing.T) {
srv, store := testServer(t)
srv.SetAPIToken("s3cret")
createTaskWithState(t, store, "ct-accept", task.StateReady)
cs := chatbotClient(t, srv, "s3cret")
callText(t, cs, "accept_task", map[string]any{"task_id": "ct-accept"})
got, _ := store.GetTask("ct-accept")
if got.State != task.StateCompleted {
t.Errorf("after accept_task: want COMPLETED, got %s", got.State)
}
}
func TestChatbotMCP_RejectTask(t *testing.T) {
srv, store := testServer(t)
srv.SetAPIToken("s3cret")
createTaskWithState(t, store, "ct-reject", task.StateReady)
cs := chatbotClient(t, srv, "s3cret")
callText(t, cs, "reject_task", map[string]any{"task_id": "ct-reject", "comment": "needs work"})
got, _ := store.GetTask("ct-reject")
if got.State != task.StatePending {
t.Errorf("after reject_task: want PENDING, got %s", got.State)
}
if got.RejectionComment != "needs work" {
t.Errorf("rejection comment: got %q", got.RejectionComment)
}
}
func TestChatbotMCP_CancelTask(t *testing.T) {
srv, store := testServer(t)
srv.SetAPIToken("s3cret")
createTaskWithState(t, store, "ct-cancel", task.StateQueued)
cs := chatbotClient(t, srv, "s3cret")
callText(t, cs, "cancel_task", map[string]any{"task_id": "ct-cancel"})
got, _ := store.GetTask("ct-cancel")
if got.State != task.StateCancelled {
t.Errorf("after cancel_task: want CANCELLED, got %s", got.State)
}
}
func TestChatbotMCP_AnswerQuestion(t *testing.T) {
srv, store := testServer(t)
srv.SetAPIToken("s3cret")
createTaskWithState(t, store, "ct-answer", task.StateBlocked)
if err := store.CreateExecution(&storage.Execution{
ID: "ct-answer-exec",
TaskID: "ct-answer",
SessionID: "550e8400-e29b-41d4-a716-446655440099",
Status: "BLOCKED",
}); err != nil {
t.Fatalf("create execution: %v", err)
}
cs := chatbotClient(t, srv, "s3cret")
callText(t, cs, "answer_question", map[string]any{"task_id": "ct-answer", "answer": "use main"})
got, _ := store.GetTask("ct-answer")
if got.State != task.StateQueued && got.State != task.StateRunning && got.State != task.StateReady {
t.Errorf("after answer_question: want QUEUED/RUNNING/READY, got %s", got.State)
}
}
|
