blob: cdd1cc2c57379a24ec426436877dadad57dce7a9 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
|
# ADR-006: Containerized Repository-Based Execution Model
## Status
Accepted (Supersedes ADR-005)
## Context
ADR-005 introduced a sandbox execution model based on local git clones and pushes back to a local project directory. While this provided isolation, it had several flaws identified during early adoption:
1. **Host pollution**: Build dependencies (Node, Go, etc.) had to be installed on the host and were subject to permission issues (e.g., `/root/.nvm` access for `www-data`).
2. **Fragile Pushes**: Pushing to a checked-out local branch is non-standard and requires risky git configs.
3. **Resume Divergence**: Resumed tasks bypassed the sandbox, reintroducing corruption risks.
4. **Scale**: Local directory-based "project selection" is a hack that doesn't scale to multiple repos or environments.
## Decision
We will move to a containerized execution model where projects are defined by canonical repository URLs and executed in isolated containers.
### 1. Repository-Based Projects
- The `Task` model now uses `RepositoryURL` as the source of truth for the codebase.
- This replaces the fragile reliance on local `ProjectDir` paths.
### 2. Containerized Sandboxes
- Each task execution runs in a fresh container (Docker/Podman).
- The runner clones the repository into a host-side temporary workspace and mounts it into the container.
- The container provides a "bare system" with the full build stack (Node, Go, etc.) pre-installed, isolating the host from build dependencies.
### 3. Unified Workspace Management (including RESUME)
- Unlike ADR-005, the containerized model is designed to handle **Resume** by re-attaching to or re-mounting the same host-side workspace.
- This ensures that resumed tasks **do not** bypass the sandbox and never land directly in a production directory.
### 4. Push to Actual Remotes
- Agents commit changes within the sandbox.
- The runner pushes these commits directly to the `RepositoryURL` (actual remote).
- If the remote is missing or the push fails, the task is marked `FAILED` and the host-side workspace is preserved for inspection.
## Rationale
- **Isolation**: Containers prevent host pollution and ensure a consistent build environment.
- **Safety**: Repository URLs provide a standard way to manage codebases across environments.
- **Consistency**: Unified workspace management for initial runs and resumes eliminates the behavioral divergence found in ADR-005.
## Consequences
- Requires a container runtime (Docker) on the host.
- Requires pre-built agent images (e.g., `claudomator-agent:latest`).
- **Disk Space Risk**: Host-side clones still consume `/tmp` space. Mitigation requires periodic cleanup of old workspaces or disk-space monitoring.
- **Git Config**: Repositories no longer require `receive.denyCurrentBranch = updateInstead` because we push to the remote, not a local worktree.
## Relevant Code Locations
| Concern | File |
|---|---|
| Container Lifecycle | `internal/executor/container.go` |
| Runner Registration | `internal/cli/serve.go` |
| Task Model | `internal/task/task.go` |
| API Integration | `internal/api/server.go` |
|
