1 files changed, 93 insertions, 3 deletions

diff --git a/internal/executor/executor_test.go b/internal/executor/executor_test.go
index 2e01230..b93e819 100644
--- a/internal/executor/executor_test.go
+++ b/internal/executor/executor_test.go
@@ -1056,9 +1056,11 @@ func (m *minimalMockStore) UpdateExecutionChangestats(execID string, stats *task
 	m.mu.Unlock()
 	return nil
 }
-func (m *minimalMockStore) RecordAgentEvent(_ storage.AgentEvent) error { return nil }
-func (m *minimalMockStore) GetProject(_ string) (*task.Project, error) { return nil, nil }
-func (m *minimalMockStore) GetStory(_ string) (*task.Story, error)     { return nil, nil }
+func (m *minimalMockStore) RecordAgentEvent(_ storage.AgentEvent) error        { return nil }
+func (m *minimalMockStore) GetProject(_ string) (*task.Project, error)          { return nil, nil }
+func (m *minimalMockStore) GetStory(_ string) (*task.Story, error)              { return nil, nil }
+func (m *minimalMockStore) ListTasksByStory(_ string) ([]*task.Task, error)     { return nil, nil }
+func (m *minimalMockStore) UpdateStoryStatus(_ string, _ task.StoryState) error { return nil }
 
 func (m *minimalMockStore) lastStateUpdate() (string, task.State, bool) {
 	m.mu.Lock()
@@ -1625,6 +1627,94 @@ func TestPool_ConsecutiveFailures_ResetOnSuccess(t *testing.T) {
 	}
 }
 
+func TestPool_CheckStoryCompletion_AllComplete(t *testing.T) {
+	store := testStore(t)
+	logger := slog.New(slog.NewTextHandler(os.Stderr, &slog.HandlerOptions{Level: slog.LevelError}))
+	pool := NewPool(2, map[string]Runner{"claude": &mockRunner{}}, store, logger)
+
+	// Create a story in IN_PROGRESS state.
+	now := time.Now().UTC()
+	story := &task.Story{
+		ID:        "story-comp-1",
+		Name:      "Completion Test",
+		Status:    task.StoryInProgress,
+		CreatedAt: now,
+		UpdatedAt: now,
+	}
+	if err := store.CreateStory(story); err != nil {
+		t.Fatalf("CreateStory: %v", err)
+	}
+
+	// Create two story tasks and drive them through valid transitions to COMPLETED.
+	for i, id := range []string{"sctask-1", "sctask-2"} {
+		tk := makeTask(id)
+		tk.StoryID = "story-comp-1"
+		tk.ParentTaskID = "fake-parent" // so it goes to COMPLETED
+		tk.State = task.StatePending
+		if err := store.CreateTask(tk); err != nil {
+			t.Fatalf("CreateTask %d: %v", i, err)
+		}
+		for _, s := range []task.State{task.StateQueued, task.StateRunning, task.StateCompleted} {
+			if err := store.UpdateTaskState(id, s); err != nil {
+				t.Fatalf("UpdateTaskState %s → %s: %v", id, s, err)
+			}
+		}
+	}
+
+	pool.checkStoryCompletion(context.Background(), "story-comp-1")
+
+	got, err := store.GetStory("story-comp-1")
+	if err != nil {
+		t.Fatalf("GetStory: %v", err)
+	}
+	if got.Status != task.StoryShippable {
+		t.Errorf("story status: want SHIPPABLE, got %v", got.Status)
+	}
+}
+
+func TestPool_CheckStoryCompletion_PartialComplete(t *testing.T) {
+	store := testStore(t)
+	logger := slog.New(slog.NewTextHandler(os.Stderr, &slog.HandlerOptions{Level: slog.LevelError}))
+	pool := NewPool(2, map[string]Runner{"claude": &mockRunner{}}, store, logger)
+
+	now := time.Now().UTC()
+	story := &task.Story{
+		ID:        "story-partial-1",
+		Name:      "Partial Test",
+		Status:    task.StoryInProgress,
+		CreatedAt: now,
+		UpdatedAt: now,
+	}
+	if err := store.CreateStory(story); err != nil {
+		t.Fatalf("CreateStory: %v", err)
+	}
+
+	// First task driven to COMPLETED.
+	tk1 := makeTask("sptask-1")
+	tk1.StoryID = "story-partial-1"
+	tk1.ParentTaskID = "fake-parent"
+	store.CreateTask(tk1)
+	for _, s := range []task.State{task.StateQueued, task.StateRunning, task.StateCompleted} {
+		store.UpdateTaskState("sptask-1", s)
+	}
+
+	// Second task still in PENDING (not done).
+	tk2 := makeTask("sptask-2")
+	tk2.StoryID = "story-partial-1"
+	tk2.ParentTaskID = "fake-parent"
+	store.CreateTask(tk2)
+
+	pool.checkStoryCompletion(context.Background(), "story-partial-1")
+
+	got, err := store.GetStory("story-partial-1")
+	if err != nil {
+		t.Fatalf("GetStory: %v", err)
+	}
+	if got.Status != task.StoryInProgress {
+		t.Errorf("story status: want IN_PROGRESS (no transition), got %v", got.Status)
+	}
+}
+
 func TestPool_Undrain_ResumesExecution(t *testing.T) {
 	store := testStore(t)