summaryrefslogtreecommitdiff
path: root/internal/api/server_test.go
diff options
context:
space:
mode:
Diffstat (limited to 'internal/api/server_test.go')
-rw-r--r--internal/api/server_test.go58
1 files changed, 58 insertions, 0 deletions
diff --git a/internal/api/server_test.go b/internal/api/server_test.go
index 24e1d30..460c669 100644
--- a/internal/api/server_test.go
+++ b/internal/api/server_test.go
@@ -518,6 +518,64 @@ func TestListTasks_WithTasks(t *testing.T) {
}
}
+// TestListTasks_NeedsReviewFilter proves GET /api/tasks?needs_review=true
+// only returns tasks flagged needs_review (set by
+// internal/scheduler.Scheduler's ask-user-timeout escalation).
+func TestListTasks_NeedsReviewFilter(t *testing.T) {
+ srv, store := testServer(t)
+
+ flagged := &task.Task{
+ ID: "nr-1", Name: "flagged",
+ RepositoryURL: "https://github.com/user/repo",
+ Agent: task.AgentConfig{Type: "claude", Instructions: "x"}, Priority: task.PriorityNormal,
+ Retry: task.RetryConfig{MaxAttempts: 1, Backoff: "linear"},
+ Tags: []string{}, DependsOn: []string{}, State: task.StatePending,
+ }
+ if err := store.CreateTask(flagged); err != nil {
+ t.Fatalf("CreateTask flagged: %v", err)
+ }
+ if err := store.UpdateTaskNeedsReview(flagged.ID, true); err != nil {
+ t.Fatalf("UpdateTaskNeedsReview: %v", err)
+ }
+
+ notFlagged := &task.Task{
+ ID: "nr-2", Name: "not flagged",
+ RepositoryURL: "https://github.com/user/repo",
+ Agent: task.AgentConfig{Type: "claude", Instructions: "x"}, Priority: task.PriorityNormal,
+ Retry: task.RetryConfig{MaxAttempts: 1, Backoff: "linear"},
+ Tags: []string{}, DependsOn: []string{}, State: task.StatePending,
+ }
+ if err := store.CreateTask(notFlagged); err != nil {
+ t.Fatalf("CreateTask notFlagged: %v", err)
+ }
+
+ req := httptest.NewRequest("GET", "/api/tasks?needs_review=true", nil)
+ w := httptest.NewRecorder()
+ srv.Handler().ServeHTTP(w, req)
+
+ if w.Code != http.StatusOK {
+ t.Fatalf("status: want 200, got %d; body: %s", w.Code, w.Body.String())
+ }
+ var tasks []task.Task
+ if err := json.NewDecoder(w.Body).Decode(&tasks); err != nil {
+ t.Fatalf("decode: %v", err)
+ }
+ if len(tasks) != 1 {
+ t.Fatalf("want 1 needs_review task, got %d: %+v", len(tasks), tasks)
+ }
+ if tasks[0].ID != "nr-1" || !tasks[0].NeedsReview {
+ t.Errorf("expected flagged task nr-1 with NeedsReview=true, got %+v", tasks[0])
+ }
+
+ // Sanity check: an invalid needs_review value is a 400, not a silent no-op.
+ req2 := httptest.NewRequest("GET", "/api/tasks?needs_review=notabool", nil)
+ w2 := httptest.NewRecorder()
+ srv.Handler().ServeHTTP(w2, req2)
+ if w2.Code != http.StatusBadRequest {
+ t.Errorf("invalid needs_review: want 400, got %d", w2.Code)
+ }
+}
+
// stateWalkPaths defines the sequence of intermediate states needed to reach each target state.
var stateWalkPaths = map[task.State][]task.State{
task.StatePending: {},