fix: address round 2 review feedback for container execution

- Fix host/container path confusion for --env-file
- Fix --resume flag to only be used during resumptions
- Fix instruction passing to Claude CLI via shell-wrapped cat
- Restore streamErr return logic to detect task-level failures
- Improve success flag logic for workspace preservation
- Remove duplicate RepositoryURL from AgentConfig
- Fix app.js indentation and reformat DOMContentLoaded block
- Restore behavioral test coverage in container_test.go

1 files changed, 137 insertions, 135 deletions

diff --git a/web/app.js b/web/app.js
index 7577c37..6ddb23c 100644
--- a/web/app.js
+++ b/web/app.js
@@ -2717,159 +2717,161 @@ function switchTab(name) {
 
 // ── Boot ──────────────────────────────────────────────────────────────────────
 
-if (typeof document !== 'undefined') document.addEventListener('DOMContentLoaded', () => {
-  document.getElementById('btn-start-next').addEventListener('click', function() {
-    handleStartNextTask(this);
-  });
-
-  switchTab(getActiveMainTab());
-  startPolling();
-  connectWebSocket();
-
-  // Side panel close
-  document.getElementById('btn-close-panel').addEventListener('click', closeTaskPanel);
-  document.getElementById('task-panel-backdrop').addEventListener('click', closeTaskPanel);
+if (typeof document !== 'undefined') {
+  document.addEventListener('DOMContentLoaded', () => {
+    document.getElementById('btn-start-next').addEventListener('click', function() {
+      handleStartNextTask(this);
+    });
 
-  // Execution logs modal close
-  document.getElementById('btn-close-logs').addEventListener('click', () => {
-    document.getElementById('logs-modal').close();
-  });
+    switchTab(getActiveMainTab());
+    startPolling();
+    connectWebSocket();
 
-  // Tab bar
-  document.querySelectorAll('.tab').forEach(btn => {
-    btn.addEventListener('click', () => switchTab(btn.dataset.tab));
-  });
+    // Side panel close
+    document.getElementById('btn-close-panel').addEventListener('click', closeTaskPanel);
+    document.getElementById('task-panel-backdrop').addEventListener('click', closeTaskPanel);
 
-  // Task modal
-  document.getElementById('btn-new-task').addEventListener('click', openTaskModal);
-  document.getElementById('btn-cancel-task').addEventListener('click', closeTaskModal);
+    // Execution logs modal close
+    document.getElementById('btn-close-logs').addEventListener('click', () => {
+      document.getElementById('logs-modal').close();
+    });
 
-  // Push notifications button
-  const btnNotify = document.getElementById('btn-notifications');
-  if (btnNotify) {
-    btnNotify.addEventListener('click', () => enableNotifications(btnNotify));
-  }
+    // Tab bar
+    document.querySelectorAll('.tab').forEach(btn => {
+      btn.addEventListener('click', () => switchTab(btn.dataset.tab));
+    });
 
-  // Validate button
-  document.getElementById('btn-validate').addEventListener('click', async () => {
-    const btn = document.getElementById('btn-validate');
-    const resultDiv = document.getElementById('validate-result');
-    btn.disabled = true;
-    btn.textContent = 'Checking…';
-    try {
-      const payload = buildValidatePayload();
-      const result = await validateTask(payload);
-      renderValidationResult(result);
-    } catch (err) {
-      resultDiv.removeAttribute('hidden');
-      resultDiv.textContent = 'Validation failed: ' + err.message;
-    } finally {
-      btn.disabled = false;
-      btn.textContent = 'Validate Instructions';
-    }
-  });
+    // Task modal
+    document.getElementById('btn-new-task').addEventListener('click', openTaskModal);
+    document.getElementById('btn-cancel-task').addEventListener('click', closeTaskModal);
 
-  // Draft with AI button
-  const btnElaborate = document.getElementById('btn-elaborate');
-  btnElaborate.addEventListener('click', async () => {
-    const prompt = document.getElementById('elaborate-prompt').value.trim();
-    if (!prompt) {
-      const form = document.getElementById('task-form');
-      // Remove previous error
-      const prev = form.querySelector('.form-error');
-      if (prev) prev.remove();
-      const errEl = document.createElement('p');
-      errEl.className = 'form-error';
-      errEl.textContent = 'Please enter a description before drafting.';
-      form.querySelector('.elaborate-section').appendChild(errEl);
-      return;
+    // Push notifications button
+    const btnNotify = document.getElementById('btn-notifications');
+    if (btnNotify) {
+      btnNotify.addEventListener('click', () => enableNotifications(btnNotify));
     }
 
-    btnElaborate.disabled = true;
-    btnElaborate.textContent = 'Drafting…';
-
-    // Remove any previous errors or banners
-    const form = document.getElementById('task-form');
-    form.querySelectorAll('.form-error, .elaborate-banner').forEach(el => el.remove());
-
-    try {
-      const repoUrl = document.getElementById('repository-url').value.trim();
-      const result = await elaborateTask(prompt, repoUrl);
-
-      // Populate form fields
-      const f = document.getElementById('task-form');
-      if (result.name)
-        f.querySelector('[name="name"]').value = result.name;
-      if (result.agent && result.agent.instructions)
-        f.querySelector('[name="instructions"]').value = result.agent.instructions;
-      if (result.repository_url || result.agent?.repository_url) {
-        document.getElementById('repository-url').value = result.repository_url || result.agent.repository_url;
-      }
-      if (result.agent && result.agent.container_image) {
-        document.getElementById('container-image').value = result.agent.container_image;
+    // Validate button
+    document.getElementById('btn-validate').addEventListener('click', async () => {
+      const btn = document.getElementById('btn-validate');
+      const resultDiv = document.getElementById('validate-result');
+      btn.disabled = true;
+      btn.textContent = 'Checking…';
+      try {
+        const payload = buildValidatePayload();
+        const result = await validateTask(payload);
+        renderValidationResult(result);
+      } catch (err) {
+        resultDiv.removeAttribute('hidden');
+        resultDiv.textContent = 'Validation failed: ' + err.message;
+      } finally {
+        btn.disabled = false;
+        btn.textContent = 'Validate Instructions';
       }
-      if (result.agent && result.agent.max_budget_usd != null)
-        f.querySelector('[name="max_budget_usd"]').value = result.agent.max_budget_usd;
-      if (result.timeout)
-        f.querySelector('[name="timeout"]').value = result.timeout;
-      if (result.priority) {
-        const sel = f.querySelector('[name="priority"]');
-        if ([...sel.options].some(o => o.value === result.priority)) {
-          sel.value = result.priority;
-        }
+    });
+
+    // Draft with AI button
+    const btnElaborate = document.getElementById('btn-elaborate');
+    btnElaborate.addEventListener('click', async () => {
+      const prompt = document.getElementById('elaborate-prompt').value.trim();
+      if (!prompt) {
+        const form = document.getElementById('task-form');
+        // Remove previous error
+        const prev = form.querySelector('.form-error');
+        if (prev) prev.remove();
+        const errEl = document.createElement('p');
+        errEl.className = 'form-error';
+        errEl.textContent = 'Please enter a description before drafting.';
+        form.querySelector('.elaborate-section').appendChild(errEl);
+        return;
       }
 
-      // Show success banner
-      const banner = document.createElement('p');
-      banner.className = 'elaborate-banner';
-      banner.textContent = 'AI draft ready — review and submit.';
-      document.getElementById('task-form').querySelector('.elaborate-section').appendChild(banner);
+      btnElaborate.disabled = true;
+      btnElaborate.textContent = 'Drafting…';
+
+      // Remove any previous errors or banners
+      const form = document.getElementById('task-form');
+      form.querySelectorAll('.form-error, .elaborate-banner').forEach(el => el.remove());
 
-      // Auto-validate after elaboration
       try {
-        const result = await validateTask(buildValidatePayload());
-        renderValidationResult(result);
-      } catch (_) {
-        // silent - elaboration already succeeded, validation is bonus
+        const repoUrl = document.getElementById('repository-url').value.trim();
+        const result = await elaborateTask(prompt, repoUrl);
+
+        // Populate form fields
+        const f = document.getElementById('task-form');
+        if (result.name)
+          f.querySelector('[name="name"]').value = result.name;
+        if (result.agent && result.agent.instructions)
+          f.querySelector('[name="instructions"]').value = result.agent.instructions;
+        if (result.repository_url || result.agent?.repository_url) {
+          document.getElementById('repository-url').value = result.repository_url || result.agent.repository_url;
+        }
+        if (result.agent && result.agent.container_image) {
+          document.getElementById('container-image').value = result.agent.container_image;
+        }
+        if (result.agent && result.agent.max_budget_usd != null)
+          f.querySelector('[name="max_budget_usd"]').value = result.agent.max_budget_usd;
+        if (result.timeout)
+          f.querySelector('[name="timeout"]').value = result.timeout;
+        if (result.priority) {
+          const sel = f.querySelector('[name="priority"]');
+          if ([...sel.options].some(o => o.value === result.priority)) {
+            sel.value = result.priority;
+          }
+        }
+
+        // Show success banner
+        const banner = document.createElement('p');
+        banner.className = 'elaborate-banner';
+        banner.textContent = 'AI draft ready — review and submit.';
+        document.getElementById('task-form').querySelector('.elaborate-section').appendChild(banner);
+
+        // Auto-validate after elaboration
+        try {
+          const result = await validateTask(buildValidatePayload());
+          renderValidationResult(result);
+        } catch (_) {
+          // silent - elaboration already succeeded, validation is bonus
+        }
+      } catch (err) {
+        const errEl = document.createElement('p');
+        errEl.className = 'form-error';
+        errEl.textContent = `Elaboration failed: ${err.message}`;
+        document.getElementById('task-form').querySelector('.elaborate-section').appendChild(errEl);
+      } finally {
+        btnElaborate.disabled = false;
+        btnElaborate.textContent = 'Draft with AI ✦';
       }
-    } catch (err) {
-      const errEl = document.createElement('p');
-      errEl.className = 'form-error';
-      errEl.textContent = `Elaboration failed: ${err.message}`;
-      document.getElementById('task-form').querySelector('.elaborate-section').appendChild(errEl);
-    } finally {
-      btnElaborate.disabled = false;
-      btnElaborate.textContent = 'Draft with AI ✦';
-    }
-  });
+    });
 
-  document.getElementById('task-form').addEventListener('submit', async e => {
-    e.preventDefault();
+    document.getElementById('task-form').addEventListener('submit', async e => {
+      e.preventDefault();
 
-    // Remove any previous error
-    const prev = e.target.querySelector('.form-error');
-    if (prev) prev.remove();
+      // Remove any previous error
+      const prev = e.target.querySelector('.form-error');
+      if (prev) prev.remove();
 
-    const btn = e.submitter;
-    btn.disabled = true;
-    btn.textContent = 'Creating…';
+      const btn = e.submitter;
+      btn.disabled = true;
+      btn.textContent = 'Creating…';
 
-    try {
-      const validateResult = document.getElementById('validate-result');
-      if (!validateResult.hasAttribute('hidden') && validateResult.dataset.clarity && validateResult.dataset.clarity !== 'clear') {
-        if (!window.confirm('The validator flagged issues. Create task anyway?')) {
-          return;
+      try {
+        const validateResult = document.getElementById('validate-result');
+        if (!validateResult.hasAttribute('hidden') && validateResult.dataset.clarity && validateResult.dataset.clarity !== 'clear') {
+          if (!window.confirm('The validator flagged issues. Create task anyway?')) {
+            return;
+          }
         }
+        await createTask(new FormData(e.target));
+      } catch (err) {
+        const errEl = document.createElement('p');
+        errEl.className = 'form-error';
+        errEl.textContent = err.message;
+        e.target.appendChild(errEl);
+      } finally {
+        btn.disabled = false;
+        btn.textContent = 'Create & Queue';
       }
-      await createTask(new FormData(e.target));
-    } catch (err) {
-      const errEl = document.createElement('p');
-      errEl.className = 'form-error';
-      errEl.textContent = err.message;
-      e.target.appendChild(errEl);
-    } finally {
-      btn.disabled = false;
-      btn.textContent = 'Create & Queue';
-    }
+    });
   });
-});
+}