feat: validation result transitions story to REVIEW_READY or NEEDS_FIX (ADR-007)

Add checkValidationResult which inspects the final task.State of a
completed validation task and updates the story to REVIEW_READY (pass)
or NEEDS_FIX (fail). Wire into handleRunResult so stories in
VALIDATING state are dispatched to checkValidationResult instead of
checkStoryCompletion, covering both success and FAILED terminal paths.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

1 files changed, 57 insertions, 0 deletions

diff --git a/internal/executor/executor_test.go b/internal/executor/executor_test.go
index 9e39f14..15ce363 100644
--- a/internal/executor/executor_test.go
+++ b/internal/executor/executor_test.go
@@ -1858,3 +1858,60 @@ func TestPool_PostDeploy_CreatesValidationTask(t *testing.T) {
 		t.Errorf("task instructions %q do not reference validation spec content", vtask.Agent.Instructions)
 	}
 }
+
+func TestPool_ValidationTask_Pass_SetsReviewReady(t *testing.T) {
+	store := testStore(t)
+	logger := slog.New(slog.NewTextHandler(os.Stderr, &slog.HandlerOptions{Level: slog.LevelError}))
+	pool := NewPool(2, map[string]Runner{"claude": &mockRunner{}}, store, logger)
+
+	now := time.Now().UTC()
+	story := &task.Story{
+		ID:        "story-val-pass-1",
+		Name:      "Validation Pass",
+		Status:    task.StoryValidating,
+		CreatedAt: now,
+		UpdatedAt: now,
+	}
+	if err := store.CreateStory(story); err != nil {
+		t.Fatalf("CreateStory: %v", err)
+	}
+
+	pool.checkValidationResult(context.Background(), story.ID, task.StateCompleted, "")
+
+	got, err := store.GetStory(story.ID)
+	if err != nil {
+		t.Fatalf("GetStory: %v", err)
+	}
+	if got.Status != task.StoryReviewReady {
+		t.Errorf("story status: want REVIEW_READY, got %q", got.Status)
+	}
+}
+
+func TestPool_ValidationTask_Fail_SetsNeedsFix(t *testing.T) {
+	store := testStore(t)
+	logger := slog.New(slog.NewTextHandler(os.Stderr, &slog.HandlerOptions{Level: slog.LevelError}))
+	pool := NewPool(2, map[string]Runner{"claude": &mockRunner{}}, store, logger)
+
+	now := time.Now().UTC()
+	story := &task.Story{
+		ID:        "story-val-fail-1",
+		Name:      "Validation Fail",
+		Status:    task.StoryValidating,
+		CreatedAt: now,
+		UpdatedAt: now,
+	}
+	if err := store.CreateStory(story); err != nil {
+		t.Fatalf("CreateStory: %v", err)
+	}
+
+	execErr := "smoke test failed: /health returned 503"
+	pool.checkValidationResult(context.Background(), story.ID, task.StateFailed, execErr)
+
+	got, err := store.GetStory(story.ID)
+	if err != nil {
+		t.Fatalf("GetStory: %v", err)
+	}
+	if got.Status != task.StoryNeedsFix {
+		t.Errorf("story status: want NEEDS_FIX, got %q", got.Status)
+	}
+}