feat: spawn checker task on READY; auto-accept on pass; attach report on fail

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

1 files changed, 138 insertions, 0 deletions

diff --git a/internal/executor/executor_test.go b/internal/executor/executor_test.go
index 267d9ca..f5ac8b8 100644
--- a/internal/executor/executor_test.go
+++ b/internal/executor/executor_test.go
@@ -1109,6 +1109,8 @@ func (m *minimalMockStore) GetStory(_ string) (*task.Story, error)
 func (m *minimalMockStore) ListTasksByStory(_ string) ([]*task.Task, error)     { return nil, nil }
 func (m *minimalMockStore) UpdateStoryStatus(_ string, _ task.StoryState) error { return nil }
 func (m *minimalMockStore) CreateTask(_ *task.Task) error                      { return nil }
+func (m *minimalMockStore) UpdateTaskCheckerReport(_ string, _ string) error   { return nil }
+func (m *minimalMockStore) GetCheckerTask(_ string) (*task.Task, error)        { return nil, nil }
 
 func (m *minimalMockStore) lastStateUpdate() (string, task.State, bool) {
 	m.mu.Lock()
@@ -2083,3 +2085,139 @@ func TestPool_Shutdown_TimesOut(t *testing.T) {
 	}
 	close(unblock) // cleanup
 }
+
+func TestPool_CheckerSpawned_OnReady(t *testing.T) {
+	store := testStore(t)
+	runner := &mockRunner{} // succeeds instantly
+	pool := NewPool(2, map[string]Runner{"claude": runner}, store, slog.New(slog.NewTextHandler(os.Stderr, &slog.HandlerOptions{Level: slog.LevelError})))
+
+	tk := makeTask("checker-spawn-1")
+	tk.RepositoryURL = "https://github.com/x/y"
+	store.CreateTask(tk)
+	pool.Submit(context.Background(), tk)
+	<-pool.Results() // wait for original task to finish
+
+	// Give the async spawnCheckerTask goroutine a moment to run.
+	time.Sleep(200 * time.Millisecond)
+
+	checker, err := store.GetCheckerTask("checker-spawn-1")
+	if err != nil {
+		t.Fatalf("GetCheckerTask: %v", err)
+	}
+	if checker == nil {
+		t.Fatal("expected a checker task to be created, got nil")
+	}
+	if checker.CheckerForTaskID != "checker-spawn-1" {
+		t.Errorf("expected CheckerForTaskID=checker-spawn-1, got %q", checker.CheckerForTaskID)
+	}
+}
+
+func TestPool_CheckerNotSpawned_ForSubtask(t *testing.T) {
+	store := testStore(t)
+	runner := &mockRunner{}
+	pool := NewPool(2, map[string]Runner{"claude": runner}, store, slog.New(slog.NewTextHandler(os.Stderr, &slog.HandlerOptions{Level: slog.LevelError})))
+
+	parent := makeTask("no-checker-parent")
+	parent.RepositoryURL = "https://github.com/x/y"
+	store.CreateTask(parent)
+
+	sub := makeTask("no-checker-sub")
+	sub.ParentTaskID = "no-checker-parent"
+	sub.RepositoryURL = "https://github.com/x/y"
+	store.CreateTask(sub)
+
+	pool.Submit(context.Background(), sub)
+	<-pool.Results()
+
+	time.Sleep(100 * time.Millisecond)
+
+	checker, err := store.GetCheckerTask("no-checker-sub")
+	if err != nil {
+		t.Fatalf("GetCheckerTask: %v", err)
+	}
+	if checker != nil {
+		t.Error("expected no checker for subtask, but one was created")
+	}
+}
+
+func TestPool_CheckerPass_AutoAcceptsTask(t *testing.T) {
+	store := testStore(t)
+	// Two-phase: first runner succeeds (original task), second also succeeds (checker).
+	callCount := 0
+	runner := &mockRunner{
+		onRun: func(t *task.Task, e *storage.Execution) error {
+			callCount++
+			return nil // both original and checker succeed
+		},
+	}
+	pool := NewPool(2, map[string]Runner{"claude": runner}, store, slog.New(slog.NewTextHandler(os.Stderr, &slog.HandlerOptions{Level: slog.LevelError})))
+
+	tk := makeTask("autoaccept-1")
+	tk.RepositoryURL = "https://github.com/x/y"
+	store.CreateTask(tk)
+	pool.Submit(context.Background(), tk)
+	<-pool.Results() // original finishes → READY + checker spawned
+
+	// Wait for checker to run and complete.
+	deadline := time.Now().Add(5 * time.Second)
+	for time.Now().Before(deadline) {
+		got, _ := store.GetTask("autoaccept-1")
+		if got != nil && got.State == task.StateCompleted {
+			break
+		}
+		<-pool.Results()
+	}
+
+	got, err := store.GetTask("autoaccept-1")
+	if err != nil {
+		t.Fatalf("GetTask: %v", err)
+	}
+	if got.State != task.StateCompleted {
+		t.Errorf("expected COMPLETED after checker pass, got %s", got.State)
+	}
+}
+
+func TestPool_CheckerFail_AttachesReport(t *testing.T) {
+	store := testStore(t)
+	callCount := 0
+	runner := &mockRunner{
+		onRun: func(t *task.Task, e *storage.Execution) error {
+			callCount++
+			if t.CheckerForTaskID != "" {
+				return fmt.Errorf("test suite failed: 3 failures")
+			}
+			return nil // original task succeeds
+		},
+	}
+	pool := NewPool(2, map[string]Runner{"claude": runner}, store, slog.New(slog.NewTextHandler(os.Stderr, &slog.HandlerOptions{Level: slog.LevelError})))
+
+	tk := makeTask("fail-checker-1")
+	tk.RepositoryURL = "https://github.com/x/y"
+	store.CreateTask(tk)
+	pool.Submit(context.Background(), tk)
+	<-pool.Results() // original → READY
+
+	// Wait for checker to fail.
+	deadline := time.Now().Add(5 * time.Second)
+	for time.Now().Before(deadline) {
+		got, _ := store.GetTask("fail-checker-1")
+		if got != nil && got.CheckerReport != "" {
+			break
+		}
+		select {
+		case <-pool.Results():
+		case <-time.After(100 * time.Millisecond):
+		}
+	}
+
+	got, err := store.GetTask("fail-checker-1")
+	if err != nil {
+		t.Fatalf("GetTask: %v", err)
+	}
+	if got.State != task.StateReady {
+		t.Errorf("expected task to stay READY after checker fail, got %s", got.State)
+	}
+	if got.CheckerReport == "" {
+		t.Error("expected checker_report to be set after checker failure")
+	}
+}