diff options
| author | Claude Sonnet 5 <noreply@anthropic.com> | 2026-07-03 08:49:43 +0000 |
|---|---|---|
| committer | Claude Sonnet 5 <noreply@anthropic.com> | 2026-07-03 08:49:43 +0000 |
| commit | 67e0081c6d573b701ed931f96e14dbe5b4258a17 (patch) | |
| tree | bc7f8ce0d57876dd85720924d0275dc39c05e5b4 /internal/config/config_test.go | |
| parent | 3d286974cdc28c68c5ee536ce9303899dae9540e (diff) | |
refactor(executor): extract provider-neutral tool-use loop (Phase 1)
Splits LocalRunner's OpenAI-specific agentic loop into reusable, provider-
agnostic pieces so later phases can add native Anthropic/OpenAI/Google/Groq/
OpenRouter adapters without duplicating the control flow:
- internal/provider: neutral Provider/ChatRequest/ChatResponse types, plus
an openaicompat adapter wrapping the existing internal/llm.Client unchanged
- internal/sandbox: Sandbox interface + HostSandbox (git clone/push/cleanup,
read_file/write_file/run_bash/glob), lifted verbatim from local.go/localtools.go
- internal/agentloop: the extracted tool-use loop (request/response/tool-
dispatch/loop, ask_user blocking, stream-json envelope, summary fallback)
- internal/agentchannel: AgentChannel/SubtaskSpec/BlockedError/ErrAgentBlocked
moved out of internal/executor so agentloop can use them without an import
cycle; internal/executor re-exports via type aliases, so no call site changes
- internal/executor/nativerunner.go: NativeRunner replaces LocalRunner,
wiring agentloop.Loop + openaicompat + HostSandbox together
- config.Providers map[string]ProviderConfig added (unused until Phase 2+)
Zero intended behavior change: go test -race ./... passes across all
packages, and end-to-end stream-json/summary/changestats output was verified
byte-compatible against a fake OpenAI-compatible server. Adds test coverage
for sandbox tool-dispatch (git clone/push, read/write/bash/glob) that
LocalRunner never had.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01V1moSNCJRcP6kykA4tyUSs
Diffstat (limited to 'internal/config/config_test.go')
| -rw-r--r-- | internal/config/config_test.go | 43 |
1 files changed, 43 insertions, 0 deletions
diff --git a/internal/config/config_test.go b/internal/config/config_test.go index 0d47ca0..6991354 100644 --- a/internal/config/config_test.go +++ b/internal/config/config_test.go @@ -165,3 +165,46 @@ func TestLocalModel_UseForElaborate_ExplicitTrue(t *testing.T) { t.Error("explicit true should opt in") } } + +func TestProvidersConfig_TOMLRoundTrip(t *testing.T) { + dir := t.TempDir() + path := filepath.Join(dir, "config.toml") + toml := ` +[providers.groq] +endpoint = "https://api.groq.com/openai/v1" +api_key = "gsk_abc" +default_model = "llama-3.3-70b-versatile" +timeout_seconds = 30 + +[providers.anthropic] +api_key = "sk-ant-xyz" +default_model = "claude-sonnet-4-5" +` + if err := os.WriteFile(path, []byte(toml), 0600); err != nil { + t.Fatal(err) + } + t.Setenv("HOME", dir) + + cfg, err := LoadFile(path) + if err != nil { + t.Fatalf("unexpected error: %v", err) + } + if len(cfg.Providers) != 2 { + t.Fatalf("expected 2 providers, got %d: %+v", len(cfg.Providers), cfg.Providers) + } + groq, ok := cfg.Providers["groq"] + if !ok { + t.Fatal("expected [providers.groq] table") + } + if groq.Endpoint != "https://api.groq.com/openai/v1" || groq.APIKey != "gsk_abc" || + groq.DefaultModel != "llama-3.3-70b-versatile" || groq.TimeoutSeconds != 30 { + t.Errorf("groq provider config: %+v", groq) + } + anthropic, ok := cfg.Providers["anthropic"] + if !ok { + t.Fatal("expected [providers.anthropic] table") + } + if anthropic.Endpoint != "" || anthropic.APIKey != "sk-ant-xyz" || anthropic.DefaultModel != "claude-sonnet-4-5" { + t.Errorf("anthropic provider config: %+v", anthropic) + } +} |
