diff options
| author | Claude <noreply@anthropic.com> | 2026-05-26 21:08:25 +0000 |
|---|---|---|
| committer | Claude <noreply@anthropic.com> | 2026-05-26 21:08:25 +0000 |
| commit | b9d73497efe7c28800040b3e421bfb4cb6af6092 (patch) | |
| tree | 15084a4695c959d19aecdf64d94d0471e62605b2 /internal/cli | |
| parent | ab4b364954af08fa602388495ca425eaef0abf74 (diff) | |
feat(config,cli): loopback-default binding with fail-loud on external (Phase 7)
The server now defaults to binding 127.0.0.1 and refuses to bind a non-loopback
address (:8484, 0.0.0.0, a LAN IP, …) unless external_bind_allowed = true is set
in config — failing loud at startup instead of silently exposing itself.
External access is expected to go through a reverse proxy (Tailscale / Cloudflare
Access / Caddy), per the locked auth model.
- config: ExternalBindAllowed flag + ValidateBindAddr/isLoopbackHost (tested
across loopback, all-interfaces, LAN, and override cases).
- cli: --addr default is now 127.0.0.1:8484; serve() validates before binding.
Per-client bearer rotation stays deferred (single shared token for now).
https://claude.ai/code/session_01SESwn7kQ7oP62trWw6pc39
Diffstat (limited to 'internal/cli')
| -rw-r--r-- | internal/cli/serve.go | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/internal/cli/serve.go b/internal/cli/serve.go index 7afa678..9aa765b 100644 --- a/internal/cli/serve.go +++ b/internal/cli/serve.go @@ -12,6 +12,7 @@ import ( "github.com/thepeterstone/claudomator/internal/api" "github.com/thepeterstone/claudomator/internal/budget" + "github.com/thepeterstone/claudomator/internal/config" "github.com/thepeterstone/claudomator/internal/executor" "github.com/thepeterstone/claudomator/internal/notify" "github.com/thepeterstone/claudomator/internal/storage" @@ -34,7 +35,7 @@ func newServeCmd() *cobra.Command { }, } - cmd.Flags().StringVar(&addr, "addr", ":8484", "listen address") + cmd.Flags().StringVar(&addr, "addr", "127.0.0.1:8484", "listen address (loopback by default; set external_bind_allowed=true in config to bind externally)") cmd.Flags().StringVar(&workspaceRoot, "workspace-root", "/workspace", "root directory for listing workspaces") cmd.Flags().StringVar(&cfg.ClaudeImage, "claude-image", cfg.ClaudeImage, "docker image for claude agents") cmd.Flags().StringVar(&cfg.GeminiImage, "gemini-image", cfg.GeminiImage, "docker image for gemini agents") @@ -43,6 +44,9 @@ func newServeCmd() *cobra.Command { } func serve(addr string) error { + if err := config.ValidateBindAddr(addr, cfg.ExternalBindAllowed); err != nil { + return err + } if err := cfg.EnsureDirs(); err != nil { return fmt.Errorf("creating dirs: %w", err) } |