diff options
| author | Peter Stone <thepeterstone@gmail.com> | 2026-04-04 21:59:58 +0000 |
|---|---|---|
| committer | Peter Stone <thepeterstone@gmail.com> | 2026-05-03 17:58:25 +0000 |
| commit | 25cf4c9d4d6f3c18ee7565bf8e6172896fff00c3 (patch) | |
| tree | c5e2556800d428209f367af574e64765856b835d /internal/api | |
| parent | 49cdcd70f275c858b0511a2e88ab30a48b157fa3 (diff) | |
fix: prevent SHIPPABLE stories and wrong READY state on failed tasks
Three related bugs fixed:
1. maybeUnblockParent: guard against promoting QUEUED leaf tasks (no
subtasks) to READY. The vacuously-true 'all subtasks done' check was
advancing tasks that stalled in QUEUED (due to a prior SQLite lock
error) to READY on server restart via RecoverStaleBlocked, despite
having only failed executions and no commits.
2. checkStoryCompletion: require COMPLETED (not just READY) for all
top-level tasks before advancing a story to SHIPPABLE. READY means
the checker agent is still pending or the task awaits human review;
a story with READY tasks is not ready to ship.
3. handleAcceptTask: call CheckStoryCompletion after a task is accepted
so stories with parent tasks (whose subtasks are all done and then
the parent is manually accepted) can auto-advance to SHIPPABLE.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Diffstat (limited to 'internal/api')
| -rw-r--r-- | internal/api/server.go | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/internal/api/server.go b/internal/api/server.go index 604f354..e7756d1 100644 --- a/internal/api/server.go +++ b/internal/api/server.go @@ -697,6 +697,9 @@ func (s *Server) handleAcceptTask(w http.ResponseWriter, r *http.Request) { writeJSON(w, http.StatusInternalServerError, map[string]string{"error": err.Error()}) return } + if t.StoryID != "" { + go s.pool.CheckStoryCompletion(r.Context(), t.StoryID) + } writeJSON(w, http.StatusOK, map[string]string{"message": "task accepted", "task_id": id}) } |