diff options
| author | Peter Stone <thepeterstone@gmail.com> | 2026-05-02 22:10:48 -1000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2026-05-02 22:10:48 -1000 |
| commit | b32bfe1bc6bcbc45d7d1549d6ae6412bc3e4424f (patch) | |
| tree | 4dc822097b7f32a37ad655a550da1abada79ce85 /docs/plans | |
| parent | 1ec3f87c392145580a62858110d9fd10638203db (diff) | |
| parent | e7b382bf177cbe518af3d86c3ee6c49344d225f4 (diff) | |
Merge pull request #3 from thepeterstone/claude/deferred-work
Close deferred work — real GeminiRunner subprocess, Local UI option
Diffstat (limited to 'docs/plans')
| -rw-r--r-- | docs/plans/local-oss-runner.md | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/docs/plans/local-oss-runner.md b/docs/plans/local-oss-runner.md index 4d5cb87..4504bbb 100644 --- a/docs/plans/local-oss-runner.md +++ b/docs/plans/local-oss-runner.md @@ -222,6 +222,15 @@ Items not chased (deferred deliberately): - **Frontend "Local" agent option** — UI dropdown still says "Auto / Claude / Gemini". Pending token telemetry surface. - **`storage.db.go:706` TODO comment** — minor logger plumbing nit. Skipping unless it blocks something. +## Deferred work — DONE + +Follow-up commit closed the three deferred items above: + +- `GeminiRunner.execOnce` now invokes the actual `gemini` binary via `exec.CommandContext`, mirroring the `ClaudeRunner` pattern: pipe stdout to `parseGeminiStream`, kill the process group on context cancel, capture stderr to file, surface exit codes. Hardcoded simulation removed. +- Test infrastructure bug uncovered and fixed in passing: the mock gemini script in `testServerWithGeminiMockRunner` was using `"\``json\`"` which bash interpreted as command substitution, so the script always produced empty output. Switched to a single-quoted heredoc. The bug was masked previously because the runner ignored the script entirely. +- Frontend `index.html` dropdown gains a `Local` option. No JS branching changes needed — the value flows through to `agent.type` verbatim and downstream display reads the type string as-is. +- Stale debug-comment scaffolding around `storage.db.go:706` deleted. + --- # Phase 2 — Focused Plan (Elaboration) |