diff options
| author | Peter Stone <thepeterstone@gmail.com> | 2026-03-25 18:23:54 +0000 |
|---|---|---|
| committer | Peter Stone <thepeterstone@gmail.com> | 2026-03-25 18:23:54 +0000 |
| commit | e68212991935d33a4baca77d88cd20a82fbcf6a6 (patch) | |
| tree | bcb7e08ccd8b777a09f9699fe2f19d00b010d070 /.github/workflows/android.yml | |
| parent | ea5cdac728263fdc48b480460f3362a7f5fe221d (diff) | |
refactor: address simplify review findingsmain
TrackRepository.addPoint() now returns Boolean (true if point was
added). MainViewModel.addGpsPoint() only updates _trackPoints StateFlow
when a point is actually appended — eliminates ~3,600 no-op flow
emissions per hour when not recording.
MainActivity: loadedStyle promoted from nullable field to
MutableStateFlow<Style?>; trackPoints observer uses filterNotNull +
combine so no track points are silently dropped if the style loads
after the first GPS fix.
Smoke tests: replaced 11× ActivityScenario.launch().use{} with a
single @get:Rule ActivityScenarioRule — same isolation, less
boilerplate.
CI: removed redundant app-debug artifact upload (app-debug.apk is
already included inside the test-apks artifact).
Removed stale/placeholder comments from MainActivity.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Diffstat (limited to '.github/workflows/android.yml')
| -rw-r--r-- | .github/workflows/android.yml | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/.github/workflows/android.yml b/.github/workflows/android.yml index 150da6f..2c28410 100644 --- a/.github/workflows/android.yml +++ b/.github/workflows/android.yml @@ -27,12 +27,6 @@ jobs: run: ./gradlew assembleDebug assembleDebugAndroidTest working-directory: android-app - - name: Upload app APK (Firebase / manual download) - uses: actions/upload-artifact@v4 - with: - name: app-debug - path: android-app/app/build/outputs/apk/debug/app-debug.apk - - name: Upload test APKs (shared with smoke-test job) uses: actions/upload-artifact@v4 with: |