diff options
| author | Peter Stone <thepeterstone@gmail.com> | 2026-11-16 18:04:00 +0000 |
|---|---|---|
| committer | Peter Stone <thepeterstone@gmail.com> | 2026-11-16 18:04:00 +0000 |
| commit | d2bf715754094241e481d635b06a5fa417d31d3a (patch) | |
| tree | 6027bd86e13d833f36a066cc059de1c4dfb06033 /.superpowers/sdd/2026-10-12-break-kinds-and-furniture-toggle/timeline-readout.png | |
| parent | 0c955bd74f8f1ae097e32f2c1ec84da96e974282 (diff) | |
Housekeeping, no behaviour change. Peter asked for a round of it.
Daos.kt held twelve DAO interfaces in 745 lines, the largest file in the app.
They are now five files grouped the way the interfaces themselves already
argued for in their own docs: subscriptions, episodes and the three narrow
interfaces that exist so EpisodeDao does not get wider, the skip server's
findings, the queue, and the rules. Everything stayed in one package, so this
moved no imports and could not change behaviour; the proof is that the set of
101 declarations is identical before and after.
ReachabilityTest found the daos by the filename `data/Daos.kt`. That is the
sort of thing a split silently breaks -- not by failing, but by quietly
auditing fewer files than it used to. It now finds them by looking for @Dao,
so a dao that moves, or a new one, stays audited.
The build had 29 warnings. It has none.
- Fifteen were missing coroutines opt-ins in the view-model tests. The repo
already had the annotation on two methods elsewhere; these needed it on the
file, since the dispatcher is a property.
- Six were Media3's deprecated CommandButton.Builder. The replacement takes a
named icon instead of a drawable id, which is the better arrangement anyway:
the notification, the car and the watch each draw their own, where before all
three got this app's copy. All three icons it needs exist by name.
- Four were Compose icons that should be AutoMirrored, two a renamed typealias.
- One was a Json format rebuilt on every Apple lookup, now one per resolver,
matching ChapterParser and YouTubeProbe.
- One was Room warning that the library query selects a MAX column nothing
reads. It has to select it -- that is what makes SQLite pick the newest row of
each group -- so it is suppressed with the reason written down, rather than
letting Room rewrite the query and quietly change which episode every library
row offers.
CLAUDE.md gains the rule that came out of yesterday's eight-hour wedge -- a
test fails, it never hangs -- and the reasoning for the two coverage exclusions
added with it, including that the dao-bridge one flatters the number by
removing pre-existing dead lines as well as new ones.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018AwnALZL6bD4VBtATDVv3B
Diffstat (limited to '.superpowers/sdd/2026-10-12-break-kinds-and-furniture-toggle/timeline-readout.png')
0 files changed, 0 insertions, 0 deletions
