package org.terst.feedreader.data import kotlinx.coroutines.test.runTest import org.junit.Assert.assertEquals import org.junit.Assert.assertFalse import org.junit.Assert.assertNull import org.junit.Assert.assertTrue import org.junit.Test /** * The reported bug came with "extractedContent cached: true", which is the half * that a fixed extractor cannot reach: the cookie disclaimer was already written * to `articles.extractedContent`, and every open after that read it straight back * out without ever looking at it again. * * So a poisoned cache has to be recognised and dropped on read, not just kept out * on write. */ class CachedExtractionTest { private val cookieNotice = "
This website uses " + "cookies and other tracking technologies (“Cookies”) to enhance user experience, to " + "display targeted ads, and to analyze performance and user activity on our website. For " + "more information about our use of Cookies and our privacy practices, see our Privacy " + "Policy. By continuing to use this website, you agree to our Terms and Conditions.
" + "" + "The actual article body. ".repeat(60) + "
" val result = loadCachedExtraction(content) { cleared = true } assertEquals(content, result.content) assertFalse(result.discardedConsentNotice) assertFalse(result.discarded) assertFalse("a good cache must not be cleared", cleared) } @Test fun `a cached consent notice is discarded and deleted`() = runTest { var cleared = false val result = loadCachedExtraction(cookieNotice) { cleared = true } assertNull("the notice must not be shown as the article", result.content) assertTrue(result.discardedConsentNotice) assertTrue("the poisoned row must be cleared so a re-extract can replace it", cleared) } @Test fun `nothing cached touches nothing`() = runTest { var cleared = false val result = loadCachedExtraction(null) { cleared = true } assertNull(result.content) assertFalse(result.discardedConsentNotice) assertFalse(cleared) } // Same shape of problem as the consent notice, different cause: this content was // extracted before extraction knew how to render maths, so it holds the raw TeX source // Substack ships. A fixed extractor never gets a look at it -- the cached copy is // returned first and the article is never re-extracted. @Test fun `a cached extraction holding raw tex source is discarded and deleted`() = runTest { var cleared = false val rawTex = "Imagine the following sentence:
" + "" + "\\(p = \\text{\u201Cif }p\\text{ is true, then pigs can fly\u201D}\\)
" + "Considered as a whole, the statement cannot be true. ".repeat(20) + "
A slice of the set looks like this:
" + "" + "" + "The rest of the article continues from there. ".repeat(20) + "
" val result = loadCachedExtraction(withMathMl) { cleared = true } assertEquals(withMathMl, result.content) assertFalse(result.discardedUnrenderedTex) assertFalse("a good cache must not be cleared", cleared) } // A blank value is as good as nothing cached -- it is not a consent notice, so // reporting it as a discarded one would make the caller re-extract on a false // premise. @Test fun `a blank cached value is not reported as a discarded notice`() = runTest { var cleared = false val result = loadCachedExtraction(" ") { cleared = true } assertFalse(result.discardedConsentNotice) assertFalse(cleared) } /** * A cached article carrying the publisher's "Trending" promo widgets. Unlike a cookie * notice, the article itself is fine -- only the widgets have to go, and re-extracting * would be a pointless round trip that produced the same body again. */ @Test fun `a cached article has its recirculation widgets stripped without being re-extracted`() = runTest { var cleared = false val body = "" + "The actual article body. ".repeat(60) + "
" val widget = "