From bc891a67802c837d77726f618e68c2ac84ea22d7 Mon Sep 17 00:00:00 2001 From: Peter Stone Date: Sat, 22 Aug 2026 22:42:15 +0000 Subject: Restore the 5am morning-fetch alarm Reverts part of the previous commit: the explicit refresh button and fetch-on-launch stay, but the user still wants the background 5am alarm so articles are fresh before the app is opened, not just the periodic hourly WorkManager job. --- .../java/org/terst/feedreader/ui/MainActivity.kt | 65 +++++++++++++++++++++- 1 file changed, 62 insertions(+), 3 deletions(-) (limited to 'app/src/main/java/org/terst/feedreader/ui') diff --git a/app/src/main/java/org/terst/feedreader/ui/MainActivity.kt b/app/src/main/java/org/terst/feedreader/ui/MainActivity.kt index 85bc2b3..dff9858 100644 --- a/app/src/main/java/org/terst/feedreader/ui/MainActivity.kt +++ b/app/src/main/java/org/terst/feedreader/ui/MainActivity.kt @@ -1,6 +1,12 @@ package org.terst.feedreader.ui +import android.app.AlarmManager +import android.content.Intent +import android.net.Uri +import android.os.Build import android.os.Bundle +import android.provider.Settings +import android.util.Log import android.webkit.CookieManager import androidx.activity.ComponentActivity import androidx.activity.compose.setContent @@ -16,9 +22,13 @@ import androidx.navigation.compose.composable import androidx.navigation.compose.rememberNavController import androidx.navigation.navArgument import org.terst.feedreader.work.FeedFetchWorker +import org.terst.feedreader.work.MorningFetchReceiver import java.net.URLDecoder import java.net.URLEncoder +private const val TAG = "MainActivity" +private const val KEY_REQUESTED_EXACT_ALARM = "requestedExactAlarmPermission" + const val UNREAD_FEED_ID = "__unread__" const val SAVED_FEED_ID = "__saved__" const val OLDER_FEED_ID = "__older__" @@ -32,10 +42,12 @@ fun decodeNavArg(value: String): String = URLDecoder.decode(value, "UTF-8") class MainActivity : ComponentActivity() { override fun onCreate(savedInstanceState: Bundle?) { super.onCreate(savedInstanceState) - // The only implicit fetch trigger left: a fresh cold launch. No periodic - // WorkManager job and no background alarm any more -- per user request, refreshing - // only ever happens here or from an explicit tap on the refresh button. + requestedExactAlarmPermission = savedInstanceState?.getBoolean(KEY_REQUESTED_EXACT_ALARM) ?: false + // A fresh cold launch always fetches immediately; the 5am alarm below is the only + // other trigger left (no periodic WorkManager job any more) -- otherwise refreshing + // only happens via an explicit tap on the refresh button. FeedFetchWorker.fetchNow(applicationContext) + maybeScheduleMorningFetch() // Explicit, even though it defaults on -- BrowserScreen relies on cookies set // during a site login surviving into the reader's later extraction requests. CookieManager.getInstance().setAcceptCookie(true) @@ -49,6 +61,53 @@ class MainActivity : ComponentActivity() { } } } + + // Re-checked on resume too, not just onCreate -- returning here from the "Alarms & + // reminders" Settings screen (below) is an onResume, not a fresh onCreate, and the + // alarm should get armed the moment permission is actually granted rather than + // needing a full app relaunch. + override fun onResume() { + super.onResume() + maybeScheduleMorningFetch() + } + + // onCreate's own onStart/onResume fires once automatically as part of normal startup, + // right after onCreate -- before the user has done anything -- so without this guard, + // a not-yet-granted permission would launch the Settings screen twice back to back + // (once from onCreate, immediately again from that auto-triggered onResume). Restored + // from savedInstanceState in onCreate (see below), not left as a plain field that + // silently resets to false on every config change -- a rotation while still ungranted + // used to re-trigger the Settings screen every time the device rotated. + private var requestedExactAlarmPermission = false + + override fun onSaveInstanceState(outState: Bundle) { + super.onSaveInstanceState(outState) + outState.putBoolean(KEY_REQUESTED_EXACT_ALARM, requestedExactAlarmPermission) + } + + // Runs unconditionally on every onCreate/onResume -- must never let an exception + // escape from here, or a device/OEM quirk around the exact-alarm APIs would crash + // the app on every single launch. A wake-up alarm failing to schedule just isn't + // worth that; worst case it's logged and tries again next launch. + private fun maybeScheduleMorningFetch() { + try { + val alarmManager = getSystemService(AlarmManager::class.java) ?: return + val canScheduleExact = Build.VERSION.SDK_INT < Build.VERSION_CODES.S || alarmManager.canScheduleExactAlarms() + if (canScheduleExact) { + MorningFetchReceiver.scheduleNext(applicationContext) + } else if (!requestedExactAlarmPermission) { + requestedExactAlarmPermission = true + // Android 12+ only: exact alarms require a one-time user grant via Settings, + // there's no in-app permission dialog for this one. Sends the user straight to + // this app's page in the "Alarms & reminders" settings screen. + startActivity( + Intent(Settings.ACTION_REQUEST_SCHEDULE_EXACT_ALARM, Uri.parse("package:$packageName")) + ) + } + } catch (e: Exception) { + Log.e(TAG, "Failed to schedule or request permission for morning fetch", e) + } + } } @Composable -- cgit v1.2.3