From 06450fe69ade2928deb9274bb67b7ba60d394b4f Mon Sep 17 00:00:00 2001 From: Peter Stone Date: Thu, 6 Aug 2026 18:19:27 +0000 Subject: Remove the feature toggle system (dead code) Audited it (couldn't query the live DB directly -- auto-mode classifier blocks direct production reads without prior approval -- so this is a code-only audit): GetFeatureToggles/SetFeatureEnabled/IsFeatureEnabled/ CreateFeatureToggle/DeleteFeatureToggle had exactly one caller each, all inside their own CRUD handlers. Nothing anywhere else in the codebase read a toggle's Enabled state to gate any actual behavior -- confirmed by grepping every remaining .Enabled/IsFeatureEnabled reference back to either this dead code or its own tests. It was pure UI-managed CRUD with no consumer, unlike Trusted Agents (wired into agent.go/websocket.go) or Data Sources (wired into the sync pipeline) which stayed. Removes the Settings page section, the three /settings/features* routes and handlers, the five Store methods, the FeatureToggle model, and adds 028_drop_feature_toggles.sql (next free migration number, per this repo's convention of never renumbering -- see 021_drop_tasks.sql for the same drop-table-forward pattern) to drop the now-unused table. Also removed the now-dead tests for all of the above. go build ./... and go test ./... both clean. Co-Authored-By: Claude Sonnet 5 Claude-Session: https://claude.ai/code/session_01EZ7ikw2ukGJFTHE3bJS7zL --- migrations/028_drop_feature_toggles.sql | 4 ++++ 1 file changed, 4 insertions(+) create mode 100644 migrations/028_drop_feature_toggles.sql (limited to 'migrations') diff --git a/migrations/028_drop_feature_toggles.sql b/migrations/028_drop_feature_toggles.sql new file mode 100644 index 0000000..dacb8f3 --- /dev/null +++ b/migrations/028_drop_feature_toggles.sql @@ -0,0 +1,4 @@ +-- The feature toggle system (012_feature_toggles.sql) never gated any actual +-- behavior -- nothing in the codebase read a toggle's enabled state outside +-- of its own CRUD handlers. Dead weight, removed from Settings. +DROP TABLE IF EXISTS feature_toggles; -- cgit v1.2.3