From 6431cad59bda3da4bafb58fdf91f6a946e42af43 Mon Sep 17 00:00:00 2001 From: Peter Stone Date: Sun, 20 Sep 2026 17:44:02 +0000 Subject: Surface a dead OAuth grant instead of reporting it as connected MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit With the cancelled-context bug fixed, the refresh actually reaches Google and the real state of the Google Tasks grant becomes visible: it answers invalid_grant. The stored refresh token has been dead since roughly 2026-08-16. The earlier bug had been masking this — the refresh never got far enough to be rejected. Settings treated the presence of a token row as "Connected", so it reported Google Tasks as connected for a month while every fetch failed. A refresh failure is now persisted (migration 035 adds last_error/last_error_at to oauth_tokens) and cleared on the next success, and settings reports "connected" only when there is no recorded failure. invalid_grant is classified specially, because it is the one failure retrying cannot fix: the message tells the user to reconnect, and notes that a weekly recurrence means the OAuth client is still in Testing publishing status, where Google expires refresh tokens after seven days. Other errors — a network blip, a 5xx — are left as transient rather than pushing the user through consent needlessly. Reconnecting at /settings is still a manual step; nothing here can perform consent on the user's behalf. Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_018AwnALZL6bD4VBtATDVv3B --- migrations/README.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'migrations/README.md') diff --git a/migrations/README.md b/migrations/README.md index 07320af..0382065 100644 --- a/migrations/README.md +++ b/migrations/README.md @@ -30,10 +30,11 @@ Migrations are applied automatically on application startup via `store.RunMigrat | 032 | `032_import_trello_shopping_items.sql` | One-time import of Trello Shopping-board cards (Hardware Store + unlisted) into user items, ahead of removing Trello as a shopping source | | 033 | `033_ics_feeds.sql` | Subscribed iCalendar (.ics) feeds, merged into calendar_events | | 034 | `034_shopping_stores_and_sections.sql` | Store/section registry + `user_shopping_items.section` | +| 035 | `035_oauth_token_errors.sql` | Persist why an OAuth refresh failed, so settings can say "reconnect" | ## Creating New Migrations -1. Create file: `migrations/NNN_description.sql` (next number is 035) +1. Create file: `migrations/NNN_description.sql` (next number is 036) 2. Write idempotent SQL (use `IF NOT EXISTS` where possible) 3. Test locally: `go run cmd/dashboard/main.go` 4. Verify: Check `schema_migrations` table for new entry -- cgit v1.2.3