From aa5d0e4bf849625ab6876129950c71992ea322b8 Mon Sep 17 00:00:00 2001 From: Peter Stone Date: Wed, 15 Jul 2026 02:15:00 +0000 Subject: chore: remove dead IsRecurring field and its always-false branch Task.IsRecurring/Atom.IsRecurring were never assigned anywhere in the codebase (confirmed via full-repo search), so PartitionAtomsByTime's "hide future recurring tasks until due" branch was permanently dead. RecurrenceSeriesID is the real recurring indicator now; wiring up "hide future recurring successors" as an actual feature is a separate design decision, not part of this cleanup pass. Co-Authored-By: Claude Sonnet 5 Claude-Session: https://claude.ai/code/session_01VTUSAEKfsPc6WGDq45yPHD --- internal/handlers/atoms.go | 5 ----- internal/models/atom.go | 1 - internal/models/types.go | 4 +--- 3 files changed, 1 insertion(+), 9 deletions(-) (limited to 'internal') diff --git a/internal/handlers/atoms.go b/internal/handlers/atoms.go index fe092a3..9474150 100644 --- a/internal/handlers/atoms.go +++ b/internal/handlers/atoms.go @@ -91,13 +91,8 @@ func SortAtomsByUrgency(atoms []models.Atom) { } // PartitionAtomsByTime separates atoms into current and future lists -// Recurring tasks that are future are excluded entirely func PartitionAtomsByTime(atoms []models.Atom) (current, future []models.Atom) { for _, a := range atoms { - // Don't show recurring tasks until the day they're due - if a.IsRecurring && a.IsFuture { - continue - } if a.IsFuture { future = append(future, a) } else { diff --git a/internal/models/atom.go b/internal/models/atom.go index 21d30a6..bcf3c78 100644 --- a/internal/models/atom.go +++ b/internal/models/atom.go @@ -42,7 +42,6 @@ type Atom struct { IsOverdue bool // True if due date is before today IsFuture bool // True if due date is after today HasSetTime bool // True if due time is not midnight (has specific time) - IsRecurring bool // True if this is a recurring task // Original Data (for write operations) Raw interface{} diff --git a/internal/models/types.go b/internal/models/types.go index f74d264..fdde455 100644 --- a/internal/models/types.go +++ b/internal/models/types.go @@ -19,11 +19,9 @@ type Task struct { Labels []string `json:"labels"` URL string `json:"url"` CreatedAt time.Time `json:"created_at"` - IsRecurring bool `json:"is_recurring"` // Recurrence (doot-native tasks only). RecurrenceSeriesID != "" is the - // real "is this task recurring" indicator -- IsRecurring above predates - // this feature and is never set by it. + // indicator that a task is recurring. RecurrenceFreq string `json:"recurrence_freq,omitempty"` RecurrenceInterval int `json:"recurrence_interval,omitempty"` RecurrenceWeekdays []int `json:"recurrence_weekdays,omitempty"` -- cgit v1.2.3