From a38abc90ee4fe00bf0fbdf897c5ef93e80e0c256 Mon Sep 17 00:00:00 2001 From: Peter Stone Date: Mon, 19 Jan 2026 09:54:42 -1000 Subject: Refactor: Add cache key constants and configurable template path Code quality improvements: - Define CacheKey* constants in store package for type safety - Add TemplateDir to config (default: web/templates, env: TEMPLATE_DIR) - Update handlers to use store.CacheKey* instead of hardcoded strings - Update NewTabsHandler to accept templateDir parameter - Use filepath.Join for cross-platform template path construction Co-Authored-By: Claude Opus 4.5 --- internal/handlers/tabs.go | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'internal/handlers/tabs.go') diff --git a/internal/handlers/tabs.go b/internal/handlers/tabs.go index 74dfbe8..ffdabb0 100644 --- a/internal/handlers/tabs.go +++ b/internal/handlers/tabs.go @@ -4,6 +4,7 @@ import ( "html/template" "log" "net/http" + "path/filepath" "sort" "strings" "time" @@ -31,15 +32,15 @@ type TabsHandler struct { } // NewTabsHandler creates a new TabsHandler instance -func NewTabsHandler(store *store.Store) *TabsHandler { +func NewTabsHandler(store *store.Store, templateDir string) *TabsHandler { // Parse templates including partials - tmpl, err := template.ParseGlob("web/templates/*.html") + tmpl, err := template.ParseGlob(filepath.Join(templateDir, "*.html")) if err != nil { log.Printf("Warning: failed to parse templates: %v", err) } // Also parse partials - tmpl, err = tmpl.ParseGlob("web/templates/partials/*.html") + tmpl, err = tmpl.ParseGlob(filepath.Join(templateDir, "partials", "*.html")) if err != nil { log.Printf("Warning: failed to parse partial templates: %v", err) } -- cgit v1.2.3