From 5f4f59fc6302a4e44773d4a939ae7b3304d61f1f Mon Sep 17 00:00:00 2001 From: Claude Agent Date: Wed, 18 Mar 2026 10:09:41 +0000 Subject: refactor: RF-04/08 migrate inline HTML to templates, standardize form parsing RF-04: Already complete in codebase (handlers use HTMLResponse + partials). RF-08: Migrate single-required-field handlers from Pattern A/B to Pattern C (requireFormValue). Affected: HandleCompleteTask, HandleCompleteCard, HandleReportBug, HandleCreateTask in handlers.go; HandleToggleFeature, HandleCreateFeature in settings.go. Reduces 6-8 lines of boilerplate to 2. Co-Authored-By: Claude Sonnet 4.6 --- internal/handlers/settings.go | 22 ++++------------------ 1 file changed, 4 insertions(+), 18 deletions(-) (limited to 'internal/handlers/settings.go') diff --git a/internal/handlers/settings.go b/internal/handlers/settings.go index c0ba654..a780170 100644 --- a/internal/handlers/settings.go +++ b/internal/handlers/settings.go @@ -196,19 +196,12 @@ func (h *Handler) HandleGetSourceOptions(w http.ResponseWriter, r *http.Request) // HandleToggleFeature toggles a feature flag func (h *Handler) HandleToggleFeature(w http.ResponseWriter, r *http.Request) { - if err := r.ParseForm(); err != nil { - JSONError(w, http.StatusBadRequest, "Failed to parse form", err) + name, ok := requireFormValue(w, r, "name") + if !ok { return } - - name := r.FormValue("name") enabled := r.FormValue("enabled") == "true" - if name == "" { - JSONError(w, http.StatusBadRequest, "Feature name required", nil) - return - } - if err := h.store.SetFeatureEnabled(name, enabled); err != nil { JSONError(w, http.StatusInternalServerError, "Failed to update feature", err) return @@ -220,19 +213,12 @@ func (h *Handler) HandleToggleFeature(w http.ResponseWriter, r *http.Request) { // HandleCreateFeature creates a new feature toggle func (h *Handler) HandleCreateFeature(w http.ResponseWriter, r *http.Request) { - if err := r.ParseForm(); err != nil { - JSONError(w, http.StatusBadRequest, "Failed to parse form", err) + name, ok := requireFormValue(w, r, "name") + if !ok { return } - - name := r.FormValue("name") description := r.FormValue("description") - if name == "" { - JSONError(w, http.StatusBadRequest, "Feature name required", nil) - return - } - if err := h.store.CreateFeatureToggle(name, description, false); err != nil { JSONError(w, http.StatusInternalServerError, "Failed to create feature", err) return -- cgit v1.2.3