1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
|
package executor
import (
"context"
"fmt"
"io"
"log/slog"
"os"
"os/exec"
"strings"
"testing"
"github.com/thepeterstone/claudomator/internal/storage"
"github.com/thepeterstone/claudomator/internal/task"
)
func TestContainerRunner_BuildDockerArgs(t *testing.T) {
runner := &ContainerRunner{
APIURL: "http://localhost:8484",
DropsDir: "/data/drops",
SSHAuthSock: "/tmp/ssh.sock",
}
workspace := "/tmp/ws"
taskID := "task-123"
args := runner.buildDockerArgs(workspace, taskID)
expected := []string{
"run", "--rm",
"-v", "/tmp/ws:/workspace",
"-w", "/workspace",
"--env-file", "/tmp/ws/.claudomator-env",
"-e", "CLAUDOMATOR_API_URL=http://localhost:8484",
"-e", "CLAUDOMATOR_TASK_ID=task-123",
"-e", "CLAUDOMATOR_DROP_DIR=/data/drops",
"-v", "/tmp/ssh.sock:/tmp/ssh-auth.sock",
"-e", "SSH_AUTH_SOCK=/tmp/ssh-auth.sock",
}
if len(args) != len(expected) {
t.Fatalf("expected %d args, got %d. Got: %v", len(expected), len(args), args)
}
for i, v := range args {
if v != expected[i] {
t.Errorf("arg %d: expected %q, got %q", i, expected[i], v)
}
}
}
func TestContainerRunner_BuildInnerCmd(t *testing.T) {
runner := &ContainerRunner{}
t.Run("claude-fresh", func(t *testing.T) {
tk := &task.Task{Agent: task.AgentConfig{Type: "claude"}}
exec := &storage.Execution{}
cmd := runner.buildInnerCmd(tk, exec, false)
cmdStr := strings.Join(cmd, " ")
if strings.Contains(cmdStr, "--resume") {
t.Errorf("unexpected --resume flag in fresh run: %q", cmdStr)
}
if !strings.Contains(cmdStr, "INST=$(cat /workspace/.claudomator-instructions.txt); claude -p \"$INST\"") {
t.Errorf("expected cat instructions in sh command, got %q", cmdStr)
}
})
t.Run("claude-resume", func(t *testing.T) {
tk := &task.Task{Agent: task.AgentConfig{Type: "claude"}}
exec := &storage.Execution{ResumeSessionID: "orig-session-123"}
cmd := runner.buildInnerCmd(tk, exec, true)
cmdStr := strings.Join(cmd, " ")
if !strings.Contains(cmdStr, "--resume orig-session-123") {
t.Errorf("expected --resume flag with correct session ID, got %q", cmdStr)
}
})
t.Run("gemini", func(t *testing.T) {
tk := &task.Task{Agent: task.AgentConfig{Type: "gemini"}}
exec := &storage.Execution{}
cmd := runner.buildInnerCmd(tk, exec, false)
cmdStr := strings.Join(cmd, " ")
if !strings.Contains(cmdStr, "gemini -p \"$INST\"") {
t.Errorf("expected gemini command with safer quoting, got %q", cmdStr)
}
})
t.Run("custom-binaries", func(t *testing.T) {
runnerCustom := &ContainerRunner{
ClaudeBinary: "/usr/bin/claude-v2",
GeminiBinary: "/usr/local/bin/gemini-pro",
}
tkClaude := &task.Task{Agent: task.AgentConfig{Type: "claude"}}
cmdClaude := runnerCustom.buildInnerCmd(tkClaude, &storage.Execution{}, false)
if !strings.Contains(strings.Join(cmdClaude, " "), "/usr/bin/claude-v2 -p") {
t.Errorf("expected custom claude binary, got %q", cmdClaude)
}
tkGemini := &task.Task{Agent: task.AgentConfig{Type: "gemini"}}
cmdGemini := runnerCustom.buildInnerCmd(tkGemini, &storage.Execution{}, false)
if !strings.Contains(strings.Join(cmdGemini, " "), "/usr/local/bin/gemini-pro -p") {
t.Errorf("expected custom gemini binary, got %q", cmdGemini)
}
})
}
func TestContainerRunner_Run_PreservesWorkspaceOnFailure(t *testing.T) {
logger := slog.New(slog.NewTextHandler(io.Discard, nil))
runner := &ContainerRunner{
Logger: logger,
Image: "busybox",
Command: func(ctx context.Context, name string, arg ...string) *exec.Cmd {
// Mock docker run to exit 1
if name == "docker" {
return exec.Command("sh", "-c", "exit 1")
}
// Mock git clone to succeed and create the directory
if name == "git" && len(arg) > 0 && arg[0] == "clone" {
dir := arg[len(arg)-1]
os.MkdirAll(dir, 0755)
return exec.Command("true")
}
return exec.Command("true")
},
}
tk := &task.Task{
ID: "test-task",
RepositoryURL: "https://github.com/example/repo.git",
Agent: task.AgentConfig{Type: "claude"},
}
exec := &storage.Execution{ID: "test-exec", TaskID: "test-task"}
err := runner.Run(context.Background(), tk, exec)
if err == nil {
t.Fatal("expected error due to mocked docker failure")
}
// Verify SandboxDir was set and directory exists.
if exec.SandboxDir == "" {
t.Fatal("expected SandboxDir to be set even on failure")
}
if _, statErr := os.Stat(exec.SandboxDir); statErr != nil {
t.Errorf("expected sandbox directory to be preserved, but stat failed: %v", statErr)
} else {
os.RemoveAll(exec.SandboxDir)
}
}
func TestBlockedError_IncludesSandboxDir(t *testing.T) {
// This test requires mocking 'docker run' or the whole Run() which is hard.
// But we can test that returning BlockedError works.
err := &BlockedError{
QuestionJSON: `{"text":"?"}`,
SessionID: "s1",
SandboxDir: "/tmp/s1",
}
if !strings.Contains(err.Error(), "task blocked") {
t.Errorf("wrong error message: %v", err)
}
}
func TestIsCompletionReport(t *testing.T) {
tests := []struct {
name string
json string
expected bool
}{
{
name: "real question with options",
json: `{"text": "Should I proceed with implementation?", "options": ["Yes", "No"]}`,
expected: false,
},
{
name: "real question no options",
json: `{"text": "Which approach do you prefer?"}`,
expected: false,
},
{
name: "completion report no options no question mark",
json: `{"text": "All tests pass. Implementation complete. Summary written to CLAUDOMATOR_SUMMARY_FILE."}`,
expected: true,
},
{
name: "completion report with empty options",
json: `{"text": "Feature implemented and committed.", "options": []}`,
expected: true,
},
{
name: "invalid json treated as not a report",
json: `not json`,
expected: false,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
got := isCompletionReport(tt.json)
if got != tt.expected {
t.Errorf("isCompletionReport(%q) = %v, want %v", tt.json, got, tt.expected)
}
})
}
}
func TestTailFile_ReturnsLastNLines(t *testing.T) {
f, err := os.CreateTemp("", "tailfile-*")
if err != nil {
t.Fatal(err)
}
defer os.Remove(f.Name())
for i := 1; i <= 30; i++ {
fmt.Fprintf(f, "line %d\n", i)
}
f.Close()
got := tailFile(f.Name(), 5)
lines := strings.Split(strings.TrimSpace(got), "\n")
if len(lines) != 5 {
t.Fatalf("want 5 lines, got %d: %q", len(lines), got)
}
if lines[0] != "line 26" || lines[4] != "line 30" {
t.Errorf("want lines 26-30, got: %q", got)
}
}
func TestGitSafe_PrependsSafeDirectory(t *testing.T) {
got := gitSafe("-C", "/some/path", "status")
want := []string{"-c", "safe.directory=*", "-C", "/some/path", "status"}
if len(got) != len(want) {
t.Fatalf("gitSafe() = %v, want %v", got, want)
}
for i := range want {
if got[i] != want[i] {
t.Errorf("gitSafe()[%d] = %q, want %q", i, got[i], want[i])
}
}
}
|
