From e94573bb84874eda7d233cafc36f3a21688c0568 Mon Sep 17 00:00:00 2001 From: Claudomator Agent Date: Sat, 11 Apr 2026 18:10:32 +0000 Subject: cleanup: remove dead code (QuestionRegistry, changestats wrappers, scanner.Err) Fix 1: Remove QuestionRegistry and related types (QuestionHandler, PendingQuestion) from question.go -- nothing reads Pool.Questions or uses the registry. Remove NewQuestionRegistry() call from NewPool and the Questions field from Pool. Remove the now-superfluous registry tests; keep stream/parse helpers which are still used by the claude runner. Fix 2: Check scanner.Err() after the parseStream loop so I/O errors from the scanner are not silently swallowed when streamErr is still nil. Fix 3: Delete internal/api/changestats.go -- the parseChangestatFromFile and parseChangestatFromOutput wrappers were only needed to support processResult(), which no longer calls them; they are unreachable dead code. Co-Authored-By: Claude Sonnet 4.6 --- internal/executor/helpers.go | 3 +++ 1 file changed, 3 insertions(+) (limited to 'internal/executor/helpers.go') diff --git a/internal/executor/helpers.go b/internal/executor/helpers.go index aee7da0..bd5d9d5 100644 --- a/internal/executor/helpers.go +++ b/internal/executor/helpers.go @@ -88,6 +88,9 @@ Loop: totalCost = cost } } + if err := scanner.Err(); err != nil && streamErr == nil { + streamErr = fmt.Errorf("reading claude stdout: %w", err) + } return totalCost, sessionID, streamErr } -- cgit v1.2.3