From e94573bb84874eda7d233cafc36f3a21688c0568 Mon Sep 17 00:00:00 2001 From: Claudomator Agent Date: Sat, 11 Apr 2026 18:10:32 +0000 Subject: cleanup: remove dead code (QuestionRegistry, changestats wrappers, scanner.Err) Fix 1: Remove QuestionRegistry and related types (QuestionHandler, PendingQuestion) from question.go -- nothing reads Pool.Questions or uses the registry. Remove NewQuestionRegistry() call from NewPool and the Questions field from Pool. Remove the now-superfluous registry tests; keep stream/parse helpers which are still used by the claude runner. Fix 2: Check scanner.Err() after the parseStream loop so I/O errors from the scanner are not silently swallowed when streamErr is still nil. Fix 3: Delete internal/api/changestats.go -- the parseChangestatFromFile and parseChangestatFromOutput wrappers were only needed to support processResult(), which no longer calls them; they are unreachable dead code. Co-Authored-By: Claude Sonnet 4.6 --- internal/executor/executor.go | 2 -- 1 file changed, 2 deletions(-) (limited to 'internal/executor/executor.go') diff --git a/internal/executor/executor.go b/internal/executor/executor.go index ac528c6..8257f31 100644 --- a/internal/executor/executor.go +++ b/internal/executor/executor.go @@ -84,7 +84,6 @@ type Pool struct { doneCh chan struct{} // signals when a worker slot is freed workerWg sync.WaitGroup // tracks in-flight execute/executeResume goroutines dispatchDone chan struct{} // closed when the dispatch goroutine exits - Questions *QuestionRegistry Classifier *Classifier } @@ -116,7 +115,6 @@ func NewPool(maxConcurrent int, runners map[string]Runner, store Store, logger * workCh: make(chan workItem, maxConcurrent*10+100), doneCh: make(chan struct{}, maxConcurrent), dispatchDone: make(chan struct{}), - Questions: NewQuestionRegistry(), } go p.dispatch() return p -- cgit v1.2.3