From 888f3014b42ff48f597d0a81e9f52104d19be6db Mon Sep 17 00:00:00 2001
From: Peter Stone <thepeterstone@gmail.com>
Date: Sat, 21 Mar 2026 21:23:42 +0000
Subject: feat: Phase 2 — project registry, legacy field cleanup, credential
 path fix
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- task.Project type + storage CRUD + UpsertProject + SeedProjects
- Remove AgentConfig.ProjectDir, RepositoryURL, SkipPlanning
- Remove ContainerRunner fallback git init logic
- Project API endpoints: GET/POST /api/projects, GET/PUT /api/projects/{id}
- processResult no longer extracts changestats (pool-side only)
- claude_config_dir config field; default to credentials/claude/
- New scripts: sync-credentials, fix-permissions, check-token

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---
 internal/api/server_test.go | 72 ++++++++++++++++++++++++++++++++++-----------
 1 file changed, 55 insertions(+), 17 deletions(-)

(limited to 'internal/api/server_test.go')

diff --git a/internal/api/server_test.go b/internal/api/server_test.go
index 8ff4227..27fc645 100644
--- a/internal/api/server_test.go
+++ b/internal/api/server_test.go
@@ -1641,34 +1641,31 @@ func TestRunTask_AgentCancelled_TaskSetToCancelled(t *testing.T) {
 	}
 }
 
-// TestGetTask_IncludesChangestats verifies that after processResult parses git diff stats
-// from the execution stdout log, they appear in the execution history response.
+// TestGetTask_IncludesChangestats verifies that changestats stored on an execution
+// are returned correctly by GET /api/tasks/{id}/executions.
 func TestGetTask_IncludesChangestats(t *testing.T) {
 	srv, store := testServer(t)
 
 	tk := createTaskWithState(t, store, "cs-task-1", task.StateCompleted)
 
-	// Write a stdout log with a git diff --stat summary line.
-	dir := t.TempDir()
-	stdoutPath := filepath.Join(dir, "stdout.log")
-	logContent := "Agent output line 1\n3 files changed, 50 insertions(+), 10 deletions(-)\nAgent output line 2\n"
-	if err := os.WriteFile(stdoutPath, []byte(logContent), 0600); err != nil {
-		t.Fatal(err)
-	}
-
 	exec := &storage.Execution{
-		ID:         "cs-exec-1",
-		TaskID:     tk.ID,
-		StartTime:  time.Now().UTC(),
-		EndTime:    time.Now().UTC().Add(time.Minute),
-		Status:     "COMPLETED",
-		StdoutPath: stdoutPath,
+		ID:        "cs-exec-1",
+		TaskID:    tk.ID,
+		StartTime: time.Now().UTC(),
+		EndTime:   time.Now().UTC().Add(time.Minute),
+		Status:    "COMPLETED",
 	}
 	if err := store.CreateExecution(exec); err != nil {
 		t.Fatal(err)
 	}
 
-	// processResult should parse changestats from the stdout log and store them.
+	// Pool stores changestats after execution; simulate by calling UpdateExecutionChangestats directly.
+	cs := &task.Changestats{FilesChanged: 3, LinesAdded: 50, LinesRemoved: 10}
+	if err := store.UpdateExecutionChangestats(exec.ID, cs); err != nil {
+		t.Fatal(err)
+	}
+
+	// processResult broadcasts but does NOT parse changestats (that's the pool's job).
 	result := &executor.Result{
 		TaskID:    tk.ID,
 		Execution: exec,
@@ -1976,3 +1973,44 @@ func TestListTasks_NonReadyTask_OmitsDeploymentStatus(t *testing.T) {
 		t.Error("PENDING task should not include deployment_status field")
 	}
 }
+
+func TestProjects_CRUD(t *testing.T) {
+	srv, _ := testServer(t)
+
+	// Create
+	body := `{"name":"testproj","local_path":"/workspace/testproj","type":"web"}`
+	req := httptest.NewRequest("POST", "/api/projects", strings.NewReader(body))
+	req.Header.Set("Content-Type", "application/json")
+	w := httptest.NewRecorder()
+	srv.Handler().ServeHTTP(w, req)
+	if w.Code != http.StatusCreated {
+		t.Fatalf("POST /api/projects: want 201, got %d; body: %s", w.Code, w.Body.String())
+	}
+	var created map[string]interface{}
+	json.NewDecoder(w.Body).Decode(&created)
+	id, _ := created["id"].(string)
+	if id == "" {
+		t.Fatal("created project has no id")
+	}
+
+	// Get
+	req = httptest.NewRequest("GET", "/api/projects/"+id, nil)
+	w = httptest.NewRecorder()
+	srv.Handler().ServeHTTP(w, req)
+	if w.Code != http.StatusOK {
+		t.Fatalf("GET /api/projects/%s: want 200, got %d", id, w.Code)
+	}
+
+	// List
+	req = httptest.NewRequest("GET", "/api/projects", nil)
+	w = httptest.NewRecorder()
+	srv.Handler().ServeHTTP(w, req)
+	if w.Code != http.StatusOK {
+		t.Fatalf("GET /api/projects: want 200, got %d", w.Code)
+	}
+	var list []interface{}
+	json.NewDecoder(w.Body).Decode(&list)
+	if len(list) == 0 {
+		t.Error("expected at least one project in list")
+	}
+}
-- 
cgit v1.2.3