From 0eb0b79396663c4901597becc6857a4cd795c58e Mon Sep 17 00:00:00 2001 From: Claudomator Agent Date: Fri, 5 Jun 2026 09:21:32 +0000 Subject: chore: remove stories/checker backend dead code Remove the dead stories/checker backend tracked as design debt in CLAUDE.md: - Delete internal/api/stories.go, stories_test.go, elaborate.go - Delete internal/task/story.go, story_test.go - Remove story/checker columns from storage schema and all CRUD methods - Remove checkStoryCompletion, spawnCheckerTask, triggerStoryDeploy, createValidationTask, checkValidationResult, ShipStory, CheckStoryCompletion from executor; simplify handleRunResult - Remove story/checker fields from task.Task (StoryID, AcceptanceCriteria, CheckerForTaskID, CheckerReport) - Remove story routes and geminiBinPath from API server - Move claudeJSONResult/extractJSON from elaborate.go to validate.go - Rename ensureStoryBranch -> ensureBranch in ContainerRunner - Fix git identity in bare-repo tests; fix initial-branch to use main Co-Authored-By: Claude Sonnet 4.6 --- internal/api/server_test.go | 51 ++------------------------------------------- 1 file changed, 2 insertions(+), 49 deletions(-) (limited to 'internal/api/server_test.go') diff --git a/internal/api/server_test.go b/internal/api/server_test.go index 43d91b0..24e1d30 100644 --- a/internal/api/server_test.go +++ b/internal/api/server_test.go @@ -98,7 +98,7 @@ func testServerWithRunner(t *testing.T, runner executor.Runner) (*Server, *stora "gemini": runner, } pool := executor.NewPool(2, runners, store, logger) - srv := NewServer(store, pool, nil, logger, "claude", "gemini") + srv := NewServer(store, pool, nil, logger, "claude") return srv, store } @@ -194,7 +194,7 @@ func testServerWithGeminiMockRunner(t *testing.T) (*Server, *storage.DB) { "gemini": mr, } pool := executor.NewPool(2, runners, store, logger) - srv := NewServer(store, pool, nil, logger, "claude", "gemini") + srv := NewServer(store, pool, nil, logger, "claude") return srv, store } @@ -2069,50 +2069,3 @@ func TestHandleRunTask_CascadesRetryToFailedDeps(t *testing.T) { } } -func TestShipStory_ShippableStory_Returns202(t *testing.T) { - srv, store := testServer(t) - - proj := &task.Project{ - ID: "ship-proj-1", Name: "test", RemoteURL: "https://github.com/x/y", - Type: "web", DeployScript: "", - } - if err := store.CreateProject(proj); err != nil { - t.Fatalf("CreateProject: %v", err) - } - - story := &task.Story{ - ID: "ship-story-1", Name: "Ship Test", ProjectID: "ship-proj-1", - Status: task.StoryShippable, CreatedAt: time.Now().UTC(), UpdatedAt: time.Now().UTC(), - } - if err := store.CreateStory(story); err != nil { - t.Fatalf("CreateStory: %v", err) - } - - req := httptest.NewRequest("POST", "/api/stories/ship-story-1/ship", nil) - w := httptest.NewRecorder() - srv.Handler().ServeHTTP(w, req) - - if w.Code != http.StatusAccepted { - t.Errorf("expected 202, got %d: %s", w.Code, w.Body.String()) - } -} - -func TestShipStory_NonShippable_Returns409(t *testing.T) { - srv, store := testServer(t) - - story := &task.Story{ - ID: "nonship-1", Name: "Not Ready", ProjectID: "", - Status: task.StoryInProgress, CreatedAt: time.Now().UTC(), UpdatedAt: time.Now().UTC(), - } - if err := store.CreateStory(story); err != nil { - t.Fatalf("CreateStory: %v", err) - } - - req := httptest.NewRequest("POST", "/api/stories/nonship-1/ship", nil) - w := httptest.NewRecorder() - srv.Handler().ServeHTTP(w, req) - - if w.Code != http.StatusConflict { - t.Errorf("expected 409, got %d", w.Code) - } -} -- cgit v1.2.3