diff options
Diffstat (limited to 'internal/executor/executor.go')
| -rw-r--r-- | internal/executor/executor.go | 15 |
1 files changed, 13 insertions, 2 deletions
diff --git a/internal/executor/executor.go b/internal/executor/executor.go index 8257f31..384a323 100644 --- a/internal/executor/executor.go +++ b/internal/executor/executor.go @@ -543,6 +543,12 @@ func (p *Pool) handleRunResult(ctx context.Context, t *task.Task, exec *storage. // a terminal success state and transitions the story to SHIPPABLE if so. // Subtasks are intentionally excluded — a parent task reaching READY/COMPLETED // already accounts for its subtasks. +// CheckStoryCompletion is the exported entry point for story completion checks +// called from outside the package (e.g. the API accept handler). +func (p *Pool) CheckStoryCompletion(ctx context.Context, storyID string) { + p.checkStoryCompletion(ctx, storyID) +} + func (p *Pool) checkStoryCompletion(ctx context.Context, storyID string) { story, err := p.store.GetStory(storyID) if err != nil { @@ -566,8 +572,8 @@ func (p *Pool) checkStoryCompletion(ctx context.Context, storyID string) { continue // subtasks are covered by their parent } topLevelCount++ - if t.State != task.StateCompleted && t.State != task.StateReady { - return // not all top-level tasks done + if t.State != task.StateCompleted { + return // not all top-level tasks done; READY alone is not sufficient (checker may be pending) } } if topLevelCount == 0 { @@ -1251,6 +1257,11 @@ func (p *Pool) maybeUnblockParent(parentID string) { p.logger.Error("maybeUnblockParent: list subtasks", "parentID", parentID, "error", err) return } + // A task with no subtasks was never blocked by subtask delegation — don't promote it. + // This prevents incorrectly promoting leaf tasks that are stuck in QUEUED to READY. + if len(subtasks) == 0 { + return + } for _, sub := range subtasks { if sub.State != task.StateCompleted { return |