diff options
Diffstat (limited to 'internal/api')
| -rw-r--r-- | internal/api/agentmcp_endpoint_test.go | 3 | ||||
| -rw-r--r-- | internal/api/server.go | 9 | ||||
| -rw-r--r-- | internal/api/server_test.go | 58 |
3 files changed, 70 insertions, 0 deletions
diff --git a/internal/api/agentmcp_endpoint_test.go b/internal/api/agentmcp_endpoint_test.go index b9cee3a..7ea71aa 100644 --- a/internal/api/agentmcp_endpoint_test.go +++ b/internal/api/agentmcp_endpoint_test.go @@ -27,6 +27,9 @@ func (f *fakeAgentChannel) RecordProgress(_ context.Context, m string) error { f.progress = append(f.progress, m) return nil } +func (f *fakeAgentChannel) ProposeEpic(context.Context, executor.EpicProposal) (string, error) { + return "epic-1", nil +} type tokenRT struct { token string diff --git a/internal/api/server.go b/internal/api/server.go index 8bd5b0e..8d03021 100644 --- a/internal/api/server.go +++ b/internal/api/server.go @@ -9,6 +9,7 @@ import ( "log/slog" "net/http" "os" + "strconv" "strings" "time" @@ -520,6 +521,14 @@ func (s *Server) handleListTasks(w http.ResponseWriter, r *http.Request) { } filter.Since = t } + if nr := r.URL.Query().Get("needs_review"); nr != "" { + b, err := strconv.ParseBool(nr) + if err != nil { + writeJSON(w, http.StatusBadRequest, map[string]string{"error": "invalid needs_review: " + nr}) + return + } + filter.NeedsReview = &b + } tasks, err := s.store.ListTasks(filter) if err != nil { writeJSON(w, http.StatusInternalServerError, map[string]string{"error": err.Error()}) diff --git a/internal/api/server_test.go b/internal/api/server_test.go index 24e1d30..460c669 100644 --- a/internal/api/server_test.go +++ b/internal/api/server_test.go @@ -518,6 +518,64 @@ func TestListTasks_WithTasks(t *testing.T) { } } +// TestListTasks_NeedsReviewFilter proves GET /api/tasks?needs_review=true +// only returns tasks flagged needs_review (set by +// internal/scheduler.Scheduler's ask-user-timeout escalation). +func TestListTasks_NeedsReviewFilter(t *testing.T) { + srv, store := testServer(t) + + flagged := &task.Task{ + ID: "nr-1", Name: "flagged", + RepositoryURL: "https://github.com/user/repo", + Agent: task.AgentConfig{Type: "claude", Instructions: "x"}, Priority: task.PriorityNormal, + Retry: task.RetryConfig{MaxAttempts: 1, Backoff: "linear"}, + Tags: []string{}, DependsOn: []string{}, State: task.StatePending, + } + if err := store.CreateTask(flagged); err != nil { + t.Fatalf("CreateTask flagged: %v", err) + } + if err := store.UpdateTaskNeedsReview(flagged.ID, true); err != nil { + t.Fatalf("UpdateTaskNeedsReview: %v", err) + } + + notFlagged := &task.Task{ + ID: "nr-2", Name: "not flagged", + RepositoryURL: "https://github.com/user/repo", + Agent: task.AgentConfig{Type: "claude", Instructions: "x"}, Priority: task.PriorityNormal, + Retry: task.RetryConfig{MaxAttempts: 1, Backoff: "linear"}, + Tags: []string{}, DependsOn: []string{}, State: task.StatePending, + } + if err := store.CreateTask(notFlagged); err != nil { + t.Fatalf("CreateTask notFlagged: %v", err) + } + + req := httptest.NewRequest("GET", "/api/tasks?needs_review=true", nil) + w := httptest.NewRecorder() + srv.Handler().ServeHTTP(w, req) + + if w.Code != http.StatusOK { + t.Fatalf("status: want 200, got %d; body: %s", w.Code, w.Body.String()) + } + var tasks []task.Task + if err := json.NewDecoder(w.Body).Decode(&tasks); err != nil { + t.Fatalf("decode: %v", err) + } + if len(tasks) != 1 { + t.Fatalf("want 1 needs_review task, got %d: %+v", len(tasks), tasks) + } + if tasks[0].ID != "nr-1" || !tasks[0].NeedsReview { + t.Errorf("expected flagged task nr-1 with NeedsReview=true, got %+v", tasks[0]) + } + + // Sanity check: an invalid needs_review value is a 400, not a silent no-op. + req2 := httptest.NewRequest("GET", "/api/tasks?needs_review=notabool", nil) + w2 := httptest.NewRecorder() + srv.Handler().ServeHTTP(w2, req2) + if w2.Code != http.StatusBadRequest { + t.Errorf("invalid needs_review: want 400, got %d", w2.Code) + } +} + // stateWalkPaths defines the sequence of intermediate states needed to reach each target state. var stateWalkPaths = map[task.State][]task.State{ task.StatePending: {}, |
