feat: validation result transitions story to REVIEW_READY or NEEDS_FIX (ADR-007)

Add checkValidationResult which inspects the final task.State of a
completed validation task and updates the story to REVIEW_READY (pass)
or NEEDS_FIX (fail). Wire into handleRunResult so stories in
VALIDATING state are dispatched to checkValidationResult instead of
checkStoryCompletion, covering both success and FAILED terminal paths.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

2 files changed, 101 insertions, 1 deletions

diff --git a/internal/executor/executor.go b/internal/executor/executor.go
index 745c6d6..c5a1fce 100644
--- a/internal/executor/executor.go
+++ b/internal/executor/executor.go
@@ -376,6 +376,19 @@ func (p *Pool) handleRunResult(ctx context.Context, t *task.Task, exec *storage.
 				}
 			}
 		}
+		if t.StoryID != "" && exec.Status == "FAILED" {
+			storyID := t.StoryID
+			errMsg := exec.ErrorMsg
+			go func() {
+				story, getErr := p.store.GetStory(storyID)
+				if getErr != nil {
+					return
+				}
+				if story.Status == task.StoryValidating {
+					p.checkValidationResult(ctx, storyID, task.StateFailed, errMsg)
+				}
+			}()
+		}
 	} else {
 		p.mu.Lock()
 		p.consecutiveFailures[agentType] = 0
@@ -405,7 +418,19 @@ func (p *Pool) handleRunResult(ctx context.Context, t *task.Task, exec *storage.
 			p.maybeUnblockParent(t.ParentTaskID)
 		}
 		if t.StoryID != "" {
-			go p.checkStoryCompletion(ctx, t.StoryID)
+			storyID := t.StoryID
+			go func() {
+				story, getErr := p.store.GetStory(storyID)
+				if getErr != nil {
+					p.logger.Error("handleRunResult: failed to get story", "storyID", storyID, "error", getErr)
+					return
+				}
+				if story.Status == task.StoryValidating {
+					p.checkValidationResult(ctx, storyID, task.StateCompleted, "")
+				} else {
+					p.checkStoryCompletion(ctx, storyID)
+				}
+			}()
 		}
 	}
 
@@ -540,6 +565,24 @@ func (p *Pool) createValidationTask(ctx context.Context, storyID string) {
 	p.Submit(ctx, vtask) //nolint:errcheck
 }
 
+// checkValidationResult inspects a completed validation task and transitions
+// the story to REVIEW_READY or NEEDS_FIX accordingly.
+func (p *Pool) checkValidationResult(ctx context.Context, storyID string, taskState task.State, errorMsg string) {
+	if taskState == task.StateCompleted {
+		if err := p.store.UpdateStoryStatus(storyID, task.StoryReviewReady); err != nil {
+			p.logger.Error("checkValidationResult: failed to update story status", "storyID", storyID, "error", err)
+			return
+		}
+		p.logger.Info("story transitioned to REVIEW_READY", "storyID", storyID)
+	} else {
+		if err := p.store.UpdateStoryStatus(storyID, task.StoryNeedsFix); err != nil {
+			p.logger.Error("checkValidationResult: failed to update story status", "storyID", storyID, "error", err)
+			return
+		}
+		p.logger.Info("story transitioned to NEEDS_FIX", "storyID", storyID, "error", errorMsg)
+	}
+}
+
 // UndrainingAgent resets the drain state and failure counter for the given agent type.
 func (p *Pool) UndrainingAgent(agentType string) {
 	p.mu.Lock()
diff --git a/internal/executor/executor_test.go b/internal/executor/executor_test.go
index 9e39f14..15ce363 100644
--- a/internal/executor/executor_test.go
+++ b/internal/executor/executor_test.go
@@ -1858,3 +1858,60 @@ func TestPool_PostDeploy_CreatesValidationTask(t *testing.T) {
 		t.Errorf("task instructions %q do not reference validation spec content", vtask.Agent.Instructions)
 	}
 }
+
+func TestPool_ValidationTask_Pass_SetsReviewReady(t *testing.T) {
+	store := testStore(t)
+	logger := slog.New(slog.NewTextHandler(os.Stderr, &slog.HandlerOptions{Level: slog.LevelError}))
+	pool := NewPool(2, map[string]Runner{"claude": &mockRunner{}}, store, logger)
+
+	now := time.Now().UTC()
+	story := &task.Story{
+		ID:        "story-val-pass-1",
+		Name:      "Validation Pass",
+		Status:    task.StoryValidating,
+		CreatedAt: now,
+		UpdatedAt: now,
+	}
+	if err := store.CreateStory(story); err != nil {
+		t.Fatalf("CreateStory: %v", err)
+	}
+
+	pool.checkValidationResult(context.Background(), story.ID, task.StateCompleted, "")
+
+	got, err := store.GetStory(story.ID)
+	if err != nil {
+		t.Fatalf("GetStory: %v", err)
+	}
+	if got.Status != task.StoryReviewReady {
+		t.Errorf("story status: want REVIEW_READY, got %q", got.Status)
+	}
+}
+
+func TestPool_ValidationTask_Fail_SetsNeedsFix(t *testing.T) {
+	store := testStore(t)
+	logger := slog.New(slog.NewTextHandler(os.Stderr, &slog.HandlerOptions{Level: slog.LevelError}))
+	pool := NewPool(2, map[string]Runner{"claude": &mockRunner{}}, store, logger)
+
+	now := time.Now().UTC()
+	story := &task.Story{
+		ID:        "story-val-fail-1",
+		Name:      "Validation Fail",
+		Status:    task.StoryValidating,
+		CreatedAt: now,
+		UpdatedAt: now,
+	}
+	if err := store.CreateStory(story); err != nil {
+		t.Fatalf("CreateStory: %v", err)
+	}
+
+	execErr := "smoke test failed: /health returned 503"
+	pool.checkValidationResult(context.Background(), story.ID, task.StateFailed, execErr)
+
+	got, err := store.GetStory(story.ID)
+	if err != nil {
+		t.Fatalf("GetStory: %v", err)
+	}
+	if got.Status != task.StoryNeedsFix {
+		t.Errorf("story status: want NEEDS_FIX, got %q", got.Status)
+	}
+}