task: promote validTransitions to package-level var; fix ADR

Hoists the map out of ValidTransition so it's not reallocated on every
call. Adds missing CANCELLED→QUEUED and BUDGET_EXCEEDED→QUEUED entries
to the ADR transition table to match the implemented state machine.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

1 files changed, 21 insertions, 16 deletions

diff --git a/internal/task/task.go b/internal/task/task.go
index c0aa036..9968b15 100644
--- a/internal/task/task.go
+++ b/internal/task/task.go
@@ -52,10 +52,10 @@ type Task struct {
 	ID           string       `yaml:"id"            json:"id"`
 	ParentTaskID string       `yaml:"parent_task_id" json:"parent_task_id"`
 	Name         string       `yaml:"name"          json:"name"`
-	Description string       `yaml:"description" json:"description"`
-	Agent       AgentConfig `yaml:"agent"     json:"agent"`
-	Timeout     Duration     `yaml:"timeout"    json:"timeout"`
-	Retry       RetryConfig  `yaml:"retry"      json:"retry"`
+	Description  string       `yaml:"description"    json:"description"`
+	Agent        AgentConfig  `yaml:"agent"          json:"agent"`
+	Timeout      Duration     `yaml:"timeout"        json:"timeout"`
+	Retry        RetryConfig  `yaml:"retry"          json:"retry"`
 	Priority    Priority     `yaml:"priority"   json:"priority"`
 	Tags        []string     `yaml:"tags"       json:"tags"`
 	DependsOn   []string     `yaml:"depends_on" json:"depends_on"`
@@ -93,20 +93,25 @@ type BatchFile struct {
 	Tasks []Task `yaml:"tasks"`
 }
 
+// validTransitions maps each state to the set of states it may transition into.
+// Terminal state COMPLETED has no outgoing edges.
+// CANCELLED, FAILED, TIMED_OUT, and BUDGET_EXCEEDED all allow re-entry at QUEUED
+// (restart or retry).
+var validTransitions = map[State][]State{
+	StatePending:        {StateQueued, StateCancelled},
+	StateQueued:         {StateRunning, StateCancelled},
+	StateRunning:        {StateReady, StateCompleted, StateFailed, StateTimedOut, StateCancelled, StateBudgetExceeded, StateBlocked},
+	StateReady:          {StateCompleted, StatePending},
+	StateFailed:         {StateQueued}, // retry
+	StateTimedOut:       {StateQueued}, // retry or resume
+	StateCancelled:      {StateQueued}, // restart
+	StateBudgetExceeded: {StateQueued}, // retry
+	StateBlocked:        {StateQueued, StateReady},
+}
+
 // ValidTransition returns true if moving from the current state to next is allowed.
 func ValidTransition(from, to State) bool {
-	transitions := map[State][]State{
-		StatePending:   {StateQueued, StateCancelled},
-		StateQueued:    {StateRunning, StateCancelled},
-		StateRunning:   {StateReady, StateCompleted, StateFailed, StateTimedOut, StateCancelled, StateBudgetExceeded, StateBlocked},
-		StateReady:     {StateCompleted, StatePending},
-		StateFailed:    {StateQueued}, // retry
-		StateTimedOut:       {StateQueued}, // retry
-		StateCancelled:      {StateQueued}, // restart
-		StateBudgetExceeded: {StateQueued}, // retry
-		StateBlocked:        {StateQueued, StateReady}, // answer received → re-queue as resume execution
-	}
-	for _, allowed := range transitions[from] {
+	for _, allowed := range validTransitions[from] {
 		if allowed == to {
 			return true
 		}