summaryrefslogtreecommitdiff
path: root/internal/storage/db.go
diff options
context:
space:
mode:
authorClaude <noreply@anthropic.com>2026-05-03 08:00:20 +0000
committerClaude <noreply@anthropic.com>2026-05-03 08:00:20 +0000
commite7b382bf177cbe518af3d86c3ee6c49344d225f4 (patch)
tree4dc822097b7f32a37ad655a550da1abada79ce85 /internal/storage/db.go
parent1ec3f87c392145580a62858110d9fd10638203db (diff)
chore: close deferred work — real GeminiRunner, Local UI option, db.go cleanup
Closes the three items left on the deferred queue after the post-epic cleanup. GeminiRunner.execOnce now actually executes the gemini binary instead of writing hardcoded stream data. Mirrors ClaudeRunner.execOnce: - exec.CommandContext with the same env vars (CLAUDOMATOR_API_URL etc.) - process group SIGKILL on context cancel - stdout piped through parseGeminiStream → stdoutFile - stderr to file - exit codes captured, stderr tail surfaced on failure Test infrastructure bug uncovered in passing: testServerWithGeminiMockRunner's mock script used double-quoted echo with literal triple-backticks, which bash interpreted as command substitution. The script always produced empty output. The bug was invisible until now because GeminiRunner ignored the script entirely. Switched to a single-quoted heredoc. Frontend: index.html dropdown gains a "Local" option. No JS branching needed — the value flows through to agent.type verbatim and downstream display reads the type string as-is. storage/db.go: removed stale debug-comment scaffolding (the "TODO: Replace with proper logger" block) that was tracking a dead `fmt.Printf` call. The path it commented on is fine without logging — unmarshal errors are returned wrapped. Test status: `go test -race ./...` green across every package, zero skips, zero excluded tests. https://claude.ai/code/session_017Edeq947TpSm1vQTxMhi1J
Diffstat (limited to 'internal/storage/db.go')
-rw-r--r--internal/storage/db.go5
1 files changed, 0 insertions, 5 deletions
diff --git a/internal/storage/db.go b/internal/storage/db.go
index c871c77..ce60e2f 100644
--- a/internal/storage/db.go
+++ b/internal/storage/db.go
@@ -699,11 +699,6 @@ func scanTask(row scanner) (*task.Task, error) {
t.State = task.State(state)
t.Priority = task.Priority(priority)
t.Timeout.Duration = time.Duration(timeoutNS)
- // Add debug log for configJSON
- // The logger is not available directly in db.go, so I'll use fmt.Printf for now.
- // For production code, a logger should be injected.
- // fmt.Printf("DEBUG: configJSON from DB: %s\n", configJSON)
- // TODO: Replace with proper logger when available.
if err := json.Unmarshal([]byte(configJSON), &t.Agent); err != nil {
return nil, fmt.Errorf("unmarshaling agent config: %w", err)
}