feat: auto-create validation task on story DEPLOYED (ADR-007)

2 files changed, 99 insertions, 0 deletions

diff --git a/internal/executor/executor.go b/internal/executor/executor.go
index 2ab17a7..745c6d6 100644
--- a/internal/executor/executor.go
+++ b/internal/executor/executor.go
@@ -37,6 +37,7 @@ type Store interface {
 	GetStory(id string) (*task.Story, error)
 	ListTasksByStory(storyID string) ([]*task.Task, error)
 	UpdateStoryStatus(id string, status task.StoryState) error
+	CreateTask(t *task.Task) error
 }
 
 // LogPather is an optional interface runners can implement to provide the log
@@ -490,6 +491,53 @@ func (p *Pool) triggerStoryDeploy(ctx context.Context, storyID string) {
 		return
 	}
 	p.logger.Info("story transitioned to DEPLOYED", "storyID", storyID)
+	go p.createValidationTask(ctx, storyID)
+}
+
+// createValidationTask creates a validation subtask from the story's ValidationJSON
+// and transitions the story to VALIDATING.
+func (p *Pool) createValidationTask(ctx context.Context, storyID string) {
+	story, err := p.store.GetStory(storyID)
+	if err != nil {
+		p.logger.Error("createValidationTask: failed to get story", "storyID", storyID, "error", err)
+		return
+	}
+	if story.ValidationJSON == "" {
+		p.logger.Warn("createValidationTask: story has no ValidationJSON, skipping", "storyID", storyID)
+		return
+	}
+
+	var spec map[string]interface{}
+	if err := json.Unmarshal([]byte(story.ValidationJSON), &spec); err != nil {
+		p.logger.Error("createValidationTask: failed to parse ValidationJSON", "storyID", storyID, "error", err)
+		return
+	}
+
+	instructions := fmt.Sprintf("Validate the deployment for story %q.\n\nValidation spec:\n%s", story.Name, story.ValidationJSON)
+
+	now := time.Now().UTC()
+	vtask := &task.Task{
+		ID:        uuid.New().String(),
+		Name:      fmt.Sprintf("validation: %s", story.Name),
+		StoryID:   storyID,
+		State:     task.StateQueued,
+		Agent:     task.AgentConfig{Type: "claude", Instructions: instructions},
+		Tags:      []string{},
+		DependsOn: []string{},
+		CreatedAt: now,
+		UpdatedAt: now,
+	}
+
+	if err := p.store.CreateTask(vtask); err != nil {
+		p.logger.Error("createValidationTask: failed to create task", "storyID", storyID, "error", err)
+		return
+	}
+	if err := p.store.UpdateStoryStatus(storyID, task.StoryValidating); err != nil {
+		p.logger.Error("createValidationTask: failed to update story status", "storyID", storyID, "error", err)
+		return
+	}
+	p.logger.Info("validation task created and story transitioned to VALIDATING", "storyID", storyID, "taskID", vtask.ID)
+	p.Submit(ctx, vtask) //nolint:errcheck
 }
 
 // UndrainingAgent resets the drain state and failure counter for the given agent type.
diff --git a/internal/executor/executor_test.go b/internal/executor/executor_test.go
index 9a36c50..9e39f14 100644
--- a/internal/executor/executor_test.go
+++ b/internal/executor/executor_test.go
@@ -1061,6 +1061,7 @@ func (m *minimalMockStore) GetProject(_ string) (*task.Project, error)         {
 func (m *minimalMockStore) GetStory(_ string) (*task.Story, error)             { return nil, nil }
 func (m *minimalMockStore) ListTasksByStory(_ string) ([]*task.Task, error)    { return nil, nil }
 func (m *minimalMockStore) UpdateStoryStatus(_ string, _ task.StoryState) error { return nil }
+func (m *minimalMockStore) CreateTask(_ *task.Task) error                      { return nil }
 
 func (m *minimalMockStore) lastStateUpdate() (string, task.State, bool) {
 	m.mu.Lock()
@@ -1807,3 +1808,53 @@ func TestPool_StoryDeploy_RunsDeployScript(t *testing.T) {
 		t.Errorf("story status: want DEPLOYED, got %q", got.Status)
 	}
 }
+
+func TestPool_PostDeploy_CreatesValidationTask(t *testing.T) {
+	store := testStore(t)
+	logger := slog.New(slog.NewTextHandler(os.Stderr, &slog.HandlerOptions{Level: slog.LevelError}))
+	pool := NewPool(2, map[string]Runner{"claude": &mockRunner{}}, store, logger)
+
+	now := time.Now().UTC()
+	validationSpec := `{"type":"smoke","steps":["curl /health"],"success_criteria":"status 200"}`
+	story := &task.Story{
+		ID:             "story-postdeploy-1",
+		Name:           "Post Deploy Test",
+		Status:         task.StoryDeployed,
+		ValidationJSON: validationSpec,
+		CreatedAt:      now,
+		UpdatedAt:      now,
+	}
+	if err := store.CreateStory(story); err != nil {
+		t.Fatalf("CreateStory: %v", err)
+	}
+
+	pool.createValidationTask(context.Background(), story.ID)
+
+	// Story should now be VALIDATING.
+	got, err := store.GetStory(story.ID)
+	if err != nil {
+		t.Fatalf("GetStory: %v", err)
+	}
+	if got.Status != task.StoryValidating {
+		t.Errorf("story status: want VALIDATING, got %q", got.Status)
+	}
+
+	// A validation task should have been created.
+	tasks, err := store.ListTasksByStory(story.ID)
+	if err != nil {
+		t.Fatalf("ListTasksByStory: %v", err)
+	}
+	if len(tasks) == 0 {
+		t.Fatal("expected a validation task to be created, got none")
+	}
+	vtask := tasks[0]
+	if !strings.Contains(strings.ToLower(vtask.Name), "validation") {
+		t.Errorf("task name %q does not contain 'validation'", vtask.Name)
+	}
+	if vtask.StoryID != story.ID {
+		t.Errorf("task story_id: want %q, got %q", story.ID, vtask.StoryID)
+	}
+	if !strings.Contains(vtask.Agent.Instructions, "smoke") {
+		t.Errorf("task instructions %q do not reference validation spec content", vtask.Agent.Instructions)
+	}
+}