Merge branch 'master' of /site/git.terst.org/repos/claudomator

1 files changed, 158 insertions, 0 deletions

diff --git a/internal/executor/executor_test.go b/internal/executor/executor_test.go
index b93e819..44fa7b5 100644
--- a/internal/executor/executor_test.go
+++ b/internal/executor/executor_test.go
@@ -1061,6 +1061,7 @@ func (m *minimalMockStore) GetProject(_ string) (*task.Project, error)
 func (m *minimalMockStore) GetStory(_ string) (*task.Story, error)              { return nil, nil }
 func (m *minimalMockStore) ListTasksByStory(_ string) ([]*task.Task, error)     { return nil, nil }
 func (m *minimalMockStore) UpdateStoryStatus(_ string, _ task.StoryState) error { return nil }
+func (m *minimalMockStore) CreateTask(_ *task.Task) error                      { return nil }
 
 func (m *minimalMockStore) lastStateUpdate() (string, task.State, bool) {
 	m.mu.Lock()
@@ -1757,3 +1758,160 @@ func TestPool_Undrain_ResumesExecution(t *testing.T) {
 		t.Fatal("timed out waiting for task after undrain")
 	}
 }
+
+func TestPool_StoryDeploy_RunsDeployScript(t *testing.T) {
+	store := testStore(t)
+	runner := &mockRunner{}
+	runners := map[string]Runner{"claude": runner}
+	logger := slog.New(slog.NewTextHandler(os.Stderr, &slog.HandlerOptions{Level: slog.LevelError}))
+	pool := NewPool(2, runners, store, logger)
+
+	// Create a deploy script that writes a marker file.
+	tmpDir := t.TempDir()
+	markerFile := filepath.Join(tmpDir, "deployed.marker")
+	scriptPath := filepath.Join(tmpDir, "deploy.sh")
+	scriptContent := "#!/bin/sh\ntouch " + markerFile + "\n"
+	if err := os.WriteFile(scriptPath, []byte(scriptContent), 0755); err != nil {
+		t.Fatalf("write deploy script: %v", err)
+	}
+
+	proj := &task.Project{
+		ID:           "proj-deploy-1",
+		Name:         "Deploy Test Project",
+		DeployScript: scriptPath,
+	}
+	if err := store.CreateProject(proj); err != nil {
+		t.Fatalf("create project: %v", err)
+	}
+
+	story := &task.Story{
+		ID:        "story-deploy-1",
+		Name:      "Deploy Test Story",
+		ProjectID: proj.ID,
+		Status:    task.StoryShippable,
+	}
+	if err := store.CreateStory(story); err != nil {
+		t.Fatalf("create story: %v", err)
+	}
+
+	pool.triggerStoryDeploy(context.Background(), story.ID)
+
+	if _, err := os.Stat(markerFile); os.IsNotExist(err) {
+		t.Error("deploy script did not run: marker file not found")
+	}
+
+	got, err := store.GetStory(story.ID)
+	if err != nil {
+		t.Fatalf("get story: %v", err)
+	}
+	if got.Status != task.StoryDeployed {
+		t.Errorf("story status: want DEPLOYED, got %q", got.Status)
+	}
+}
+
+func TestPool_PostDeploy_CreatesValidationTask(t *testing.T) {
+	store := testStore(t)
+	logger := slog.New(slog.NewTextHandler(os.Stderr, &slog.HandlerOptions{Level: slog.LevelError}))
+	pool := NewPool(2, map[string]Runner{"claude": &mockRunner{}}, store, logger)
+
+	now := time.Now().UTC()
+	validationSpec := `{"type":"smoke","steps":["curl /health"],"success_criteria":"status 200"}`
+	story := &task.Story{
+		ID:             "story-postdeploy-1",
+		Name:           "Post Deploy Test",
+		Status:         task.StoryDeployed,
+		ValidationJSON: validationSpec,
+		CreatedAt:      now,
+		UpdatedAt:      now,
+	}
+	if err := store.CreateStory(story); err != nil {
+		t.Fatalf("CreateStory: %v", err)
+	}
+
+	pool.createValidationTask(context.Background(), story.ID)
+
+	// Story should now be VALIDATING.
+	got, err := store.GetStory(story.ID)
+	if err != nil {
+		t.Fatalf("GetStory: %v", err)
+	}
+	if got.Status != task.StoryValidating {
+		t.Errorf("story status: want VALIDATING, got %q", got.Status)
+	}
+
+	// A validation task should have been created.
+	tasks, err := store.ListTasksByStory(story.ID)
+	if err != nil {
+		t.Fatalf("ListTasksByStory: %v", err)
+	}
+	if len(tasks) == 0 {
+		t.Fatal("expected a validation task to be created, got none")
+	}
+	vtask := tasks[0]
+	if !strings.Contains(strings.ToLower(vtask.Name), "validation") {
+		t.Errorf("task name %q does not contain 'validation'", vtask.Name)
+	}
+	if vtask.StoryID != story.ID {
+		t.Errorf("task story_id: want %q, got %q", story.ID, vtask.StoryID)
+	}
+	if !strings.Contains(vtask.Agent.Instructions, "smoke") {
+		t.Errorf("task instructions %q do not reference validation spec content", vtask.Agent.Instructions)
+	}
+}
+
+func TestPool_ValidationTask_Pass_SetsReviewReady(t *testing.T) {
+	store := testStore(t)
+	logger := slog.New(slog.NewTextHandler(os.Stderr, &slog.HandlerOptions{Level: slog.LevelError}))
+	pool := NewPool(2, map[string]Runner{"claude": &mockRunner{}}, store, logger)
+
+	now := time.Now().UTC()
+	story := &task.Story{
+		ID:        "story-val-pass-1",
+		Name:      "Validation Pass",
+		Status:    task.StoryValidating,
+		CreatedAt: now,
+		UpdatedAt: now,
+	}
+	if err := store.CreateStory(story); err != nil {
+		t.Fatalf("CreateStory: %v", err)
+	}
+
+	pool.checkValidationResult(context.Background(), story.ID, task.StateCompleted, "")
+
+	got, err := store.GetStory(story.ID)
+	if err != nil {
+		t.Fatalf("GetStory: %v", err)
+	}
+	if got.Status != task.StoryReviewReady {
+		t.Errorf("story status: want REVIEW_READY, got %q", got.Status)
+	}
+}
+
+func TestPool_ValidationTask_Fail_SetsNeedsFix(t *testing.T) {
+	store := testStore(t)
+	logger := slog.New(slog.NewTextHandler(os.Stderr, &slog.HandlerOptions{Level: slog.LevelError}))
+	pool := NewPool(2, map[string]Runner{"claude": &mockRunner{}}, store, logger)
+
+	now := time.Now().UTC()
+	story := &task.Story{
+		ID:        "story-val-fail-1",
+		Name:      "Validation Fail",
+		Status:    task.StoryValidating,
+		CreatedAt: now,
+		UpdatedAt: now,
+	}
+	if err := store.CreateStory(story); err != nil {
+		t.Fatalf("CreateStory: %v", err)
+	}
+
+	execErr := "smoke test failed: /health returned 503"
+	pool.checkValidationResult(context.Background(), story.ID, task.StateFailed, execErr)
+
+	got, err := store.GetStory(story.ID)
+	if err != nil {
+		t.Fatalf("GetStory: %v", err)
+	}
+	if got.Status != task.StoryNeedsFix {
+		t.Errorf("story status: want NEEDS_FIX, got %q", got.Status)
+	}
+}